From: Greg KH <greg@kroah.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Johannes Berg <johannes.berg@intel.com>,
David Howells <dhowells@redhat.com>
Subject: Re: linux-next: build failure after merge of the wireless-next tree
Date: Thu, 13 Feb 2014 10:28:09 -0800 [thread overview]
Message-ID: <20140213182809.GB32578@kroah.com> (raw)
In-Reply-To: <CAP=VYLpa7yOZb4bgT6jNkLaEmDVHpKkwm07x8--URvUFEb+E2Q@mail.gmail.com>
On Thu, Feb 13, 2014 at 01:22:15PM -0500, Paul Gortmaker wrote:
> On Thu, Feb 13, 2014 at 12:31 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> > On Wed, Feb 12, 2014 at 9:19 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >> Hi John,
> >>
> >> After merging the wireless-next tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >>
> >> drivers/staging/rtl8821ae/rc.c:289:2: error: unknown field 'module' specified in initializer
> >> .module = NULL,
> >> ^
> >>
> >> Caused by commit cc01f9b55fe7 ("mac80211: remove module handling from
> >> rate control ops") interacting with commit 3c05bedb5fef ("Staging:
> >> rtl8812ae: Add Realtek 8821 PCI WIFI driver") which entered Linus' tree
> >> before v3.14-rc1.
> >
> > It seems this new driver has multiple issues; I'm seeing this on sparc32
> > allmodconfig builds.
> >
> > In file included from drivers/staging/rtl8821ae/btcoexist/halbt_precomp.h:31:0,
> > from drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c:14:
> > drivers/staging/rtl8821ae/btcoexist/../pci.h:290:15: error: expected
> > '=', ',', ';', 'asm' or '__attribute__' before 'rtl_pci_probe'
> > make[3]: *** [drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.o] Error 1
> > make[3]: *** Waiting for unfinished jobs....
> >
> > It looks like a mangled version check which is allowing it to try and use
> > __devinit on the rtl_pci_probe function, but of course __devinit is gone.
> >
> > Ideally all that version check stuff should be gutted.
>
> While it still should be gutted, I tracked down the source of the version
> skew. If a person is bisecting and if you go back to pre-UAPI days,
> you will create an include/linux/version.h -- then if you checkout a
> post-UAPI kernel, and run "make distclean" it won't delete that file.
> So you get a situation like this:
>
> $ grep -R LINUX_VERSION_CODE include/
> include/generated/uapi/linux/version.h:#define LINUX_VERSION_CODE 200192
> include/linux/version.h:#define LINUX_VERSION_CODE 132646
>
> Note the presence of a v2.6.38 version. And it will be sourced/used,
> hence the fail above. We might want to unconditionally clobber the
> old file in new kernels to avoid this trap, since it is subtle.
Yeah, I've run into that problem a number of times before, a 'git clean
-fdx' usually fixes it up for me, and is why I do it all the time when
switching major kernel versions.
thanks,
greg k-h
next prev parent reply other threads:[~2014-02-13 18:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 2:19 linux-next: build failure after merge of the wireless-next tree Stephen Rothwell
2014-02-13 2:22 ` Stephen Rothwell
2014-02-13 17:31 ` Paul Gortmaker
2014-02-13 18:22 ` Paul Gortmaker
2014-02-13 18:28 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-09-08 8:42 Stephen Rothwell
2014-09-09 23:28 ` Stephen Rothwell
2014-09-09 23:37 ` David Miller
2014-09-10 17:46 ` John W. Linville
2014-07-16 3:28 Stephen Rothwell
2014-07-16 14:09 ` John W. Linville
2014-04-23 3:47 Stephen Rothwell
2014-04-23 20:54 ` Bing Zhao
2014-03-06 2:43 Stephen Rothwell
2014-03-06 8:53 ` Arend van Spriel
2014-03-06 2:24 Stephen Rothwell
2014-02-25 2:35 Stephen Rothwell
2014-02-25 19:07 ` John W. Linville
2014-02-25 20:47 ` Stephen Rothwell
2014-03-04 23:16 ` Stephen Rothwell
2014-03-04 23:21 ` Stephen Rothwell
2014-03-04 23:49 ` Greg KH
2013-07-23 1:32 Stephen Rothwell
2013-07-23 7:24 ` Hauke Mehrtens
2013-04-02 2:34 Stephen Rothwell
2013-04-02 3:07 ` Larry Finger
2013-04-02 3:31 ` Stephen Rothwell
2013-04-02 4:07 ` Larry Finger
2012-04-12 2:24 Stephen Rothwell
2011-12-20 2:18 Stephen Rothwell
2011-12-20 2:42 ` Luis R. Rodriguez
2011-12-20 2:57 ` Stephen Rothwell
2011-12-20 3:24 ` Luis R. Rodriguez
2011-11-22 3:35 Stephen Rothwell
2011-11-22 8:03 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213182809.GB32578@kroah.com \
--to=greg@kroah.com \
--cc=dhowells@redhat.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=paul.gortmaker@windriver.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).