From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Josh Cartwright <joshc@codeaurora.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: linux-next: Tree for Feb 17 (pinctrl-msm)
Date: Mon, 24 Feb 2014 11:28:13 -0800 [thread overview]
Message-ID: <20140224192813.GA4451@sonymobile.com> (raw)
In-Reply-To: <20140224184120.GB18563@joshc.qualcomm.com>
On Mon 24 Feb 10:41 PST 2014, Josh Cartwright wrote:
[...]
>
> Without too much effort, I can get this to fail just by making
> CONFIG_PINCTRL_MSM=m. handle_bad_irq isn't marked EXPORT_SYMBOL*, so
> hence the warning.
>
Ohh, yeah I missed that.
> Whether or not this is intentional is not clear. Do we support modules
> installing chained irq handlers?
>
> For now, the patch below just makes this driver 'bool' instead of
> 'tristate'.
This comes from the request of having everything as a module, to reduce the
size of the multi-platform ARM builds. I would say that the important part
related to that would be to keep the platform specific tables in modules.
But keeping these parts as modules would still mean that it's a module that
install the chained irq handler.
@Linus, I'm not sure about what should be module and not in pinctrl, but this
part of pinctrl-msm is less important then the others to be able to be compiled
as a module.
FWIW;
Reviewed-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
>
> Josh
Regards,
Bjorn
>
> --8<--
> Subject: [PATCH] pinctrl: msm: make PINCTRL_MSM bool instead of tristate
>
> Modular builds of pinctrl-msm break due to handle_bad_irq being
> unexported for module use. For now, make PINCTRL_MSM 'bool'.
>
> Signed-off-by: Josh Cartwright <joshc@codeaurora.org>
> ---
> drivers/pinctrl/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index be361b7..1e4e693 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -217,7 +217,7 @@ config PINCTRL_IMX28
> select PINCTRL_MXS
>
> config PINCTRL_MSM
> - tristate
> + bool
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation
next prev parent reply other threads:[~2014-02-24 19:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 6:23 linux-next: Tree for Feb 17 Stephen Rothwell
2014-02-17 17:33 ` linux-next: Tree for Feb 17 (pinctrl-msm) Randy Dunlap
2014-02-24 14:46 ` Linus Walleij
2014-02-24 17:46 ` Bjorn Andersson
2014-02-24 18:14 ` Randy Dunlap
2014-02-24 18:41 ` Josh Cartwright
2014-02-24 18:46 ` Randy Dunlap
2014-02-24 19:28 ` Bjorn Andersson [this message]
2014-02-25 9:44 ` Linus Walleij
2014-02-25 9:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224192813.GA4451@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=joshc@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).