From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Triplett Subject: Re: linux-next: build failure after merge of the final tree (akpm-current tree related) Date: Wed, 26 Feb 2014 02:02:34 -0800 Message-ID: <20140226100234.GA23064@thin> References: <20140226191627.9adf3c8e1548e2016c16557c@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140226191627.9adf3c8e1548e2016c16557c@canb.auug.org.au> Sender: linux-kernel-owner@vger.kernel.org To: Stephen Rothwell Cc: Andrew Morton , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-next.vger.kernel.org On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the final tree, today's linux-next build (powerpc64 > allnoconfig) failed like this: > > arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event': > (.text+0x11260): undefined reference to `.irq_work_queue' > > Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b > ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT") > from the apm-current tree. Pre-existing, just now triggerable with just "make allnoconfig" rather than manually turning off other options (like PRINTK) that select IRQ_WORK. (One of the goals of that commit: get those options more widely used and build-tested.) The following (untested) patch *should* fix this: ----- 8< ----- >>From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001 From: Josh Triplett Date: Wed, 26 Feb 2014 01:58:02 -0800 Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK arch/powerpc/kernel/mce.c, compiled in for PPC_BOOK3S_64, calls functions only built when IRQ_WORK, so select it. Fixes the following build error: arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event': (.text+0x11260): undefined reference to `.irq_work_queue' Reported-by: Stephen Rothwell Signed-off-by: Josh Triplett --- arch/powerpc/platforms/Kconfig.cputype | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 434fda3..d9e2b19 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -73,6 +73,7 @@ config PPC_BOOK3S_64 select SYS_SUPPORTS_HUGETLBFS select HAVE_ARCH_TRANSPARENT_HUGEPAGE if PPC_64K_PAGES select ARCH_SUPPORTS_NUMA_BALANCING + select IRQ_WORK config PPC_BOOK3E_64 bool "Embedded processors" -- 1.9.0