* linux-next: build failure after merge of the final tree (akpm-current tree related)
@ 2014-02-26 8:16 Stephen Rothwell
2014-02-26 10:02 ` Josh Triplett
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2014-02-26 8:16 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-next, linux-kernel, Josh Triplett
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
Hi all,
After merging the final tree, today's linux-next build (powerpc64
allnoconfig) failed like this:
arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
(.text+0x11260): undefined reference to `.irq_work_queue'
Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b
("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
from the apm-current tree.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
2014-02-26 8:16 linux-next: build failure after merge of the final tree (akpm-current tree related) Stephen Rothwell
@ 2014-02-26 10:02 ` Josh Triplett
2014-02-26 23:00 ` Stephen Rothwell
0 siblings, 1 reply; 16+ messages in thread
From: Josh Triplett @ 2014-02-26 10:02 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Andrew Morton, linux-next, linux-kernel
On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc64
> allnoconfig) failed like this:
>
> arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
> (.text+0x11260): undefined reference to `.irq_work_queue'
>
> Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b
> ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> from the apm-current tree.
Pre-existing, just now triggerable with just "make allnoconfig" rather
than manually turning off other options (like PRINTK) that select
IRQ_WORK. (One of the goals of that commit: get those options more
widely used and build-tested.)
The following (untested) patch *should* fix this:
----- 8< -----
>From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001
From: Josh Triplett <josh@joshtriplett.org>
Date: Wed, 26 Feb 2014 01:58:02 -0800
Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK
arch/powerpc/kernel/mce.c, compiled in for PPC_BOOK3S_64, calls
functions only built when IRQ_WORK, so select it. Fixes the following
build error:
arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
(.text+0x11260): undefined reference to `.irq_work_queue'
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
arch/powerpc/platforms/Kconfig.cputype | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
index 434fda3..d9e2b19 100644
--- a/arch/powerpc/platforms/Kconfig.cputype
+++ b/arch/powerpc/platforms/Kconfig.cputype
@@ -73,6 +73,7 @@ config PPC_BOOK3S_64
select SYS_SUPPORTS_HUGETLBFS
select HAVE_ARCH_TRANSPARENT_HUGEPAGE if PPC_64K_PAGES
select ARCH_SUPPORTS_NUMA_BALANCING
+ select IRQ_WORK
config PPC_BOOK3E_64
bool "Embedded processors"
--
1.9.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
2014-02-26 10:02 ` Josh Triplett
@ 2014-02-26 23:00 ` Stephen Rothwell
2014-02-26 23:17 ` Andrew Morton
` (2 more replies)
0 siblings, 3 replies; 16+ messages in thread
From: Stephen Rothwell @ 2014-02-26 23:00 UTC (permalink / raw)
To: Josh Triplett; +Cc: Andrew Morton, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]
Hi Josh,
On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett <josh@joshtriplett.org> wrote:
>
> On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote:
> >
> > After merging the final tree, today's linux-next build (powerpc64
> > allnoconfig) failed like this:
> >
> > arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
> > (.text+0x11260): undefined reference to `.irq_work_queue'
> >
> > Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b
> > ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> > from the apm-current tree.
>
> Pre-existing, just now triggerable with just "make allnoconfig" rather
> than manually turning off other options (like PRINTK) that select
> IRQ_WORK. (One of the goals of that commit: get those options more
> widely used and build-tested.)
>
> The following (untested) patch *should* fix this:
> ----- 8< -----
> From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001
> From: Josh Triplett <josh@joshtriplett.org>
> Date: Wed, 26 Feb 2014 01:58:02 -0800
> Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK
OK, I added this as a merge fix patch for Andrew's tree today. Please
check the build results overnight tonight (for next-20140227 at
http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for
the allnoconfig build errors.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
2014-02-26 23:00 ` Stephen Rothwell
@ 2014-02-26 23:17 ` Andrew Morton
2014-02-26 23:19 ` Josh Triplett
2014-02-27 2:21 ` linux-next: build failure after merge of the final tree (akpm-current tree related) Josh Triplett
2 siblings, 0 replies; 16+ messages in thread
From: Andrew Morton @ 2014-02-26 23:17 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Josh Triplett, linux-next, linux-kernel
On Thu, 27 Feb 2014 10:00:26 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Josh,
>
> On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett <josh@joshtriplett.org> wrote:
> >
> > On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote:
> > >
> > > After merging the final tree, today's linux-next build (powerpc64
> > > allnoconfig) failed like this:
> > >
> > > arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
> > > (.text+0x11260): undefined reference to `.irq_work_queue'
> > >
> > > Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b
> > > ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> > > from the apm-current tree.
> >
> > Pre-existing, just now triggerable with just "make allnoconfig" rather
> > than manually turning off other options (like PRINTK) that select
> > IRQ_WORK. (One of the goals of that commit: get those options more
> > widely used and build-tested.)
> >
> > The following (untested) patch *should* fix this:
> > ----- 8< -----
> > From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001
> > From: Josh Triplett <josh@joshtriplett.org>
> > Date: Wed, 26 Feb 2014 01:58:02 -0800
> > Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK
>
> OK, I added this as a merge fix patch for Andrew's tree today. Please
> check the build results overnight tonight (for next-20140227 at
> http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for
> the allnoconfig build errors.
yes, let's keep
kconfig-make-allnoconfig-disable-options-behind-embedded-and-expert,
please. We'll just need to slog our way through the breakage which it
exposes.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
2014-02-26 23:00 ` Stephen Rothwell
2014-02-26 23:17 ` Andrew Morton
@ 2014-02-26 23:19 ` Josh Triplett
2014-02-26 23:42 ` Stephen Rothwell
2014-02-27 2:21 ` linux-next: build failure after merge of the final tree (akpm-current tree related) Josh Triplett
2 siblings, 1 reply; 16+ messages in thread
From: Josh Triplett @ 2014-02-26 23:19 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Andrew Morton, linux-next, linux-kernel
On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote:
> Hi Josh,
>
> On Wed, 26 Feb 2014 02:02:34 -0800 Josh Triplett <josh@joshtriplett.org> wrote:
> >
> > On Wed, Feb 26, 2014 at 07:16:27PM +1100, Stephen Rothwell wrote:
> > >
> > > After merging the final tree, today's linux-next build (powerpc64
> > > allnoconfig) failed like this:
> > >
> > > arch/powerpc/kernel/built-in.o: In function `.machine_check_queue_event':
> > > (.text+0x11260): undefined reference to `.irq_work_queue'
> > >
> > > Caused (or exposed) (along with a lot of warnings) by commit 3dd6115cd60b
> > > ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> > > from the apm-current tree.
> >
> > Pre-existing, just now triggerable with just "make allnoconfig" rather
> > than manually turning off other options (like PRINTK) that select
> > IRQ_WORK. (One of the goals of that commit: get those options more
> > widely used and build-tested.)
> >
> > The following (untested) patch *should* fix this:
> > ----- 8< -----
> > From 36a5b6c87292b6c5eeb390ed6dc6acbb8f0a3767 Mon Sep 17 00:00:00 2001
> > From: Josh Triplett <josh@joshtriplett.org>
> > Date: Wed, 26 Feb 2014 01:58:02 -0800
> > Subject: [PATCH] ppc: Make PPC_BOOK3S_64 select IRQ_WORK
>
> OK, I added this as a merge fix patch for Andrew's tree today. Please
> check the build results overnight tonight (for next-20140227 at
> http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for
> the allnoconfig build errors.
Please also fold in my patch "ia64: select CONFIG_TTY for use of
tty_write_message in unaligned". (Just bounced you a copy.)
There's an s390 issue as well which needs the same fix (make the
top-level architecture symbol select TTY).
I'll look at the other issues tonight.
- Josh Triplett
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
2014-02-26 23:19 ` Josh Triplett
@ 2014-02-26 23:42 ` Stephen Rothwell
2014-02-27 2:13 ` [PATCH] s390: select CONFIG_TTY for use of tty in unconditional keyboard driver Josh Triplett
2014-02-28 1:27 ` [PATCH] cris: Make ETRAX_ARCH_V10 select TTY for use in debugport Josh Triplett
0 siblings, 2 replies; 16+ messages in thread
From: Stephen Rothwell @ 2014-02-26 23:42 UTC (permalink / raw)
To: Josh Triplett; +Cc: Andrew Morton, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
Hi Josh,
On Wed, 26 Feb 2014 15:19:16 -0800 Josh Triplett <josh@joshtriplett.org> wrote:
>
> Please also fold in my patch "ia64: select CONFIG_TTY for use of
> tty_write_message in unaligned". (Just bounced you a copy.)
Done.
> There's an s390 issue as well which needs the same fix (make the
> top-level architecture symbol select TTY).
>
> I'll look at the other issues tonight.
OK, thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] s390: select CONFIG_TTY for use of tty in unconditional keyboard driver
2014-02-26 23:42 ` Stephen Rothwell
@ 2014-02-27 2:13 ` Josh Triplett
2014-02-27 2:43 ` Stephen Rothwell
2014-02-27 7:07 ` Heiko Carstens
2014-02-28 1:27 ` [PATCH] cris: Make ETRAX_ARCH_V10 select TTY for use in debugport Josh Triplett
1 sibling, 2 replies; 16+ messages in thread
From: Josh Triplett @ 2014-02-27 2:13 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Andrew Morton, linux-next, linux-kernel, Martin Schwidefsky,
Heiko Carstens, linux390, linux-s390
The unconditionally built keyboard driver, drivers/s390/char/keyboard.c,
requires CONFIG_TTY, so select it from CONFIG_S390 to prevent a build
error.
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
arch/s390/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index 65a0775..398efa1 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -140,6 +140,7 @@ config S390
select OLD_SIGACTION
select OLD_SIGSUSPEND3
select SYSCTL_EXCEPTION_TRACE
+ select TTY
select VIRT_CPU_ACCOUNTING
select VIRT_TO_BUS
--
1.9.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
2014-02-26 23:00 ` Stephen Rothwell
2014-02-26 23:17 ` Andrew Morton
2014-02-26 23:19 ` Josh Triplett
@ 2014-02-27 2:21 ` Josh Triplett
2014-02-27 2:40 ` Stephen Rothwell
2 siblings, 1 reply; 16+ messages in thread
From: Josh Triplett @ 2014-02-27 2:21 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Andrew Morton, linux-next, linux-kernel
On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote:
> Please check the build results overnight tonight (for next-20140227 at
> http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for
> the allnoconfig build errors.
Checking that site, I don't see any other instances of failures caused
by allnoconfig. If I'm missing some, could you please point me to the
page on that site I'm missing?
- Josh Triplett
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
2014-02-27 2:21 ` linux-next: build failure after merge of the final tree (akpm-current tree related) Josh Triplett
@ 2014-02-27 2:40 ` Stephen Rothwell
2014-02-28 1:29 ` Josh Triplett
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2014-02-27 2:40 UTC (permalink / raw)
To: Josh Triplett; +Cc: Andrew Morton, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
Hi Josh,
On Wed, 26 Feb 2014 18:21:29 -0800 Josh Triplett <josh@joshtriplett.org> wrote:
>
> On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote:
> > Please check the build results overnight tonight (for next-20140227 at
> > http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for
> > the allnoconfig build errors.
>
> Checking that site, I don't see any other instances of failures caused
> by allnoconfig. If I'm missing some, could you please point me to the
> page on that site I'm missing?
That is because your patch was reverted in yesterday's (next-20140226)
linux-next. You will need to look tomorrow (next-20140227) sometime.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] s390: select CONFIG_TTY for use of tty in unconditional keyboard driver
2014-02-27 2:13 ` [PATCH] s390: select CONFIG_TTY for use of tty in unconditional keyboard driver Josh Triplett
@ 2014-02-27 2:43 ` Stephen Rothwell
2014-02-27 7:07 ` Heiko Carstens
1 sibling, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2014-02-27 2:43 UTC (permalink / raw)
To: Josh Triplett
Cc: Andrew Morton, linux-next, linux-kernel, Martin Schwidefsky,
Heiko Carstens, linux390, linux-s390
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
Hi Josh,
On Wed, 26 Feb 2014 18:13:06 -0800 Josh Triplett <josh@joshtriplett.org> wrote:
>
> The unconditionally built keyboard driver, drivers/s390/char/keyboard.c,
> requires CONFIG_TTY, so select it from CONFIG_S390 to prevent a build
> error.
>
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
Will be added to linux-next today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] s390: select CONFIG_TTY for use of tty in unconditional keyboard driver
2014-02-27 2:13 ` [PATCH] s390: select CONFIG_TTY for use of tty in unconditional keyboard driver Josh Triplett
2014-02-27 2:43 ` Stephen Rothwell
@ 2014-02-27 7:07 ` Heiko Carstens
1 sibling, 0 replies; 16+ messages in thread
From: Heiko Carstens @ 2014-02-27 7:07 UTC (permalink / raw)
To: Josh Triplett
Cc: Stephen Rothwell, Andrew Morton, linux-next, linux-kernel,
Martin Schwidefsky, linux390, linux-s390
On Wed, Feb 26, 2014 at 06:13:06PM -0800, Josh Triplett wrote:
> The unconditionally built keyboard driver, drivers/s390/char/keyboard.c,
> requires CONFIG_TTY, so select it from CONFIG_S390 to prevent a build
> error.
>
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> ---
> arch/s390/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks!
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] cris: Make ETRAX_ARCH_V10 select TTY for use in debugport
2014-02-26 23:42 ` Stephen Rothwell
2014-02-27 2:13 ` [PATCH] s390: select CONFIG_TTY for use of tty in unconditional keyboard driver Josh Triplett
@ 2014-02-28 1:27 ` Josh Triplett
2014-02-28 2:30 ` Stephen Rothwell
1 sibling, 1 reply; 16+ messages in thread
From: Josh Triplett @ 2014-02-28 1:27 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Andrew Morton, linux-next, linux-kernel, Mikael Starvik,
Jesper Nilsson, linux-cris-kernel
arch/cris/arch-v10/kernel/debugport.c, compiled in unconditionally with
ETRAX_ARCH_V10, requires TTY, so select TTY to avoid a build failure.
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---
arch/cris/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/cris/Kconfig b/arch/cris/Kconfig
index ed0fcdf..7cb90a5 100644
--- a/arch/cris/Kconfig
+++ b/arch/cris/Kconfig
@@ -138,6 +138,7 @@ config ETRAX_ARCH_V10
bool
default y if ETRAX100LX || ETRAX100LX_V2
default n if !(ETRAX100LX || ETRAX100LX_V2)
+ select TTY
config ETRAX_ARCH_V32
bool
--
1.9.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: linux-next: build failure after merge of the final tree (akpm-current tree related)
2014-02-27 2:40 ` Stephen Rothwell
@ 2014-02-28 1:29 ` Josh Triplett
0 siblings, 0 replies; 16+ messages in thread
From: Josh Triplett @ 2014-02-28 1:29 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Andrew Morton, linux-next, linux-kernel
On Thu, Feb 27, 2014 at 01:40:57PM +1100, Stephen Rothwell wrote:
> Hi Josh,
>
> On Wed, 26 Feb 2014 18:21:29 -0800 Josh Triplett <josh@joshtriplett.org> wrote:
> >
> > On Thu, Feb 27, 2014 at 10:00:26AM +1100, Stephen Rothwell wrote:
> > > Please check the build results overnight tonight (for next-20140227 at
> > > http://kisskb.ellerman.id.au/linux-next) and submit any more fixes for
> > > the allnoconfig build errors.
> >
> > Checking that site, I don't see any other instances of failures caused
> > by allnoconfig. If I'm missing some, could you please point me to the
> > page on that site I'm missing?
>
> That is because your patch was reverted in yesterday's (next-20140226)
> linux-next. You will need to look tomorrow (next-20140227) sometime.
It looks like the next-20140227 builds have shown up, and I only see one
additional allnoconfig build failure exposed by my patch (TTY dependency
on cris arch-v10). I sent a patch for that one.
I *think* that should have it covered; let me know if you see any
other failures.
- Josh Triplett
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] cris: Make ETRAX_ARCH_V10 select TTY for use in debugport
2014-02-28 1:27 ` [PATCH] cris: Make ETRAX_ARCH_V10 select TTY for use in debugport Josh Triplett
@ 2014-02-28 2:30 ` Stephen Rothwell
0 siblings, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2014-02-28 2:30 UTC (permalink / raw)
To: Josh Triplett
Cc: Andrew Morton, linux-next, linux-kernel, Mikael Starvik,
Jesper Nilsson, linux-cris-kernel
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
On Thu, 27 Feb 2014 17:27:34 -0800 Josh Triplett <josh@joshtriplett.org> wrote:
>
> arch/cris/arch-v10/kernel/debugport.c, compiled in unconditionally with
> ETRAX_ARCH_V10, requires TTY, so select TTY to avoid a build failure.
>
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
Added to linux-next today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build failure after merge of the final tree (akpm-current tree related)
@ 2013-12-17 5:43 Stephen Rothwell
0 siblings, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2013-12-17 5:43 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-next, linux-kernel, Tang Chen
[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]
Hi all,
After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:
arch/powerpc/mm/mem.c: In function 'do_init_bootmem':
arch/powerpc/mm/mem.c:212:49: error: 'memblock_memory' undeclared (first use in this function)
memblock_set_node(0, (phys_addr_t)ULLONG_MAX, &memblock_memory, 0);
^
Caused by commit 3a543893d46a ("memblock: make memblock_set_node()
support different memblock_type") from the apm-current tree.
I added the following fix for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 17 Dec 2013 16:38:21 +1100
Subject: [PATCH] memblock-make-memblock_set_node-support-different-memblock_type-fix
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
arch/powerpc/mm/mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
index 231b785b726e..8c1dd23652a1 100644
--- a/arch/powerpc/mm/mem.c
+++ b/arch/powerpc/mm/mem.c
@@ -209,7 +209,7 @@ void __init do_init_bootmem(void)
/* Place all memblock_regions in the same node and merge contiguous
* memblock_regions
*/
- memblock_set_node(0, (phys_addr_t)ULLONG_MAX, &memblock_memory, 0);
+ memblock_set_node(0, (phys_addr_t)ULLONG_MAX, &memblock.memory, 0);
/* Add all physical memory to the bootmem map, mark each area
* present.
--
1.8.5.1
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 16+ messages in thread
* linux-next: build failure after merge of the final tree (akpm-current tree related)
@ 2013-08-16 7:16 Stephen Rothwell
0 siblings, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2013-08-16 7:16 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-next, linux-kernel, Jingoo Han
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
Hi all,
After merging the final tree, today's linux-next build (arm defconfig)
failed like this:
arch/arm/kernel/built-in.o: In function `parse_tag_ramdisk':
io.c:(.init.text+0xc4c): undefined reference to `rd_size'
Caused by commit bf27a0131289 ("drivers/block/brd.c: make 'rd_size'
static") from the akpm-current tree.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2014-02-28 2:30 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-26 8:16 linux-next: build failure after merge of the final tree (akpm-current tree related) Stephen Rothwell
2014-02-26 10:02 ` Josh Triplett
2014-02-26 23:00 ` Stephen Rothwell
2014-02-26 23:17 ` Andrew Morton
2014-02-26 23:19 ` Josh Triplett
2014-02-26 23:42 ` Stephen Rothwell
2014-02-27 2:13 ` [PATCH] s390: select CONFIG_TTY for use of tty in unconditional keyboard driver Josh Triplett
2014-02-27 2:43 ` Stephen Rothwell
2014-02-27 7:07 ` Heiko Carstens
2014-02-28 1:27 ` [PATCH] cris: Make ETRAX_ARCH_V10 select TTY for use in debugport Josh Triplett
2014-02-28 2:30 ` Stephen Rothwell
2014-02-27 2:21 ` linux-next: build failure after merge of the final tree (akpm-current tree related) Josh Triplett
2014-02-27 2:40 ` Stephen Rothwell
2014-02-28 1:29 ` Josh Triplett
-- strict thread matches above, loose matches on Subject: below --
2013-12-17 5:43 Stephen Rothwell
2013-08-16 7:16 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).