From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the wireless-next tree
Date: Tue, 4 Mar 2014 15:49:39 -0800 [thread overview]
Message-ID: <20140304234939.GB25144@kroah.com> (raw)
In-Reply-To: <20140305102109.948255688bc31a030fdd49d7@canb.auug.org.au>
On Wed, Mar 05, 2014 at 10:21:09AM +1100, Stephen Rothwell wrote:
> Hi John,
>
> On Wed, 5 Mar 2014 10:16:27 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > If I revert commit 161d78555435 "Revert "Staging: rtl8812ae: remove
> > modules field of rate_control_ops"", it fails differently:
> >
> > In file included from drivers/staging/wlan-ng/p80211netdev.c:91:0:
> > drivers/staging/wlan-ng/cfg80211.c: In function 'prism2_scan':
> > drivers/staging/wlan-ng/cfg80211.c:419:10: error: implicit declaration of function 'ieee80211_dsss_chan_to_freq' [-Werror=implicit-function-declaration]
> > ieee80211_dsss_chan_to_freq(msg2.dschannel.data)),
> > ^
> > drivers/staging/rtl8821ae/rtl8821ae/trx.c: In function 'rtl8821ae_rx_query_desc':
> > drivers/staging/rtl8821ae/rtl8821ae/trx.c:619:3: warning: passing argument 1 of 'ieee80211_is_robust_mgmt_frame' from incompatible pointer type [enabled by default]
> > if ((ieee80211_is_robust_mgmt_frame(hdr)) &&
> > ^
> > In file included from include/net/mac80211.h:20:0,
> > from drivers/staging/rtl8821ae/rtl8821ae/../wifi.h:38,
> > from drivers/staging/rtl8821ae/rtl8821ae/trx.c:30:
> > include/linux/ieee80211.h:2286:20: note: expected 'struct sk_buff *' but argument is of type 'struct ieee80211_hdr *'
> > static inline bool ieee80211_is_robust_mgmt_frame(struct sk_buff *skb)
> > ^
> > drivers/staging/rtl8821ae/rtl8821ae/dm.c: In function 'rtl8821ae_dm_clear_txpower_tracking_state':
> > drivers/staging/rtl8821ae/rtl8821ae/dm.c:487:31: warning: iteration 2u invokes undefined behavior [-Waggressive-loop-optimizations]
> > rtldm->bb_swing_idx_ofdm[p] = rtldm->default_ofdm_index;
> > ^
> > drivers/staging/rtl8821ae/rtl8821ae/dm.c:485:2: note: containing loop
> > for (p = RF90_PATH_A; p < MAX_RF_PATH; ++p) {
> > ^
> >
> > So please revert 161d78555435, and then fix this other error.
>
> That fix could be a simple as just disabling the affected staging tree
> driver and letting Greg know. Or you could actually fix it.
John and Larry and I have been talking about how to handle some
cross-tree issues, and I should be merging with his tree soon to handle
them, hopefully this will get resolved at that point in time as well.
thanks,
greg k-h
next prev parent reply other threads:[~2014-03-04 23:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 2:35 linux-next: build failure after merge of the wireless-next tree Stephen Rothwell
2014-02-25 19:07 ` John W. Linville
2014-02-25 20:47 ` Stephen Rothwell
2014-03-04 23:16 ` Stephen Rothwell
2014-03-04 23:21 ` Stephen Rothwell
2014-03-04 23:49 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-09-08 8:42 Stephen Rothwell
2014-09-09 23:28 ` Stephen Rothwell
2014-09-09 23:37 ` David Miller
2014-09-10 17:46 ` John W. Linville
2014-07-16 3:28 Stephen Rothwell
2014-07-16 14:09 ` John W. Linville
2014-04-23 3:47 Stephen Rothwell
2014-04-23 20:54 ` Bing Zhao
2014-03-06 2:43 Stephen Rothwell
2014-03-06 8:53 ` Arend van Spriel
2014-03-06 2:24 Stephen Rothwell
2014-02-13 2:19 Stephen Rothwell
2014-02-13 2:22 ` Stephen Rothwell
2014-02-13 17:31 ` Paul Gortmaker
2014-02-13 18:22 ` Paul Gortmaker
2014-02-13 18:28 ` Greg KH
2013-07-23 1:32 Stephen Rothwell
2013-07-23 7:24 ` Hauke Mehrtens
2013-04-02 2:34 Stephen Rothwell
2013-04-02 3:07 ` Larry Finger
2013-04-02 3:31 ` Stephen Rothwell
2013-04-02 4:07 ` Larry Finger
2012-04-12 2:24 Stephen Rothwell
2011-12-20 2:18 Stephen Rothwell
2011-12-20 2:42 ` Luis R. Rodriguez
2011-12-20 2:57 ` Stephen Rothwell
2011-12-20 3:24 ` Luis R. Rodriguez
2011-11-22 3:35 Stephen Rothwell
2011-11-22 8:03 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304234939.GB25144@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).