linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the libata tree
@ 2014-04-24  1:17 Stephen Rothwell
  2014-04-24 12:25 ` Tejun Heo
  0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2014-04-24  1:17 UTC (permalink / raw)
  To: Tejun Heo; +Cc: linux-next, linux-kernel, Kefeng Wang, Hans de Goede

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

Hi Tejun,

After merging the libata tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/ata/libahci_platform.c: In function 'ahci_platform_init_host':
drivers/ata/libahci_platform.c:317:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  pi.private_data = (void *)host_flags
                    ^
drivers/ata/libahci_platform.c:318:2: error: expected ';' before 'hpriv'
  hpriv->flags |= host_flags;
  ^

Please test build this stuff ...

Caused by commit ac795a7ec2d2 ("libahci_platform: add host_flags parameter
in ahci_platform_init_host()").

I have used the libata tree from next-20140423 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: linux-next: build failure after merge of the libata tree
  2014-04-24  1:17 linux-next: build failure after merge of the libata tree Stephen Rothwell
@ 2014-04-24 12:25 ` Tejun Heo
  0 siblings, 0 replies; 22+ messages in thread
From: Tejun Heo @ 2014-04-24 12:25 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Kefeng Wang, Hans de Goede

Hello,

On Thu, Apr 24, 2014 at 11:17:54AM +1000, Stephen Rothwell wrote:
> After merging the libata tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/ata/libahci_platform.c: In function 'ahci_platform_init_host':
> drivers/ata/libahci_platform.c:317:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   pi.private_data = (void *)host_flags
>                     ^
> drivers/ata/libahci_platform.c:318:2: error: expected ';' before 'hpriv'
>   hpriv->flags |= host_flags;
>   ^
> 
> Please test build this stuff ...

My apologies.

> Caused by commit ac795a7ec2d2 ("libahci_platform: add host_flags parameter
> in ahci_platform_init_host()").
> 
> I have used the libata tree from next-20140423 for today.

Reverted.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: linux-next: build failure after merge of the libata tree
  2022-01-07  0:17   ` Stephen Rothwell
@ 2022-01-07  1:28     ` Damien Le Moal
  0 siblings, 0 replies; 22+ messages in thread
From: Damien Le Moal @ 2022-01-07  1:28 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Hannes Reinecke, Linux Kernel Mailing List, Linux Next Mailing List

On 2022/01/07 9:17, Stephen Rothwell wrote:
> Hi Damien,
> 
> On Fri, 7 Jan 2022 08:58:48 +0900 Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote:
>>
>> I fixed that yesterday afternoon my time (Japan), so before your morning in the
>> US (assuming you are based there).
> 
> No, Australia (so +1100) at the moment (see my email headers :-)).

Indeed. So you are only two hour ahead of me :)

> 
> I do fetch trees regularly during the day, but I merged your tree at
> about 13:28 yesterday (11:28 your time), but the build failure did not
> happen until I did the powerpc allyesconfig build at about 1am this
> morning.

OK. My update went in later in the day. I tested only on my x86_64 host native
compile. I did not setup cross compile for all arch.

> 
> Thanks for fixing this, it will be in today's release.

Great ! Thanks !


-- 
Damien Le Moal
Western Digital Research

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: linux-next: build failure after merge of the libata tree
  2022-01-06 23:58 ` Damien Le Moal
@ 2022-01-07  0:17   ` Stephen Rothwell
  2022-01-07  1:28     ` Damien Le Moal
  0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2022-01-07  0:17 UTC (permalink / raw)
  To: Damien Le Moal
  Cc: Hannes Reinecke, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

Hi Damien,

On Fri, 7 Jan 2022 08:58:48 +0900 Damien Le Moal <damien.lemoal@opensource.wdc.com> wrote:
>
> I fixed that yesterday afternoon my time (Japan), so before your morning in the
> US (assuming you are based there).

No, Australia (so +1100) at the moment (see my email headers :-)).

I do fetch trees regularly during the day, but I merged your tree at
about 13:28 yesterday (11:28 your time), but the build failure did not
happen until I did the powerpc allyesconfig build at about 1am this
morning.

Thanks for fixing this, it will be in today's release.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: linux-next: build failure after merge of the libata tree
  2022-01-06 14:08 Stephen Rothwell
@ 2022-01-06 23:58 ` Damien Le Moal
  2022-01-07  0:17   ` Stephen Rothwell
  0 siblings, 1 reply; 22+ messages in thread
From: Damien Le Moal @ 2022-01-06 23:58 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Hannes Reinecke, Linux Kernel Mailing List, Linux Next Mailing List

On 2022/01/06 23:08, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the libata tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/ata/pata_cs5535.c:26:10: fatal error: asm/msr.h: No such file or directory
>    26 | #include <asm/msr.h>
>       |          ^~~~~~~~~~~
> 
> Caused by commit
> 
>   39d0a5fc445a ("ata: pata_cs5535: add compile test support")
> 
> I have reverted that commit for today.
> 

I fixed that yesterday afternoon my time (Japan), so before your morning in the
US (assuming you are based there).

-- 
Damien Le Moal
Western Digital Research

^ permalink raw reply	[flat|nested] 22+ messages in thread

* linux-next: build failure after merge of the libata tree
@ 2022-01-06 14:08 Stephen Rothwell
  2022-01-06 23:58 ` Damien Le Moal
  0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2022-01-06 14:08 UTC (permalink / raw)
  To: Damien Le Moal
  Cc: Hannes Reinecke, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi all,

After merging the libata tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/ata/pata_cs5535.c:26:10: fatal error: asm/msr.h: No such file or directory
   26 | #include <asm/msr.h>
      |          ^~~~~~~~~~~

Caused by commit

  39d0a5fc445a ("ata: pata_cs5535: add compile test support")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* linux-next: build failure after merge of the libata tree
@ 2016-05-09  0:14 Stephen Rothwell
  0 siblings, 0 replies; 22+ messages in thread
From: Stephen Rothwell @ 2016-05-09  0:14 UTC (permalink / raw)
  To: Tejun Heo; +Cc: linux-next, linux-kernel, Mans Rullgard, Christian Lamparter

Hi Tejun,

After merging the libata tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/ata/sata_dwc_460ex.c:203:2: error: unknown field 'm_master' specified in initializer
  .m_master = 1,
  ^
/home/sfr/next/next/drivers/ata/sata_dwc_460ex.c:204:2: error: unknown field 'p_master' specified in initializer
  .p_master = 0,
  ^
/home/sfr/next/next/drivers/ata/sata_dwc_460ex.c: In function 'sata_dwc_dma_init_old':
/home/sfr/next/next/drivers/ata/sata_dwc_460ex.c:269:9: error: too few arguments to function 'dw_dma_probe'
  return dw_dma_probe(hsdev->dma);
         ^

Caused by commit

  30ee9d52f7a7 ("ata: sata_dwc_460ex: use "dmas" DT property to find dma channel")

I have used the libata tree from next-20160506 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: linux-next: build failure after merge of the libata tree
  2015-09-17  4:03 Stephen Rothwell
@ 2015-09-17 11:14 ` Luis de Bethencourt
  0 siblings, 0 replies; 22+ messages in thread
From: Luis de Bethencourt @ 2015-09-17 11:14 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Tejun Heo, linux-next, linux-kernel

On Thu, Sep 17, 2015 at 02:03:36PM +1000, Stephen Rothwell wrote:
> Hi Tejun,
> 
> After merging the libata tree, today's linux-next build (powercp
> allmodconfig) failed like this:
> 
> drivers/ata/pata_macio.c:1347:1: error: 'pata_macio_patch' undeclared here (not in a function)
> drivers/ata/pata_macio.c:1347:1: error: '__mod_of__pata_macio_patch_device_table' aliased to undefined symbol 'pata_macio_patch'
> 
> Caused by commit
> 
>   5d8619769cf5 ("ata: pata_macio: Fix module autoload for OF platform driver")
> 
> A simple typo ("patch" v "match"), but clearly never build tested.
> 
> Only found after the release.
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

Sorry, this was my fault.

When I created the second version of the patch, based on -stable instead of
-next the typo creeped in and I didn't test properly.

Sending a correct version of the patch now.

Apologies,
Luis

^ permalink raw reply	[flat|nested] 22+ messages in thread

* linux-next: build failure after merge of the libata tree
@ 2015-09-17  4:03 Stephen Rothwell
  2015-09-17 11:14 ` Luis de Bethencourt
  0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2015-09-17  4:03 UTC (permalink / raw)
  To: Tejun Heo; +Cc: linux-next, linux-kernel, Luis de Bethencourt

Hi Tejun,

After merging the libata tree, today's linux-next build (powercp
allmodconfig) failed like this:

drivers/ata/pata_macio.c:1347:1: error: 'pata_macio_patch' undeclared here (not in a function)
drivers/ata/pata_macio.c:1347:1: error: '__mod_of__pata_macio_patch_device_table' aliased to undefined symbol 'pata_macio_patch'

Caused by commit

  5d8619769cf5 ("ata: pata_macio: Fix module autoload for OF platform driver")

A simple typo ("patch" v "match"), but clearly never build tested.

Only found after the release.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: linux-next: build failure after merge of the libata tree
  2014-02-26  2:55 Stephen Rothwell
@ 2014-02-26 13:49 ` Tejun Heo
  0 siblings, 0 replies; 22+ messages in thread
From: Tejun Heo @ 2014-02-26 13:49 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Lee Jones

On Wed, Feb 26, 2014 at 01:55:21PM +1100, Stephen Rothwell wrote:
> Hi Tejun,
> 
> After merging the libata tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/ata/ahci_st.c: In function 'st_ahci_probe':
> drivers/ata/ahci_st.c:159:8: error: implicit declaration of function 'ahci_platform_put_resources' [-Werror=implicit-function-declaration]
>         ahci_platform_put_resources(&pdev->dev, hpriv);
>         ^
> 
> Caused by commit 0d8d213703ff ("ahci: st: Add support for ST's SATA
> IP").  That function is defined as "static" in another file ...
> 
> I have used the version of the libata tree from next-20140225 for today.

Right, that patch was against the previous version which didn't use
devres.  The put_resources calls are no longer necessary.  Will revert
the patch for now.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 22+ messages in thread

* linux-next: build failure after merge of the libata tree
@ 2014-02-26  2:55 Stephen Rothwell
  2014-02-26 13:49 ` Tejun Heo
  0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2014-02-26  2:55 UTC (permalink / raw)
  To: Tejun Heo; +Cc: linux-next, linux-kernel, Lee Jones

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

Hi Tejun,

After merging the libata tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/ata/ahci_st.c: In function 'st_ahci_probe':
drivers/ata/ahci_st.c:159:8: error: implicit declaration of function 'ahci_platform_put_resources' [-Werror=implicit-function-declaration]
        ahci_platform_put_resources(&pdev->dev, hpriv);
        ^

Caused by commit 0d8d213703ff ("ahci: st: Add support for ST's SATA
IP").  That function is defined as "static" in another file ...

I have used the version of the libata tree from next-20140225 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: linux-next: build failure after merge of the libata tree
  2013-08-27  5:52 ` Aaron Lu
@ 2013-08-27 18:09   ` Tejun Heo
  0 siblings, 0 replies; 22+ messages in thread
From: Tejun Heo @ 2013-08-27 18:09 UTC (permalink / raw)
  To: Aaron Lu; +Cc: Stephen Rothwell, linux-next, linux-kernel, linux-ide

On Tue, Aug 27, 2013 at 01:52:09PM +0800, Aaron Lu wrote:
> From: Aaron Lu <aaron.lu@intel.com>
> Subject: [PATCH] ata: acpi: Remove ata_dev_acpi_handle stub in libata.h
> 
> The ata_dev_acpi_handle is defined in libata-acpi.c and the only
> external user is libata-zpodd.c, which is built when CONFIG_ATA_ACPI
> is set, so there is no need to make an empty stub function for
> !CONFIG_ATA_ACPI case in libata.h. It also causes compile errors due to
> acpi_handle is not defined when !CONFIG_ACPI. This patch fixes this
> problem by removing the empty stub.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Aaron Lu <aaron.lu@intel.com>

Yeap, tested and works.  Applied to libata/for-3.12.  Thanks.

Stephen, sorry about the trouble.

-- 
tejun

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: linux-next: build failure after merge of the libata tree
  2013-08-27  2:50 Stephen Rothwell
@ 2013-08-27  5:52 ` Aaron Lu
  2013-08-27 18:09   ` Tejun Heo
  0 siblings, 1 reply; 22+ messages in thread
From: Aaron Lu @ 2013-08-27  5:52 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Tejun Heo, linux-next, linux-kernel, linux-ide

On 08/27/2013 10:50 AM, Stephen Rothwell wrote:
> Hi Tejun,
> 
> After merging the libata tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> In file included from drivers/ata/libata-pmp.c:14:0:
> drivers/ata/libata.h:136:1: error: unknown type name 'acpi_handle'
>  static inline acpi_handle ata_dev_acpi_handle(struct ata_device *dev) { return NULL; }
>  ^
> 
> And several others.
> 
> Caused by commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind
> support").  All the world does not have the ACPI include files
> included via some other path ... nor wants them, I suspect.

Sorry for the trouble, my bad.
Does the below patch fix the problem?

From: Aaron Lu <aaron.lu@intel.com>
Subject: [PATCH] ata: acpi: Remove ata_dev_acpi_handle stub in libata.h

The ata_dev_acpi_handle is defined in libata-acpi.c and the only
external user is libata-zpodd.c, which is built when CONFIG_ATA_ACPI
is set, so there is no need to make an empty stub function for
!CONFIG_ATA_ACPI case in libata.h. It also causes compile errors due to
acpi_handle is not defined when !CONFIG_ACPI. This patch fixes this
problem by removing the empty stub.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
 drivers/ata/libata.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h
index 3e9cc95..eeeb778 100644
--- a/drivers/ata/libata.h
+++ b/drivers/ata/libata.h
@@ -133,7 +133,6 @@ static inline void ata_acpi_set_state(struct ata_port *ap,
 				      pm_message_t state) { }
 static inline void ata_acpi_bind_port(struct ata_port *ap) {}
 static inline void ata_acpi_bind_dev(struct ata_device *dev) {}
-static inline acpi_handle ata_dev_acpi_handle(struct ata_device *dev) { return NULL; }
 static inline void ata_scsi_acpi_bind(struct ata_device *dev) {}
 static inline void ata_scsi_acpi_unbind(struct ata_device *dev) {}
 #endif
-- 
1.8.3.2.10.g43d11f4

Thanks,
Aaron

> 
> I have used the libata tree from next-20130822 for today.
> 
> P.S. drivers/ata/libata.h seems to assume that a lot of other stuff is
> included that it does not include explicitly ...
> 


^ permalink raw reply related	[flat|nested] 22+ messages in thread

* linux-next: build failure after merge of the libata tree
@ 2013-08-27  2:50 Stephen Rothwell
  2013-08-27  5:52 ` Aaron Lu
  0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2013-08-27  2:50 UTC (permalink / raw)
  To: Tejun Heo; +Cc: linux-next, linux-kernel, Aaron Lu

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

Hi Tejun,

After merging the libata tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from drivers/ata/libata-pmp.c:14:0:
drivers/ata/libata.h:136:1: error: unknown type name 'acpi_handle'
 static inline acpi_handle ata_dev_acpi_handle(struct ata_device *dev) { return NULL; }
 ^

And several others.

Caused by commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind
support").  All the world does not have the ACPI include files
included via some other path ... nor wants them, I suspect.

I have used the libata tree from next-20130822 for today.

P.S. drivers/ata/libata.h seems to assume that a lot of other stuff is
included that it does not include explicitly ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: linux-next: build failure after merge of the libata tree
  2013-08-19  3:18 ` Terry Suereth
@ 2013-08-19 13:40   ` Tejun Heo
  0 siblings, 0 replies; 22+ messages in thread
From: Tejun Heo @ 2013-08-19 13:40 UTC (permalink / raw)
  To: Terry Suereth; +Cc: Stephen Rothwell, linux-next, linux-kernel, stable

On Sun, Aug 18, 2013 at 08:18:55PM -0700, Terry Suereth wrote:
> Per my original patch, "0x3x26" in code should be "0x3726" (as in the
> unpatched version).  I refer to "x26" in comments as a forward-looking
> assumption, but AFAIK only 3726 and 3826 exist at this time.

Heh... No idea how that happened.  Fixed.  Sorry about the trouble.

-- 
tejun

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: linux-next: build failure after merge of the libata tree
  2013-08-19  1:54 Stephen Rothwell
@ 2013-08-19  3:18 ` Terry Suereth
  2013-08-19 13:40   ` Tejun Heo
  0 siblings, 1 reply; 22+ messages in thread
From: Terry Suereth @ 2013-08-19  3:18 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Tejun Heo, linux-next, linux-kernel, stable

Per my original patch, "0x3x26" in code should be "0x3726" (as in the
unpatched version).  I refer to "x26" in comments as a forward-looking
assumption, but AFAIK only 3726 and 3826 exist at this time.

terry.suereth@gmail.com


On Sun, Aug 18, 2013 at 6:54 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Tejun,
>
> After merging the libata tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/ata/libata-pmp.c: In function 'sata_pmp_quirks':
> drivers/ata/libata-pmp.c:386:36: error: invalid suffix "x26" on integer constant
>   if (vendor == 0x1095 && (devid == 0x3x26 || devid == 0x3826)) {
>                                     ^
>
> Caused by commit f1a313ad86b9 ("libata: apply behavioral quirks to sil3826 PMP").
>
> I have used the libata tree from next-20130816 for today.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 22+ messages in thread

* linux-next: build failure after merge of the libata tree
@ 2013-08-19  1:54 Stephen Rothwell
  2013-08-19  3:18 ` Terry Suereth
  0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2013-08-19  1:54 UTC (permalink / raw)
  To: Tejun Heo; +Cc: linux-next, linux-kernel, Terry Suereth, stable

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Hi Tejun,

After merging the libata tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/ata/libata-pmp.c: In function 'sata_pmp_quirks':
drivers/ata/libata-pmp.c:386:36: error: invalid suffix "x26" on integer constant
  if (vendor == 0x1095 && (devid == 0x3x26 || devid == 0x3826)) {
                                    ^

Caused by commit f1a313ad86b9 ("libata: apply behavioral quirks to sil3826 PMP").

I have used the libata tree from next-20130816 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: linux-next: build failure after merge of the libata tree
  2012-07-02  2:10 Stephen Rothwell
@ 2012-07-02  2:19 ` huang ying
  0 siblings, 0 replies; 22+ messages in thread
From: huang ying @ 2012-07-02  2:19 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Jeff Garzik, linux-next, linux-kernel, Lin Ming, Huang Ying,
	Bjorn Helgaas

Hi, Stephen,

On Mon, Jul 2, 2012 at 10:10 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Jeff,
>
> After merging the libata tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/ata/libata-acpi.c: In function 'ata_acpi_set_state':
> drivers/ata/libata-acpi.c:872:5: error: too few arguments to function 'acpi_pm_device_sleep_state'
> include/acpi/acpi_bus.h:418:5: note: declared here
>
> Caused by commit 3bd46600a7a7 ("libata-acpi: add ata port runtime D3Cold
> support") from the libata tree interacting with commit ee85f543710d
> ("ACPI/PM: specify lowest allowed state for device sleep state") from the
> pci tree.
>
> I added the following merge fix patch (and can carry it as necessary):
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 2 Jul 2012 12:07:25 +1000
> Subject: [PATCH] libata-acpi: fix up for acpi_pm_device_sleep_state API
>  change
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/ata/libata-acpi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
> index 4112eaa..a2b16c9 100644
> --- a/drivers/ata/libata-acpi.c
> +++ b/drivers/ata/libata-acpi.c
> @@ -869,7 +869,7 @@ void ata_acpi_set_state(struct ata_port *ap, pm_message_t state)
>
>                 if (state.event != PM_EVENT_ON) {
>                         acpi_state = acpi_pm_device_sleep_state(
> -                               &dev->sdev->sdev_gendev, NULL);
> +                               &dev->sdev->sdev_gendev, NULL, ACPI_STATE_D3);
>                         if (acpi_state > 0)
>                                 acpi_bus_set_power(handle, acpi_state);
>                         /* TBD: need to check if it's runtime pm request */

The fix is good for me.  Thanks!

Best Regards,
Huang Ying

^ permalink raw reply	[flat|nested] 22+ messages in thread

* linux-next: build failure after merge of the libata tree
@ 2012-07-02  2:10 Stephen Rothwell
  2012-07-02  2:19 ` huang ying
  0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2012-07-02  2:10 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: linux-next, linux-kernel, Lin Ming, Huang Ying, Bjorn Helgaas

[-- Attachment #1: Type: text/plain, Size: 1640 bytes --]

Hi Jeff,

After merging the libata tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/ata/libata-acpi.c: In function 'ata_acpi_set_state':
drivers/ata/libata-acpi.c:872:5: error: too few arguments to function 'acpi_pm_device_sleep_state'
include/acpi/acpi_bus.h:418:5: note: declared here

Caused by commit 3bd46600a7a7 ("libata-acpi: add ata port runtime D3Cold
support") from the libata tree interacting with commit ee85f543710d
("ACPI/PM: specify lowest allowed state for device sleep state") from the
pci tree.

I added the following merge fix patch (and can carry it as necessary):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 2 Jul 2012 12:07:25 +1000
Subject: [PATCH] libata-acpi: fix up for acpi_pm_device_sleep_state API
 change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/ata/libata-acpi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index 4112eaa..a2b16c9 100644
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -869,7 +869,7 @@ void ata_acpi_set_state(struct ata_port *ap, pm_message_t state)
 
 		if (state.event != PM_EVENT_ON) {
 			acpi_state = acpi_pm_device_sleep_state(
-				&dev->sdev->sdev_gendev, NULL);
+				&dev->sdev->sdev_gendev, NULL, ACPI_STATE_D3);
 			if (acpi_state > 0)
 				acpi_bus_set_power(handle, acpi_state);
 			/* TBD: need to check if it's runtime pm request */
-- 
1.7.10.280.gaa39

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply related	[flat|nested] 22+ messages in thread

* Re: linux-next: build failure after merge of the libata tree
  2010-08-18  0:46 ` Gwendal Grignou
@ 2010-08-19 20:15   ` Jeff Garzik
  0 siblings, 0 replies; 22+ messages in thread
From: Jeff Garzik @ 2010-08-19 20:15 UTC (permalink / raw)
  To: Gwendal Grignou, Stephen Rothwell
  Cc: linux-next, linux-kernel, Grant Grundler

On 08/17/2010 08:46 PM, Gwendal Grignou wrote:
> Let me fix it and send a patch to Jeff.
>
> Gwendal.
>
> On Tue, Aug 17, 2010 at 5:40 PM, Stephen Rothwell<sfr@canb.auug.org.au>  wrote:
>> Hi Jeff,
>>
>> After merging the libata tree, today's linux-next build (powerpc
>> ppc64_defconfig) failed like this:
>>
>> drivers/ata/libata-transport.c: In function 'ata_attach_transport':
>> drivers/ata/libata-transport.c:678: error: implicit declaration of function 'kzalloc'
>> drivers/ata/libata-transport.c:678: warning: assignment makes pointer from integer without a cast
>> drivers/ata/libata-transport.c: In function 'ata_release_transport':
>> drivers/ata/libata-transport.c:741: error: implicit declaration of function 'kfree'
>>
>> Caused by commit 97395d39931160a171959ac2e1fbff1caba3374b ("[libata] Add
>> ATA transport class") neglecting to include linux/slab.h.   See Rule 1 in
>> Documentation/SubmitChecklist.
>>
>> I have used the libata tree form next-20100817 for today.


Never received a patch; pushed out the obvious fix myself.

^ permalink raw reply	[flat|nested] 22+ messages in thread

* Re: linux-next: build failure after merge of the libata tree
  2010-08-18  0:40 Stephen Rothwell
@ 2010-08-18  0:46 ` Gwendal Grignou
  2010-08-19 20:15   ` Jeff Garzik
  0 siblings, 1 reply; 22+ messages in thread
From: Gwendal Grignou @ 2010-08-18  0:46 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Jeff Garzik, linux-next, linux-kernel, Grant Grundler

Let me fix it and send a patch to Jeff.

Gwendal.

On Tue, Aug 17, 2010 at 5:40 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Jeff,
>
> After merging the libata tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/ata/libata-transport.c: In function 'ata_attach_transport':
> drivers/ata/libata-transport.c:678: error: implicit declaration of function 'kzalloc'
> drivers/ata/libata-transport.c:678: warning: assignment makes pointer from integer without a cast
> drivers/ata/libata-transport.c: In function 'ata_release_transport':
> drivers/ata/libata-transport.c:741: error: implicit declaration of function 'kfree'
>
> Caused by commit 97395d39931160a171959ac2e1fbff1caba3374b ("[libata] Add
> ATA transport class") neglecting to include linux/slab.h.   See Rule 1 in
> Documentation/SubmitChecklist.
>
> I have used the libata tree form next-20100817 for today.
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>

^ permalink raw reply	[flat|nested] 22+ messages in thread

* linux-next: build failure after merge of the libata tree
@ 2010-08-18  0:40 Stephen Rothwell
  2010-08-18  0:46 ` Gwendal Grignou
  0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2010-08-18  0:40 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: linux-next, linux-kernel, Gwendal Grignou, Grant Grundler

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

Hi Jeff,

After merging the libata tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/ata/libata-transport.c: In function 'ata_attach_transport':
drivers/ata/libata-transport.c:678: error: implicit declaration of function 'kzalloc'
drivers/ata/libata-transport.c:678: warning: assignment makes pointer from integer without a cast
drivers/ata/libata-transport.c: In function 'ata_release_transport':
drivers/ata/libata-transport.c:741: error: implicit declaration of function 'kfree'

Caused by commit 97395d39931160a171959ac2e1fbff1caba3374b ("[libata] Add
ATA transport class") neglecting to include linux/slab.h.   See Rule 1 in
Documentation/SubmitChecklist.

I have used the libata tree form next-20100817 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2022-01-07  1:28 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-24  1:17 linux-next: build failure after merge of the libata tree Stephen Rothwell
2014-04-24 12:25 ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2022-01-06 14:08 Stephen Rothwell
2022-01-06 23:58 ` Damien Le Moal
2022-01-07  0:17   ` Stephen Rothwell
2022-01-07  1:28     ` Damien Le Moal
2016-05-09  0:14 Stephen Rothwell
2015-09-17  4:03 Stephen Rothwell
2015-09-17 11:14 ` Luis de Bethencourt
2014-02-26  2:55 Stephen Rothwell
2014-02-26 13:49 ` Tejun Heo
2013-08-27  2:50 Stephen Rothwell
2013-08-27  5:52 ` Aaron Lu
2013-08-27 18:09   ` Tejun Heo
2013-08-19  1:54 Stephen Rothwell
2013-08-19  3:18 ` Terry Suereth
2013-08-19 13:40   ` Tejun Heo
2012-07-02  2:10 Stephen Rothwell
2012-07-02  2:19 ` huang ying
2010-08-18  0:40 Stephen Rothwell
2010-08-18  0:46 ` Gwendal Grignou
2010-08-19 20:15   ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).