From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Zickus Subject: Re: linux-next: build failure after merge of the akpm-current tree Date: Tue, 29 Apr 2014 09:09:23 -0400 Message-ID: <20140429130923.GA32375@redhat.com> References: <20140429171321.69409c76a15ad2a97761585c@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([209.132.183.28]:15240 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbaD2NJ2 (ORCPT ); Tue, 29 Apr 2014 09:09:28 -0400 Content-Disposition: inline In-Reply-To: <20140429171321.69409c76a15ad2a97761585c@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: Andrew Morton , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Aaron Tomlin On Tue, Apr 29, 2014 at 05:13:21PM +1000, Stephen Rothwell wrote: > Hi Andrew, > > After merging the akpm tree, today's linux-next build (sparc64 defconfig) > failed like this: > > arch/sparc/kernel/process_64.c: In function 'arch_trigger_all_cpu_backtrace': > arch/sparc/kernel/process_64.c:267:3: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] > cc1: all warnings being treated as errors > > Caused by commit dd0063a16aa1 ("nmi: provide the option to issue an NMI > back trace to every cpu but current"). > > I have no idea why I did not see this yesterday. > > I applied the following fix up patch: I apologize for that. The downsides of making changes without having a cross compiler. Thanks for the fixup! Cheers, Don > > From: Stephen Rothwell > Date: Tue, 29 Apr 2014 17:10:00 +1000 > Subject: [PATCH] nmi-provide-the-option-to-issue-an-nmi-back-trace-to-every-cpu-but-current-fix > > Signed-off-by: Stephen Rothwell > --- > arch/sparc/kernel/process_64.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/sparc/kernel/process_64.c b/arch/sparc/kernel/process_64.c > index 65b405c36421..9975a6dbca0a 100644 > --- a/arch/sparc/kernel/process_64.c > +++ b/arch/sparc/kernel/process_64.c > @@ -261,10 +261,12 @@ void arch_trigger_all_cpu_backtrace(bool include_self) > smp_fetch_global_regs(); > > for_each_online_cpu(cpu) { > + struct global_reg_snapshot *gp; > + > if (!include_self && cpu == this_cpu) > continue; > > - struct global_reg_snapshot *gp = &global_cpu_snapshot[cpu].reg; > + gp = &global_cpu_snapshot[cpu].reg; > > __global_reg_poll(gp); > > -- > 2.0.0.rc0 > > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au