From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Thumshirn Subject: Re: linux-next: Tree for May 14 (tty/serial/men_z135_uart.c) Date: Thu, 15 May 2014 08:15:55 +0200 Message-ID: <20140515061555.GA13254@jtlinux> References: <20140514182649.33e63e49@canb.auug.org.au> <53739A4E.2040009@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <53739A4E.2040009@infradead.org> Sender: linux-kernel-owner@vger.kernel.org To: Randy Dunlap Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Johannes Thumshirn , linux-serial@vger.kernel.org List-Id: linux-next.vger.kernel.org On Wed, May 14, 2014 at 09:31:10AM -0700, Randy Dunlap wrote: > On 05/14/2014 01:26 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20140513: > > > > on x86_64: > > CONFIG_SERIAL_CORE=m > but SERIAL_MEN_Z135=y. > > drivers/built-in.o: In function `men_z135_remove': > men_z135_uart.c:(.text+0x5bc53): undefined reference to `uart_remove_one_port' > drivers/built-in.o: In function `men_z135_set_termios': > men_z135_uart.c:(.text+0x5c3b5): undefined reference to `uart_get_baud_rate' > men_z135_uart.c:(.text+0x5c415): undefined reference to `uart_update_timeout' > drivers/built-in.o: In function `men_z135_handle_tx': > men_z135_uart.c:(.text+0x5c8f4): undefined reference to `uart_write_wakeup' > drivers/built-in.o: In function `men_z135_intr': > men_z135_uart.c:(.text+0x5ce28): undefined reference to `uart_handle_dcd_change' > men_z135_uart.c:(.text+0x5ce51): undefined reference to `uart_handle_cts_change' > drivers/built-in.o: In function `men_z135_probe': > men_z135_uart.c:(.text+0x5cf96): undefined reference to `uart_add_one_port' > drivers/built-in.o: In function `men_z135_init': > men_z135_uart.c:(.init.text+0x26e9): undefined reference to `uart_register_driver' > men_z135_uart.c:(.init.text+0x2766): undefined reference to `uart_unregister_driver' > drivers/built-in.o: In function `men_z135_exit': > men_z135_uart.c:(.exit.text+0xe4): undefined reference to `uart_unregister_driver' > make[1]: *** [vmlinux] Error 1 > Hi Randy, There is a not yet merged patch from Arnd Bergmann, which can be found here: https://lkml.org/lkml/2014/4/29/529 I've just checked and it resolves the problem at my place, can you please verify it as well. Thanks, Johannes