From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Cooper Subject: Re: linux-next: Tree for Sep 1 Date: Sun, 14 Sep 2014 01:40:55 -0400 Message-ID: <20140914054055.GI21986@titan.lakedaemon.net> References: <20140901230728.GM29327@sirena.org.uk> <1627064.QhxvejlWdk@amdc1032> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:58771 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752339AbaINFlC (ORCPT ); Sun, 14 Sep 2014 01:41:02 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Christoph Lameter Cc: Bartlomiej Zolnierkiewicz , Mark Brown , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, nicolas.pitre@linaro.org, Russell King , Tejun Heo , Kyungmin Park Christoph, On Tue, Sep 02, 2014 at 10:00:07AM -0500, Christoph Lameter wrote: > On Tue, 2 Sep 2014, Christoph Lameter wrote: > > > Oww.. This is double indirection deal there. A percpu offset pointing to > > a pointer? > > > > Generally the following is true (definition from > > include/asm-generic/percpu.h that is used for ARM for raw_cpu_read): > > > > #define raw_cpu_read_4(pcp) (*raw_cpu_ptr(&(pcp))) > > I think what the issue is that we dropped the fetch of the percpu offset > in the patch. Instead we are using the address of the variable that > contains the offset. Does this patch fix it? > > > Subject: irqchip: Properly fetch the per cpu offset > > The raw_cpu_read() conversion dropped the fetch of the offset > from base->percpu_base in gic_get_percpu_base. > > Signed-off-by: Christoph Lameter Acked-by: Jason Cooper thx, Jason.