From: Mike Turquette <mturquette@linaro.org>
To: linux-next@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Vincent Stehlé" <vincent.stehle@laposte.net>,
"Jyri Sarha" <jsarha@ti.com>
Subject: Re: [PATCH linux-next] clk-gpio-gate: include gpio/consumer to fix build
Date: Tue, 30 Sep 2014 14:27:30 -0700 [thread overview]
Message-ID: <20140930212730.19023.54223@quantum> (raw)
In-Reply-To: <1412105803-9954-1-git-send-email-vincent.stehle@laposte.net>
Quoting Vincent Stehlé (2014-09-30 12:36:43)
> This fixes the following build error:
>
> drivers/clk/clk-gpio-gate.c: In function ‘clk_gpio_gate_enable’:
> drivers/clk/clk-gpio-gate.c:36:2: error: implicit declaration of function ‘gpiod_set_value’ [-Werror=implicit-function-declaration]
> drivers/clk/clk-gpio-gate.c: In function ‘clk_gpio_gate_is_enabled’:
> drivers/clk/clk-gpio-gate.c:52:2: error: implicit declaration of function ‘gpiod_get_value’ [-Werror=implicit-function-declaration]
> drivers/clk/clk-gpio-gate.c: In function ‘clk_register_gpio_gate’:
> drivers/clk/clk-gpio-gate.c:79:2: error: implicit declaration of function ‘gpiod_is_active_low’ [-Werror=implicit-function-declaration]
> drivers/clk/clk-gpio-gate.c:85:3: error: implicit declaration of function ‘desc_to_gpio’ [-Werror=implicit-function-declaration]
> drivers/clk/clk-gpio-gate.c:125:2: error: implicit declaration of function ‘gpiod_put’ [-Werror=implicit-function-declaration]
> drivers/clk/clk-gpio-gate.c: In function ‘of_clk_gpio_gate_delayed_register_get’:
> drivers/clk/clk-gpio-gate.c:169:2: error: implicit declaration of function ‘gpio_to_desc’ [-Werror=implicit-function-declaration]
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Jyri Sarha <jsarha@ti.com>
> Cc: Mike Turquette <mturquette@linaro.org>
> ---
>
> Hi,
>
> This can be seen with e.g. linux next-20140930 and arm alldefconfig.
Fixed with:
https://git.linaro.org/people/mike.turquette/linux.git/commit/44b4aa97bea84fa8ac179155f147e3483cc7a6e0
Regards,
Mike
>
> Best regards,
>
> V.
>
> drivers/clk/clk-gpio-gate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/clk-gpio-gate.c b/drivers/clk/clk-gpio-gate.c
> index 9dde885..08e4322 100644
> --- a/drivers/clk/clk-gpio-gate.c
> +++ b/drivers/clk/clk-gpio-gate.c
> @@ -13,6 +13,7 @@
> #include <linux/module.h>
> #include <linux/slab.h>
> #include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/of_gpio.h>
> #include <linux/err.h>
> #include <linux/device.h>
> --
> 2.1.0
>
next prev parent reply other threads:[~2014-09-30 21:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 10:12 linux-next: Tree for Sep 30 Stephen Rothwell
2014-09-30 16:26 ` Guenter Roeck
2014-09-30 19:36 ` [PATCH linux-next] clk-gpio-gate: include gpio/consumer to fix build Vincent Stehlé
2014-09-30 21:27 ` Mike Turquette [this message]
2014-09-30 18:50 ` linux-next: Tree for Sep 30 (uml) Randy Dunlap
2014-09-30 18:59 ` Richard Weinberger
2014-10-01 7:22 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930212730.19023.54223@quantum \
--to=mturquette@linaro.org \
--cc=jsarha@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=vincent.stehle@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).