From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Luc Verhaegen <libv@skynet.be>,
Hans de Goede <hdegoede@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
David Herrmann <dh.herrmann@gmail.com>,
Grant Likely <grant.likely@linaro.org>
Subject: linux-next: build failure after merge of the omap_dss2 tree
Date: Mon, 17 Nov 2014 19:09:05 +1100 [thread overview]
Message-ID: <20141117190905.4e96294a@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]
Hi Tomi,
After merging the omap_dss2 tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/video/fbdev/simplefb.c: In function 'simplefb_clocks_init':
drivers/video/fbdev/simplefb.c:207:2: error: implicit declaration of function 'of_clk_get_parent_count' [-Werror=implicit-function-declaration]
par->clk_count = of_clk_get_parent_count(np);
^
Caused by commit fc219bfd5b2e ("simplefb: add clock handling code").
This build does not have CONFIG_COMMON_CLK set.
I have added the following fix for today (there is probably a better
one):
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 17 Nov 2014 19:05:42 +1100
Subject: [PATCH] simplefb: make it depend on CONFIG_COMMON_CLK
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/video/fbdev/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 025b439d4fe1..1f0298e166c3 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -2457,6 +2457,7 @@ config FB_HYPERV
config FB_SIMPLE
bool "Simple framebuffer support"
depends on (FB = y)
+ depends on COMMON_CLK
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
--
2.1.3
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next reply other threads:[~2014-11-17 8:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 8:09 Stephen Rothwell [this message]
2014-11-18 14:53 ` linux-next: build failure after merge of the omap_dss2 tree Tomi Valkeinen
2014-11-18 15:07 ` David Herrmann
2014-11-25 11:00 ` Tomi Valkeinen
2014-11-25 11:20 ` Hans de Goede
2014-11-25 12:11 ` Tomi Valkeinen
2014-11-25 22:07 ` Stephen Rothwell
2014-11-26 8:16 ` Tomi Valkeinen
-- strict thread matches above, loose matches on Subject: below --
2014-03-05 3:32 Stephen Rothwell
2014-03-05 7:01 ` Tomi Valkeinen
2014-03-04 3:35 Stephen Rothwell
2014-03-04 6:58 ` Tomi Valkeinen
2013-04-26 5:10 Stephen Rothwell
2013-04-26 5:31 ` Tomi Valkeinen
2013-04-26 5:56 ` Stephen Rothwell
2013-04-26 6:57 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117190905.4e96294a@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=dh.herrmann@gmail.com \
--cc=geert@linux-m68k.org \
--cc=grant.likely@linaro.org \
--cc=hdegoede@redhat.com \
--cc=libv@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).