linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tomas Winkler <tomas.winkler@intel.com>
Subject: Re: linux-next: build warnings after merge of the char-misc tree
Date: Mon, 13 Apr 2015 12:43:28 +0200	[thread overview]
Message-ID: <20150413104328.GB6390@kroah.com> (raw)
In-Reply-To: <20150413193720.56083fbf@canb.auug.org.au>

On Mon, Apr 13, 2015 at 07:37:20PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the char-misc tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
> 
> In file included from include/trace/define_trace.h:90:0,
>                  from drivers/misc/mei/mei-trace.h:76,
>                  from drivers/misc/mei/mei-trace.c:21:
> include/trace/ftrace.h:28:0: warning: "TRACE_SYSTEM_STRING" redefined
>  #define TRACE_SYSTEM_STRING __app(TRACE_SYSTEM_VAR,__trace_system_name)
>  ^
> In file included from include/trace/define_trace.h:83:0,
>                  from drivers/misc/mei/mei-trace.h:76,
>                  from drivers/misc/mei/mei-trace.c:21:
> drivers/misc/mei/./mei-trace.h:29:0: note: this is the location of the previous definition
>  #define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
>  ^
> In file included from include/trace/ftrace.h:134:0,
>                  from include/trace/define_trace.h:90,
>                  from drivers/misc/mei/mei-trace.h:76,
>                  from drivers/misc/mei/mei-trace.c:21:
> drivers/misc/mei/./mei-trace.h:29:0: warning: "TRACE_SYSTEM_STRING" redefined
>  #define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
>  ^
> In file included from include/trace/define_trace.h:90:0,
>                  from drivers/misc/mei/mei-trace.h:76,
>                  from drivers/misc/mei/mei-trace.c:21:
> include/trace/ftrace.h:28:0: note: this is the location of the previous definition
>  #define TRACE_SYSTEM_STRING __app(TRACE_SYSTEM_VAR,__trace_system_name)
>  ^
> In file included from include/trace/define_trace.h:90:0,
>                  from drivers/misc/mei/mei-trace.h:76,
>                  from drivers/misc/mei/mei-trace.c:21:
> include/trace/ftrace.h:28:0: warning: "TRACE_SYSTEM_STRING" redefined
>  #define TRACE_SYSTEM_STRING __app(TRACE_SYSTEM_VAR,__trace_system_name)
>  ^
> In file included from include/trace/define_trace.h:83:0,
>                  from drivers/misc/mei/mei-trace.h:76,
>                  from drivers/misc/mei/mei-trace.c:21:
> drivers/misc/mei/./mei-trace.h:29:0: note: this is the location of the previous definition
>  #define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
>  ^
> In file included from include/trace/ftrace.h:134:0,
>                  from include/trace/define_trace.h:90,
>                  from drivers/misc/mei/mei-trace.h:76,
>                  from drivers/misc/mei/mei-trace.c:21:
> drivers/misc/mei/./mei-trace.h:29:0: warning: "TRACE_SYSTEM_STRING" redefined
>  #define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
>  ^
> In file included from include/trace/define_trace.h:90:0,
>                  from drivers/misc/mei/mei-trace.h:76,
>                  from drivers/misc/mei/mei-trace.c:21:
> include/trace/ftrace.h:28:0: note: this is the location of the previous definition
>  #define TRACE_SYSTEM_STRING __app(TRACE_SYSTEM_VAR,__trace_system_name)
>  ^
> 
> Introduced by commit a0a927d06d79 ("mei: me: add io register tracing")
> interacting with commit acd388fd3af3 ("tracing: Give system name a
> pointer") from the ftrace tree.
> 
> TRACE_SYSTEM_STRING should be removed from drivers/misc/mei/mei-trace.h
> as it is not being used anywhere in the mei-trace code.

That's nice for such system-wide changes to be done at the last possible
minute in the development cycle :(

Anyway, someone from the trace subsystem wish to send me a patch for
this?

thanks,

greg k-h

  reply	other threads:[~2015-04-13 10:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13  9:37 linux-next: build warnings after merge of the char-misc tree Stephen Rothwell
2015-04-13 10:43 ` Greg KH [this message]
2015-04-13 10:44   ` Winkler, Tomas
2015-04-13 10:47   ` Stephen Rothwell
2015-04-13 14:17   ` Steven Rostedt
2015-04-13 15:01   ` Steven Rostedt
2015-04-13 16:07   ` [PATCH] mei: trace: Remove unused TRACE_SYSTEM_STRING define Steven Rostedt
2015-04-13 16:56     ` Greg KH
2015-04-13 13:34 ` linux-next: build warnings after merge of the char-misc tree Greg KH
2021-01-11  3:42 Stephen Rothwell
2022-11-14  7:17 Stephen Rothwell
2022-11-14  7:33 ` Arnd Bergmann
2022-11-14  9:02   ` Greg KH
2022-11-14  9:03   ` Liu Ying
2022-11-14  9:16     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150413104328.GB6390@kroah.com \
    --to=greg@kroah.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).