From: Michael Welling <mwelling@ieee.org>
To: Nishanth Menon <nm@ti.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-next <linux-next@vger.kernel.org>,
linux-spi@vger.kernel.org
Subject: Re: next-20150511 / omap2-mcspi: regression for sdp4430 boot
Date: Mon, 11 May 2015 12:07:42 -0500 [thread overview]
Message-ID: <20150511170742.GA6616@deathray> (raw)
In-Reply-To: <5550DDCB.8010303@ti.com>
On Mon, May 11, 2015 at 11:50:19AM -0500, Nishanth Menon wrote:
> Hi,
>
> SDP4430 uses a SPI based network chip ks8851.
>
> next-20150508:
> https://github.com/nmenon/kernel-test-logs/blob/next-20150508/omap2plus_defconfig/sdp4430.txt
>
> However, next-20150511:
> https://github.com/nmenon/kernel-test-logs/blob/next-20150511/omap2plus_defconfig/sdp4430.txt
>
I will look into this but it is going to be difficult to debug with access to the hardware.
This is what I get for changing a driver that effects so many SoCs.
> Generates infinite "ks8851 spi1.0: ks8851_irq: spi bus error" errors
> and hangs the platform.
>
> Bisected the issue down to the following two commits when reverted
> allows the board to function:
>
>
> commit b28cb9414db9f8e42ac18c9e360e4e99cda42489
> Author: Michael Welling <mwelling@ieee.org>
> Date: Thu May 7 18:36:53 2015 -0500
>
> spi: omap2-mcspi: Switch driver to use transfer_one
>
> Switches from transfer_one_message to transfer_one to prepare
> driver for
> use of GPIO chip selects.
>
> Signed-off-by: Michael Welling <mwelling@ieee.org>
> Signed-off-by: Mark Brown <broonie@kernel.org>
>
> Reverting this alone: http://paste.ubuntu.org.cn/2594735 (did not boot up)
>
> commit bc7f9bbc80bcc77745b3f54ec4e7103e3e142bb9
> Author: Michael Welling <mwelling@ieee.org>
> Date: Fri May 8 13:31:01 2015 -0500
>
> spi: omap2-mcspi: Add gpio_request and init CS
>
> If GPIO chip select is specified, request the GPIO in the setup
> function
> and release it in the cleanup function.
>
> Signed-off-by: Michael Welling <mwelling@ieee.org>
> Signed-off-by: Mark Brown <broonie@kernel.org>
>
> Reverting this as well allowed boot.
>
> --
> Regards,
> Nishanth Menon
next prev parent reply other threads:[~2015-05-11 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 16:50 next-20150511 / omap2-mcspi: regression for sdp4430 boot Nishanth Menon
2015-05-11 17:07 ` Michael Welling [this message]
2015-05-11 18:27 ` Nishanth Menon
[not found] ` <5550F47C.1030902-l0cyMroinI0@public.gmane.org>
2015-05-11 18:30 ` Michael Welling
2015-05-11 19:00 ` Nishanth Menon
2015-05-11 20:16 ` Michael Welling
2015-05-12 17:18 ` Nishanth Menon
2015-05-12 17:22 ` Michael Welling
2015-05-12 17:28 ` Nishanth Menon
2015-05-11 18:54 ` Michael Welling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511170742.GA6616@deathray \
--to=mwelling@ieee.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).