linux-next: build warnings after merge of the net-next tree

linux-next: build warnings after merge of the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (sparc64 defconfig)
produced these warnings:

In file included from arch/sparc/include/asm/cmpxchg.h:4:0,
                 from arch/sparc/include/asm/atomic_64.h:11,
                 from arch/sparc/include/asm/atomic.h:4,
                 from include/linux/atomic.h:4,
                 from include/linux/spinlock.h:416,
                 from include/linux/mmzone.h:7,
                 from include/linux/gfp.h:5,
                 from include/linux/mm.h:9,
                 from net/packet/af_packet.c:56:
net/packet/af_packet.c: In function 'packet_rcv_has_room':
arch/sparc/include/asm/cmpxchg_64.h:43:22: warning: value computed is not used [-Wunused-value]
 #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))
                      ^
net/packet/af_packet.c:1314:3: note: in expansion of macro 'xchg'
   xchg(&po->pressure, !has_room);
   ^
net/packet/af_packet.c: In function 'packet_poll':
arch/sparc/include/asm/cmpxchg_64.h:43:22: warning: value computed is not used [-Wunused-value]
 #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))
                      ^
net/packet/af_packet.c:3817:3: note: in expansion of macro 'xchg'
   xchg(&po->pressure, 0);
   ^

Introduced by commit 2ccdbaa6d55b ("packet: rollover lock contention
avoidance").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build warnings after merge of the net-next tree

[Willem de Bruijn]

On Thu, May 14, 2015 at 3:12 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (sparc64 defconfig)
> produced these warnings:
>
> In file included from arch/sparc/include/asm/cmpxchg.h:4:0,
>                  from arch/sparc/include/asm/atomic_64.h:11,
>                  from arch/sparc/include/asm/atomic.h:4,
>                  from include/linux/atomic.h:4,
>                  from include/linux/spinlock.h:416,
>                  from include/linux/mmzone.h:7,
>                  from include/linux/gfp.h:5,
>                  from include/linux/mm.h:9,
>                  from net/packet/af_packet.c:56:
> net/packet/af_packet.c: In function 'packet_rcv_has_room':
> arch/sparc/include/asm/cmpxchg_64.h:43:22: warning: value computed is not used [-Wunused-value]
>  #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))
>                       ^
> net/packet/af_packet.c:1314:3: note: in expansion of macro 'xchg'
>    xchg(&po->pressure, !has_room);
>    ^
> net/packet/af_packet.c: In function 'packet_poll':
> arch/sparc/include/asm/cmpxchg_64.h:43:22: warning: value computed is not used [-Wunused-value]
>  #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr))))
>                       ^
> net/packet/af_packet.c:3817:3: note: in expansion of macro 'xchg'
>    xchg(&po->pressure, 0);
>    ^
>
> Introduced by commit 2ccdbaa6d55b ("packet: rollover lock contention
> avoidance").

I just sent http://patchwork.ozlabs.org/patch/472362/ to resolve
these. Thanks for the report.

linux-next: build warnings after merge of the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1851 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c: In function 'bnxt_tc_parse_flow':
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:532:8: warning: array subscript [12, 17] is outside array bounds of 'u16[6]' {aka 'short unsigned int[6]'} [-Warray-bounds]
  532 |   if (p[i] != 0)
      |       ~^~~
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:293:6: note: while referencing 'eth_addr'
  293 |  u16 eth_addr[ETH_ALEN] = { 0 };
      |      ^~~~~~~~
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:532:8: warning: array subscript [12, 17] is outside array bounds of 'u16[6]' {aka 'short unsigned int[6]'} [-Warray-bounds]
  532 |   if (p[i] != 0)
      |       ~^~~
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:288:6: note: while referencing 'eth_addr_mask'
  288 |  u16 eth_addr_mask[ETH_ALEN] = { 0 };
      |      ^~~~~~~~~~~~~
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:532:8: warning: array subscript [12, 17] is outside array bounds of 'u16[6]' {aka 'short unsigned int[6]'} [-Warray-bounds]
  532 |   if (p[i] != 0)
      |       ~^~~
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:288:6: note: while referencing 'eth_addr_mask'
  288 |  u16 eth_addr_mask[ETH_ALEN] = { 0 };
      |      ^~~~~~~~~~~~~
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:544:8: warning: array subscript [12, 17] is outside array bounds of 'u16[6]' {aka 'short unsigned int[6]'} [-Warray-bounds]
  544 |   if (p[i] != 0xff)
      |       ~^~~
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:288:6: note: while referencing 'eth_addr_mask'
  288 |  u16 eth_addr_mask[ETH_ALEN] = { 0 };
      |      ^~~~~~~~~~~~~

Introduced (I think) by commit

  90f906243bf6 ("bnxt_en: Add support for L2 rewrite")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warnings after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) produced thie warnings:

In file included from include/linux/byteorder/big_endian.h:4:0,
                 from arch/powerpc/include/uapi/asm/byteorder.h:13,
                 from include/linux/qed/common_hsi.h:36,
                 from drivers/scsi/qedf/drv_scsi_fw_funcs.h:10,
                 from drivers/scsi/qedf/drv_fcoe_fw_funcs.h:10,
                 from drivers/scsi/qedf/drv_fcoe_fw_funcs.c:8:
drivers/scsi/qedf/drv_fcoe_fw_funcs.c: In function 'init_initiator_rw_fcoe_task':
include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
                          ^
include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__cpu_to_le32'
 #define cpu_to_le32 __cpu_to_le32
                     ^
drivers/scsi/qedf/drv_fcoe_fw_funcs.c:62:31: note: in expansion of macro 'cpu_to_le32'
  t_st_ctx->read_write.rx_id = cpu_to_le32(FCOE_RX_ID);
                               ^
drivers/scsi/qedf/drv_fcoe_fw_funcs.c: In function 'init_initiator_midpath_unsolicited_fcoe_task':
include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define __cpu_to_le32(x) ((__force __le32)__swab32((x)))
                          ^
include/linux/byteorder/generic.h:87:21: note: in expansion of macro '__cpu_to_le32'
 #define cpu_to_le32 __cpu_to_le32
                     ^
drivers/scsi/qedf/drv_fcoe_fw_funcs.c:154:31: note: in expansion of macro 'cpu_to_le32'
  t_st_ctx->read_write.rx_id = cpu_to_le32(FCOE_RX_ID);
                               ^

Introduced by commit

  be086e7c53f1 ("qed*: Utilize Firmware 8.15.3.0")

-- 
Cheers,
Stephen Rothwell

linux-next: build warnings after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) produced these warnings:

drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function 'init_one':
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:4646:9: warning: unused variable 'port_vec' [-Wunused-variable]
  u32 v, port_vec;
         ^
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:4646:6: warning: unused variable 'v' [-Wunused-variable]
  u32 v, port_vec;
      ^
Introduced by commit

  96fe11f27b70 ("cxgb4: Implement ndo_get_phys_port_id for mgmt dev")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the net-next tree

[Thomas Petazzoni]

Hello,

On Mon, 21 Nov 2016 17:28:39 -0800, Florian Fainelli wrote:
> +Thomas, Gregory,
> 
> On 11/21/2016 05:22 PM, Stephen Rothwell wrote:
> [snip]
> > 
> > Introduced by commit
> > 
> >   a0627f776a45 ("net: marvell: Allow drivers to be built with COMPILE_TEST")
> > 
> > "a few warnings" is a matter of perception.  :-(  
> 
> Thomas, based on our IRC conversation, do you already have patches for
> mvneta and mvpp2 to build without warning on 64-bit or should I prepare
> patches for these?

Yes, we already have patches for making mvneta and mvpp2 build without
warning for 64-bit (Grégory for mvneta, and myself for mvpp2). I
intended to send the mvpp2 ones together with patches adding support
for a new variant of the IP, but I guess I can send just the few ones
that make it 64-bit "buildable".

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: linux-next: build warnings after merge of the net-next tree

[Florian Fainelli]

+Thomas, Gregory,

On 11/21/2016 05:22 PM, Stephen Rothwell wrote:
[snip]
> 
> Introduced by commit
> 
>   a0627f776a45 ("net: marvell: Allow drivers to be built with COMPILE_TEST")
> 
> "a few warnings" is a matter of perception.  :-(

Thomas, based on our IRC conversation, do you already have patches for
mvneta and mvpp2 to build without warning on 64-bit or should I prepare
patches for these?
-- 
Florian

linux-next: build warnings after merge of the net-next tree

[Stephen Rothwell]

Hi all,

After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

drivers/net/ethernet/marvell/mvneta_bm.c: In function 'mvneta_bm_construct':
drivers/net/ethernet/marvell/mvneta_bm.c:103:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  *(u32 *)buf = (u32)buf;
                ^
In file included from include/linux/clk.h:16:0,
                 from drivers/net/ethernet/marvell/mvneta_bm.c:13:
drivers/net/ethernet/marvell/mvneta_bm.c: In function 'mvneta_bm_pool_create':
drivers/net/ethernet/marvell/mvneta_bm.c:128:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  if (!IS_ALIGNED((u32)bm_pool->virt_addr, MVNETA_BM_POOL_PTR_ALIGN)) {
                  ^
include/linux/kernel.h:51:30: note: in definition of macro 'IS_ALIGNED'
 #define IS_ALIGNED(x, a)  (((x) & ((typeof(x))(a) - 1)) == 0)
                              ^
drivers/net/ethernet/marvell/mvneta_bm.c:128:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  if (!IS_ALIGNED((u32)bm_pool->virt_addr, MVNETA_BM_POOL_PTR_ALIGN)) {
                  ^
include/linux/kernel.h:51:44: note: in definition of macro 'IS_ALIGNED'
 #define IS_ALIGNED(x, a)  (((x) & ((typeof(x))(a) - 1)) == 0)
                                            ^
drivers/net/ethernet/marvell/mvneta.c: In function 'mvneta_rx_refill':
drivers/net/ethernet/marvell/mvneta.c:1802:42: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  mvneta_rx_desc_fill(rx_desc, phys_addr, (u32)data);
                                          ^
drivers/net/ethernet/marvell/mvneta.c: In function 'mvneta_rxq_drop_pkts':
drivers/net/ethernet/marvell/mvneta.c:1864:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
   void *data = (void *)rx_desc->buf_cookie;
                ^
drivers/net/ethernet/marvell/mvneta.c: In function 'mvneta_rx_swbm':
drivers/net/ethernet/marvell/mvneta.c:1902:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
   data = (unsigned char *)rx_desc->buf_cookie;
          ^
drivers/net/ethernet/marvell/mvneta.c: In function 'mvneta_rx_hwbm':
drivers/net/ethernet/marvell/mvneta.c:2023:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
   data = (unsigned char *)rx_desc->buf_cookie;
          ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_prs_mac_promisc_set':
drivers/net/ethernet/marvell/mvpp2.c:524:33: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define MVPP2_PRS_RI_L2_UCAST   ~(BIT(9) | BIT(10))
                                 ^
drivers/net/ethernet/marvell/mvpp2.c:1459:33: note: in expansion of macro 'MVPP2_PRS_RI_L2_UCAST'
   mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_L2_UCAST,
                                 ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_prs_dsa_tag_set':
drivers/net/ethernet/marvell/mvpp2.c:517:34: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define MVPP2_PRS_RI_VLAN_NONE   ~(BIT(2) | BIT(3))
                                  ^
drivers/net/ethernet/marvell/mvpp2.c:1572:34: note: in expansion of macro 'MVPP2_PRS_RI_VLAN_NONE'
    mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_VLAN_NONE,
                                  ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_prs_dsa_tag_ethertype_set':
drivers/net/ethernet/marvell/mvpp2.c:517:34: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define MVPP2_PRS_RI_VLAN_NONE   ~(BIT(2) | BIT(3))
                                  ^
drivers/net/ethernet/marvell/mvpp2.c:1642:34: note: in expansion of macro 'MVPP2_PRS_RI_VLAN_NONE'
    mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_VLAN_NONE,
                                  ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_prs_etype_init':
drivers/net/ethernet/marvell/mvpp2.c:529:30: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define MVPP2_PRS_RI_L3_UN   ~(BIT(12) | BIT(13) | BIT(14))
                              ^
drivers/net/ethernet/marvell/mvpp2.c:2477:32: note: in expansion of macro 'MVPP2_PRS_RI_L3_UN'
  mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_L3_UN,
                                ^
drivers/net/ethernet/marvell/mvpp2.c:529:30: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define MVPP2_PRS_RI_L3_UN   ~(BIT(12) | BIT(13) | BIT(14))
                              ^
drivers/net/ethernet/marvell/mvpp2.c:2488:42: note: in expansion of macro 'MVPP2_PRS_RI_L3_UN'
  mvpp2_prs_shadow_ri_set(priv, pe.index, MVPP2_PRS_RI_L3_UN,
                                          ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_prs_vlan_init':
drivers/net/ethernet/marvell/mvpp2.c:517:34: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define MVPP2_PRS_RI_VLAN_NONE   ~(BIT(2) | BIT(3))
                                  ^
drivers/net/ethernet/marvell/mvpp2.c:2563:32: note: in expansion of macro 'MVPP2_PRS_RI_VLAN_NONE'
  mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_VLAN_NONE,
                                ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_prs_pppoe_init':
drivers/net/ethernet/marvell/mvpp2.c:529:30: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define MVPP2_PRS_RI_L3_UN   ~(BIT(12) | BIT(13) | BIT(14))
                              ^
drivers/net/ethernet/marvell/mvpp2.c:2669:32: note: in expansion of macro 'MVPP2_PRS_RI_L3_UN'
  mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_L3_UN,
                                ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_prs_ip4_init':
drivers/net/ethernet/marvell/mvpp2.c:537:33: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define MVPP2_PRS_RI_L3_UCAST   ~(BIT(15) | BIT(16))
                                 ^
drivers/net/ethernet/marvell/mvpp2.c:2755:32: note: in expansion of macro 'MVPP2_PRS_RI_L3_UCAST'
  mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_L3_UCAST,
                                ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_prs_ip6_init':
drivers/net/ethernet/marvell/mvpp2.c:529:30: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define MVPP2_PRS_RI_L3_UN   ~(BIT(12) | BIT(13) | BIT(14))
                              ^
drivers/net/ethernet/marvell/mvpp2.c:2823:32: note: in expansion of macro 'MVPP2_PRS_RI_L3_UN'
  mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_L3_UN |
                                ^
drivers/net/ethernet/marvell/mvpp2.c:537:33: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define MVPP2_PRS_RI_L3_UCAST   ~(BIT(15) | BIT(16))
                                 ^
drivers/net/ethernet/marvell/mvpp2.c:2887:32: note: in expansion of macro 'MVPP2_PRS_RI_L3_UCAST'
  mvpp2_prs_sram_ri_update(&pe, MVPP2_PRS_RI_L3_UCAST,
                                ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_prs_mac_da_accept':
drivers/net/ethernet/marvell/mvpp2.c:524:33: warning: large integer implicitly truncated to unsigned type [-Woverflow]
 #define MVPP2_PRS_RI_L2_UCAST   ~(BIT(9) | BIT(10))
                                 ^
drivers/net/ethernet/marvell/mvpp2.c:3100:8: note: in expansion of macro 'MVPP2_PRS_RI_L2_UCAST'
   ri = MVPP2_PRS_RI_L2_UCAST | MVPP2_PRS_RI_MAC_ME_MASK;
        ^
In file included from drivers/net/ethernet/marvell/mvpp2.c:13:0:
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_bm_pool_create':
drivers/net/ethernet/marvell/mvpp2.c:3375:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  if (!IS_ALIGNED((u32)bm_pool->virt_addr, MVPP2_BM_POOL_PTR_ALIGN)) {
                  ^
include/linux/kernel.h:51:30: note: in definition of macro 'IS_ALIGNED'
 #define IS_ALIGNED(x, a)  (((x) & ((typeof(x))(a) - 1)) == 0)
                              ^
drivers/net/ethernet/marvell/mvpp2.c:3375:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  if (!IS_ALIGNED((u32)bm_pool->virt_addr, MVPP2_BM_POOL_PTR_ALIGN)) {
                  ^
include/linux/kernel.h:51:44: note: in definition of macro 'IS_ALIGNED'
 #define IS_ALIGNED(x, a)  (((x) & ((typeof(x))(a) - 1)) == 0)
                                            ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_bm_bufs_free':
drivers/net/ethernet/marvell/mvpp2.c:3433:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
   dev_kfree_skb_any((struct sk_buff *)vaddr);
                     ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_bm_bufs_add':
drivers/net/ethernet/marvell/mvpp2.c:3647:47: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   mvpp2_pool_refill(port, bm, (u32)phys_addr, (u32)skb);
                                               ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_rx_refill':
drivers/net/ethernet/marvell/mvpp2.c:5011:46: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  mvpp2_pool_refill(port, bm, (u32)phys_addr, (u32)skb);
                                              ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_buff_hdr_rx':
drivers/net/ethernet/marvell/mvpp2.c:5066:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
   skb = (struct sk_buff *)buff_virt_addr;
         ^
drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_rx':
drivers/net/ethernet/marvell/mvpp2.c:5136:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
   skb = (struct sk_buff *)rx_desc->buf_cookie;
         ^

Introduced by commit

  a0627f776a45 ("net: marvell: Allow drivers to be built with COMPILE_TEST")

"a few warnings" is a matter of perception.  :-(

Please fix these up.
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the net-next tree

[Pablo Neira Ayuso]

On Sat, Jun 20, 2015 at 07:40:03PM +0200, Florian Westphal wrote:
[...]
> > Introduced by commit:
> > 
> >   71ae0dff02d7 ("netfilter: xtables: use percpu rule counters")
> 
> Yes, sorry about this, should be fixed by dcb8f5c8139ef945cdfd
> ("netfilter: xtables: fix warnings on 32bit platforms").

There's a pending pull to address this fallout:

http://patchwork.ozlabs.org/patch/486819/

Thanks.

Re: linux-next: build warnings after merge of the net-next tree

[Florian Westphal]

Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> After merging the net-next tree, today's linux-next build (i386 defconfig)
> produced these warnings:
> 
> In file included from include/net/netfilter/nf_conntrack_tuple.h:13:0,
>                  from include/linux/netfilter/nf_conntrack_dccp.h:28,
>                  from include/net/netfilter/nf_conntrack.h:22,
>                  from net/netfilter/nf_conntrack_core.c:37:
> include/linux/netfilter/x_tables.h: In function 'xt_percpu_counter_alloc':
> include/linux/netfilter/x_tables.h:373:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>    return (__force u64) res;
>           ^
> include/linux/netfilter/x_tables.h: In function 'xt_percpu_counter_free':
> include/linux/netfilter/x_tables.h:381:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    free_percpu((void __percpu *) pcnt);
>                ^
> In file included from include/asm-generic/percpu.h:6:0,
>                  from arch/x86/include/asm/percpu.h:551,
>                  from arch/x86/include/asm/preempt.h:5,
>                  from include/linux/preempt.h:64,
>                  from include/linux/spinlock.h:50,
>                  from include/linux/mm_types.h:8,
>                  from include/linux/kmemcheck.h:4,
>                  from include/linux/skbuff.h:18,
>                  from include/linux/netfilter.h:5,
>                  from net/netfilter/nf_conntrack_core.c:16:
> include/linux/netfilter/x_tables.h: In function 'xt_get_this_cpu_counter':
> include/linux/netfilter/x_tables.h:388:23: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    return this_cpu_ptr((void __percpu *) cnt->pcnt);
>                        ^
> include/linux/percpu-defs.h:206:47: note: in definition of macro '__verify_pcpu_ptr'
>   const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
>                                                ^
> include/linux/percpu-defs.h:239:27: note: in expansion of macro 'raw_cpu_ptr'
>  #define this_cpu_ptr(ptr) raw_cpu_ptr(ptr)
>                            ^
> include/linux/netfilter/x_tables.h:388:10: note: in expansion of macro 'this_cpu_ptr'
>    return this_cpu_ptr((void __percpu *) cnt->pcnt);
>           ^
> 
> and many more.
> 
> Introduced by commit:
> 
>   71ae0dff02d7 ("netfilter: xtables: use percpu rule counters")

Yes, sorry about this, should be fixed by dcb8f5c8139ef945cdfd
("netfilter: xtables: fix warnings on 32bit platforms").

Thanks,
Florian

linux-next: build warnings after merge of the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2399 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (i386 defconfig)
produced these warnings:

In file included from include/net/netfilter/nf_conntrack_tuple.h:13:0,
                 from include/linux/netfilter/nf_conntrack_dccp.h:28,
                 from include/net/netfilter/nf_conntrack.h:22,
                 from net/netfilter/nf_conntrack_core.c:37:
include/linux/netfilter/x_tables.h: In function 'xt_percpu_counter_alloc':
include/linux/netfilter/x_tables.h:373:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   return (__force u64) res;
          ^
include/linux/netfilter/x_tables.h: In function 'xt_percpu_counter_free':
include/linux/netfilter/x_tables.h:381:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
   free_percpu((void __percpu *) pcnt);
               ^
In file included from include/asm-generic/percpu.h:6:0,
                 from arch/x86/include/asm/percpu.h:551,
                 from arch/x86/include/asm/preempt.h:5,
                 from include/linux/preempt.h:64,
                 from include/linux/spinlock.h:50,
                 from include/linux/mm_types.h:8,
                 from include/linux/kmemcheck.h:4,
                 from include/linux/skbuff.h:18,
                 from include/linux/netfilter.h:5,
                 from net/netfilter/nf_conntrack_core.c:16:
include/linux/netfilter/x_tables.h: In function 'xt_get_this_cpu_counter':
include/linux/netfilter/x_tables.h:388:23: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
   return this_cpu_ptr((void __percpu *) cnt->pcnt);
                       ^
include/linux/percpu-defs.h:206:47: note: in definition of macro '__verify_pcpu_ptr'
  const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
                                               ^
include/linux/percpu-defs.h:239:27: note: in expansion of macro 'raw_cpu_ptr'
 #define this_cpu_ptr(ptr) raw_cpu_ptr(ptr)
                           ^
include/linux/netfilter/x_tables.h:388:10: note: in expansion of macro 'this_cpu_ptr'
   return this_cpu_ptr((void __percpu *) cnt->pcnt);
          ^

and many more.

Introduced by commit:

  71ae0dff02d7 ("netfilter: xtables: use percpu rule counters")

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]