From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jim Davis <jim.epost@gmail.com>,
Chen Gong <gong.chen@linux.intel.com>
Subject: [PATCH v2 1/2] ras: hwpoison: fix build failure around trace_memory_failure_event
Date: Wed, 20 May 2015 06:01:20 +0000 [thread overview]
Message-ID: <20150520060119.GB27005@hori1.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <20150520053614.GA6236@hori1.linux.bs1.fc.nec.co.jp>
Here's an updated patch.
# Randy, I dropped your Ack because there's a major change on this version.
# Would you mind looking at it, please?
---
next-20150515 fails to build on i386 with the following error:
mm/built-in.o: In function `action_result':
memory-failure.c:(.text+0x344a5): undefined reference to `__tracepoint_memory_failure_event'
memory-failure.c:(.text+0x344d5): undefined reference to `__tracepoint_memory_failure_event'
memory-failure.c:(.text+0x3450c): undefined reference to `__tracepoint_memory_failure_event'
The root cause of this error is the lack of dependency between CONFIG_RAS and
CONFIG_MEMORY_FAILURE.
"CONFIG_RAS=n and CONFIG_MEMORY_FAILURE=y" can happen on 32-bit systems with
CONFIG_SPARSEMEM=n (and all other dependencies of CONFIG_RAS from ACPI_EXTLOG/
PCIEAER/EDAC are false), but that's not supposed to happen.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
---
mm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/Kconfig b/mm/Kconfig
index 52ffb863383c..e79de2bd12cd 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -368,6 +368,7 @@ config MEMORY_FAILURE
depends on ARCH_SUPPORTS_MEMORY_FAILURE
bool "Enable recovery from hardware memory errors"
select MEMORY_ISOLATION
+ select RAS
help
Enables code to recover from some memory failures on systems
with MCA recovery. This allows a system to continue running
--
2.1.0
next prev parent reply other threads:[~2015-05-20 6:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 8:52 linux-next: Tree for May 18 Stephen Rothwell
2015-05-18 15:20 ` linux-next: Tree for May 18 (mm/memory-failure.c) Randy Dunlap
2015-05-19 2:49 ` Naoya Horiguchi
2015-05-19 4:40 ` Randy Dunlap
2015-05-19 13:46 ` Steven Rostedt
2015-05-20 5:36 ` Naoya Horiguchi
2015-05-20 6:01 ` Naoya Horiguchi [this message]
2015-05-20 6:03 ` [PATCH 2/2] trace, ras: move ras_event.h under include/trace/events Naoya Horiguchi
2015-05-20 7:16 ` Naoya Horiguchi
2015-05-20 8:15 ` [PATCH v2] " Naoya Horiguchi
2015-05-20 5:41 ` linux-next: Tree for May 18 (mm/memory-failure.c) Xie XiuQi
2015-05-20 6:09 ` Naoya Horiguchi
2015-05-20 6:19 ` Xie XiuQi
2015-05-20 20:03 ` Andrew Morton
2015-05-21 0:17 ` Stephen Rothwell
2015-05-21 8:23 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520060119.GB27005@hori1.linux.bs1.fc.nec.co.jp \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=gong.chen@linux.intel.com \
--cc=jim.epost@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).