linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the gpio tree
@ 2015-08-12  6:59 Stephen Rothwell
  2015-08-12  7:20 ` [PATCH] Bluetooth: hci_bcm: improve use of gpios API Uwe Kleine-König
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2015-08-12  6:59 UTC (permalink / raw)
  To: Linus Walleij, Gustavo Padovan
  Cc: linux-next, linux-kernel, Uwe Kleine-König, Frederic Danis,
	Marcel Holtmann

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/bluetooth/hci_bcm.c: In function 'bcm_acpi_probe':
drivers/bluetooth/hci_bcm.c:429:9: error: too few arguments to function 'devm_gpiod_get'
  gpio = devm_gpiod_get(&pdev->dev, "device-wakeup");
         ^
In file included from drivers/bluetooth/hci_bcm.c:32:0:
include/linux/gpio/consumer.h:73:32: note: declared here
 struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
                                ^
drivers/bluetooth/hci_bcm.c:437:9: error: too few arguments to function 'devm_gpiod_get'
  gpio = devm_gpiod_get(&pdev->dev, "shutdown");
         ^
In file included from drivers/bluetooth/hci_bcm.c:32:0:
include/linux/gpio/consumer.h:73:32: note: declared here
 struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
                                ^

Caused by commit

  b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")

Interacting with commit

  0395ffc1ee05 ("Bluetooth: hci_bcm: Add PM for BCM devices")

from the bluetooth tree.

I added the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 12 Aug 2015 16:55:58 +1000
Subject: [PATCH] Bluetooth: hci_bcm: fix for devm_gpiod_get API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/bluetooth/hci_bcm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index cb7fe837f7d9..c3291a4ab2e8 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -426,7 +426,7 @@ static int bcm_acpi_probe(struct bcm_device *dev)
 
 	dev->clk = devm_clk_get(&pdev->dev, NULL);
 
-	gpio = devm_gpiod_get(&pdev->dev, "device-wakeup");
+	gpio = devm_gpiod_get(&pdev->dev, "device-wakeup", GPIOD_ASIS);
 	if (!IS_ERR(gpio)) {
 		ret = gpiod_direction_output(gpio, 0);
 		if (ret)
@@ -434,7 +434,7 @@ static int bcm_acpi_probe(struct bcm_device *dev)
 		dev->device_wakeup = gpio;
 	}
 
-	gpio = devm_gpiod_get(&pdev->dev, "shutdown");
+	gpio = devm_gpiod_get(&pdev->dev, "shutdown", GPIOD_ASIS);
 	if (!IS_ERR(gpio)) {
 		ret = gpiod_direction_output(gpio, 0);
 		if (ret)
-- 
2.5.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply related	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2020-11-18  3:30 Stephen Rothwell
  2020-11-18  7:50 ` Linus Walleij
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2020-11-18  3:30 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Srinivas Neeli, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

Hi all,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpio/gpio-xilinx.c: In function 'xgpio_remove':
drivers/gpio/gpio-xilinx.c:275:2: error: implicit declaration of function 'pm_runtime_disable' [-Werror=implicit-function-declaration]
  275 |  pm_runtime_disable(&pdev->dev);
      |  ^~~~~~~~~~~~~~~~~~

Caused by commit

  fbbeb6c0a1d0 ("gpio: gpio-xilinx: Add remove function")

I have used the gpio tree from next-20201117 for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2020-04-01  4:19 Stephen Rothwell
  2020-04-01  7:49 ` Geert Uytterhoeven
  2020-04-01  8:19 ` Linus Walleij
  0 siblings, 2 replies; 106+ messages in thread
From: Stephen Rothwell @ 2020-04-01  4:19 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Thierry Reding

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

Hi all,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: "of_pinctrl_get" [drivers/gpio/gpio-tegra186.ko] undefined!

Caused by commit

  b64d6c9a6a05 ("gpio: tegra186: Add support for pin ranges")

and not fixed by commit

  e45ee71ae101 ("pinctrl: Define of_pinctrl_get() dummy for !PINCTRL")

CONFIG_OF=y
CONFIG_PINCTRL=y
CONFIG_GPIO_TEGRA186=m

I applied this patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 1 Apr 2020 15:14:32 +1100
Subject: [PATCH] gpio: export of_pinctrl_get to modules

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/pinctrl/devicetree.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/devicetree.c b/drivers/pinctrl/devicetree.c
index 1ed20ac2243f..c6fe7d64c913 100644
--- a/drivers/pinctrl/devicetree.c
+++ b/drivers/pinctrl/devicetree.c
@@ -103,6 +103,7 @@ struct pinctrl_dev *of_pinctrl_get(struct device_node *np)
 {
 	return get_pinctrl_dev_from_of_node(np);
 }
+EXPORT_SYMBOL_GPL(of_pinctrl_get);
 
 static int dt_to_map_one_config(struct pinctrl *p,
 				struct pinctrl_dev *hog_pctldev,
-- 
2.25.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2020-03-30  7:58 Stephen Rothwell
  0 siblings, 0 replies; 106+ messages in thread
From: Stephen Rothwell @ 2020-03-30  7:58 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Thierry Reding, Vidya Sagar

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

Hi all,

After merging the gpio tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

drivers/gpio/gpiolib.c: In function 'gpiochip_generic_request':
drivers/gpio/gpiolib.c:2756:32: error: 'struct gpio_device' has no member named 'pin_ranges'
 2756 |  if (!list_empty(&chip->gpiodev->pin_ranges))
      |                                ^~

Caused by commit

  2ab73c6d8323 ("gpio: Support GPIO controllers without pin-ranges")

# CONFIG_PINCTRL is not set

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2020-03-30  6:11 Stephen Rothwell
  0 siblings, 0 replies; 106+ messages in thread
From: Stephen Rothwell @ 2020-03-30  6:11 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Thierry Reding, Vidya Sagar

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

Hi all,

After merging the gpio tree, today's linux-next build (x86_64 allmodconfig
build) failed like this:

ERROR: modpost: "of_pinctrl_get" [drivers/gpio/gpio-tegra186.ko] undefined!

Caused by commit

  b64d6c9a6a05 ("gpio: tegra186: Add support for pin ranges")

I have reverted that commit for today (along with the following commit).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2019-08-16 11:38 Stephen Rothwell
  2019-08-16 22:25 ` Linus Walleij
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2019-08-16 11:38 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Thierry Reding, Brian Masney

[-- Attachment #1: Type: text/plain, Size: 2314 bytes --]

Hi all,

After merging the gpio tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

In file included from include/asm-generic/gpio.h:13,
                 from include/linux/gpio.h:62,
                 from include/linux/of_gpio.h:16,
                 from arch/powerpc/platforms/44x/warp.c:14:
include/linux/gpio/driver.h:546:13: error: 'gpiochip_populate_parent_fwspec_fourcell' defined but not used [-Werror=unused-function]
 static void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/gpio/driver.h:539:13: error: 'gpiochip_populate_parent_fwspec_twocell' defined but not used [-Werror=unused-function]
 static void gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *chip,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

and several more similar ...

Caused by commit

  fdd61a013a24 ("gpio: Add support for hierarchical IRQ domains")

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 16 Aug 2019 21:29:30 +1000
Subject: [PATCH] gpio: stubs in headers should be inline

Fixes: fdd61a013a24 ("gpio: Add support for hierarchical IRQ domains")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/gpio/driver.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index f285fee898f6..13c7d7ff497d 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -536,14 +536,14 @@ void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
 
 #else
 
-static void gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *chip,
+static inline void gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *chip,
 						    struct irq_fwspec *fwspec,
 						    unsigned int parent_hwirq,
 						    unsigned int parent_type)
 {
 }
 
-static void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
+static inline void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
 						     struct irq_fwspec *fwspec,
 						     unsigned int parent_hwirq,
 						     unsigned int parent_type)
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2018-12-17  8:24 Stephen Rothwell
  0 siblings, 0 replies; 106+ messages in thread
From: Stephen Rothwell @ 2018-12-17  8:24 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

Hi all,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/memory/omap-gpmc.c: In function 'gpmc_probe_generic_child':
drivers/memory/omap-gpmc.c:2174:9: error: type of formal parameter 4 is incomplete
         0);
         ^

Caused by commit

  21abf103818a ("gpio: Pass a flag to gpiochip_request_own_desc()")

I have used the gpio tree from next-20181214 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2018-12-10  7:00 Stephen Rothwell
  0 siblings, 0 replies; 106+ messages in thread
From: Stephen Rothwell @ 2018-12-10  7:00 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Vladimir Zapolskiy

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "irq_chip_retrigger_hierarchy" [drivers/gpio/gpio-lpc18xx.ko] undefined!

Caused by commit

  5ddabfe8d3de ("gpio: lpc18xx: add GPIO pin interrupt controller support")

I have used the gpio tree from next-20181207 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2017-11-02  5:20 Stephen Rothwell
  2017-11-02  5:33 ` Masahiro Yamada
                   ` (2 more replies)
  0 siblings, 3 replies; 106+ messages in thread
From: Stephen Rothwell @ 2017-11-02  5:20 UTC (permalink / raw)
  To: Linus Walleij, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
	Peter Zijlstra
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Masahiro Yamada

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpio/gpio-uniphier.c:324:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
  .activate = uniphier_gpio_irq_domain_activate,
              ^

Caused by commit

  dbe776c2ca54 ("gpio: uniphier: add UniPhier GPIO controller driver")

interacting with commit

  72491643469a ("genirq/irqdomain: Update irq_domain_ops.activate() signature")

from the tip tree

I added the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 2 Nov 2017 16:10:46 +1100
Subject: [PATCH] gpio: uniphier: merge fix for "Update
 irq_domain_ops.activate() signature"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpio/gpio-uniphier.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-uniphier.c b/drivers/gpio/gpio-uniphier.c
index d62cea4ed6b7..d0069202ade3 100644
--- a/drivers/gpio/gpio-uniphier.c
+++ b/drivers/gpio/gpio-uniphier.c
@@ -300,13 +300,15 @@ static int uniphier_gpio_irq_domain_alloc(struct irq_domain *domain,
 	return irq_domain_alloc_irqs_parent(domain, virq, 1, &parent_fwspec);
 }
 
-static void uniphier_gpio_irq_domain_activate(struct irq_domain *domain,
-					      struct irq_data *data)
+static int uniphier_gpio_irq_domain_activate(struct irq_domain *domain,
+					      struct irq_data *data,
+					      bool early)
 {
 	struct uniphier_gpio_priv *priv = domain->host_data;
 	struct gpio_chip *chip = &priv->chip;
 
 	gpiochip_lock_as_irq(chip, data->hwirq + UNIPHIER_GPIO_IRQ_OFFSET);
+	return 0;
 }
 
 static void uniphier_gpio_irq_domain_deactivate(struct irq_domain *domain,
-- 
2.14.1

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2017-06-21  6:09 Stephen Rothwell
  2017-06-21  6:12 ` Jisheng Zhang
  2017-06-21  7:41 ` Linus Walleij
  0 siblings, 2 replies; 106+ messages in thread
From: Stephen Rothwell @ 2017-06-21  6:09 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Xiaoguang Chen, Jisheng Zhang

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpio/gpio-dwapb.c: In function 'dwapb_irq_set_type':
drivers/gpio/gpio-dwapb.c:291:2: error: stray '\357' in program
  if (type != IRQ_TYPE_EDGE_BOTH)
  ^
drivers/gpio/gpio-dwapb.c:291:2: error: stray '\274' in program
drivers/gpio/gpio-dwapb.c:291:2: error: stray '\210' in program
drivers/gpio/gpio-dwapb.c:291:8: error: expected '(' before 'type'
  if (type != IRQ_TYPE_EDGE_BOTH)
        ^
drivers/gpio/gpio-dwapb.c:291:8: warning: statement with no effect [-Wunused-value]
drivers/gpio/gpio-dwapb.c:291:8: error: stray '\357' in program
drivers/gpio/gpio-dwapb.c:291:8: error: stray '\274' in program
drivers/gpio/gpio-dwapb.c:291:8: error: stray '\211' in program

Caused by commit

  a9d21d8da766 ("gpio: dwapb: fix missing first irq for edgeboth irq type")

It looks like those '(' ')' chars are not what they seem ...

I have used the gpio tree from next-20170620 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2017-05-29  5:39 Stephen Rothwell
  2017-05-29  8:11 ` Linus Walleij
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2017-05-29  5:39 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Thomas Petazzoni, Gregory CLEMENT

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
orion5x_defconfig) failed like this:

drivers/gpio/gpio-mvebu.c:1062: undefined reference to `__devm_regmap_init_mmio_clk'
drivers/gpio/gpio-mvebu.c:1078: undefined reference to `__devm_regmap_init_mmio_clk'

Caused by commit

  2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access")

Presumably a missing Kconfig dependency.  Yeah, CONFIG_REGMAP_MMIO is
not set for this build.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2017-02-08  5:11 Stephen Rothwell
  2017-02-08  8:48 ` Lee Jones
  2017-02-13 15:18 ` Linus Walleij
  0 siblings, 2 replies; 106+ messages in thread
From: Stephen Rothwell @ 2017-02-08  5:11 UTC (permalink / raw)
  To: Linus Walleij, Greg KH
  Cc: linux-next, linux-kernel, Lee Jones, Boris Brezillon,
	Alexander Stein, Andy Shevchenko

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/tty/serial/st-asc.c: In function 'asc_set_termios':
drivers/tty/serial/st-asc.c:578:12: error: implicit declaration of function 'devm_get_gpiod_from_child' [-Werror=implicit-function-declaration]
    gpiod = devm_get_gpiod_from_child(port->dev, "rts",
            ^
drivers/tty/serial/st-asc.c:578:10: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
    gpiod = devm_get_gpiod_from_child(port->dev, "rts",
          ^

Caused by commits

  a264d10ff45c ("gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO")
  b2987d7438e0 ("gpio: Pass GPIO label down to gpiod_request")
  4b0947974e59 ("gpio: Rename devm_get_gpiod_from_child()")

interacting with commit

  d7356256488c ("serial: st-asc: (De)Register GPIOD and swap Pinctrl profiles")

from the tty tree.

I applied the following merge fix patch (I guessed about the new arguments):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 8 Feb 2017 15:50:22 +1100
Subject: [PATCH] serial: st-asc: merge fix for devm_get_gpiod_from_child rename

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/tty/serial/st-asc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index bcf1d33e6ffe..c02e6b089364 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -575,8 +575,11 @@ static void asc_set_termios(struct uart_port *port, struct ktermios *termios,
 			pinctrl_select_state(ascport->pinctrl,
 					     ascport->states[NO_HW_FLOWCTRL]);
 
-			gpiod =	devm_get_gpiod_from_child(port->dev, "rts",
-							  &np->fwnode);
+			gpiod =	devm_fwnode_get_gpiod_from_child(port->dev,
+								 "rts",
+								 &np->fwnode,
+								 GPIOD_IN,
+								 np->name);
 			if (!IS_ERR(gpiod)) {
 				gpiod_direction_output(gpiod, 0);
 				ascport->rts = gpiod;
-- 
2.10.2

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2016-09-09  4:36 Stephen Rothwell
  2016-09-12 13:27 ` Linus Walleij
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2016-09-09  4:36 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Marc Zyngier

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpio/gpiolib.c: In function '_gpiochip_irqchip_add':
drivers/gpio/gpiolib.c:1622:62: error: macro "WARN_ON" passed 3 arguments, but takes just 1
       "%s: Ignoring %d default trigger\n", of_node->full_name))
                                                              ^
drivers/gpio/gpiolib.c:1621:6: error: 'WARN_ON' undeclared (first use in this function)
  if (WARN_ON(of_node && type != IRQ_TYPE_NONE,
      ^

Caused by commit

  1ded8b1dafe6 ("gpio/gpiolib: Forbid irqchip default trigger if probed over DT")

I used the version of the gpio tree from next-20160908 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2016-04-18  4:10 Stephen Rothwell
  0 siblings, 0 replies; 106+ messages in thread
From: Stephen Rothwell @ 2016-04-18  4:10 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-f7188x.c: In function 'f7188x_gpio_set_single_ended':
drivers/gpio/gpio-f7188x.c:331:26: error: implicit declaration of function 'gpio_data_mode' [-Werror=implicit-function-declaration]
  superio_outb(sio->addr, gpio_data_mode(bank->regbase), data);
                          ^

Caused by commit

  f90c6bdb690b ("gpio: f7188x: use the new open drain callback")

I have used the gpio tree from next-20160415 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2016-03-31  2:22 Stephen Rothwell
  2016-03-31  7:52 ` Linus Walleij
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2016-03-31  2:22 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel

Hi Linus,

After merging the gpio tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

arch/powerpc/sysdev/ppc4xx_gpio.c: In function 'ppc4xx_gpio_set':
arch/powerpc/sysdev/ppc4xx_gpio.c:93:26: error: unused variable 'mm_gc' [-Werror=unused-variable]
  struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
                          ^
cc1: all warnings being treated as errors

Caused by commit

  0d36fe65f583 ("powerpc: ppc4xx: use gpiochip data pointer")

I applied this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 31 Mar 2016 13:18:45 +1100
Subject: [PATCH] powerpc: ppc4xx: remove unused local variable

Fixes: 0d36fe65f583 ("powerpc: ppc4xx: use gpiochip data pointer")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/sysdev/ppc4xx_gpio.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/powerpc/sysdev/ppc4xx_gpio.c b/arch/powerpc/sysdev/ppc4xx_gpio.c
index 4ab83cd04785..5382d04dd872 100644
--- a/arch/powerpc/sysdev/ppc4xx_gpio.c
+++ b/arch/powerpc/sysdev/ppc4xx_gpio.c
@@ -90,7 +90,6 @@ __ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
 static void
 ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
 {
-	struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
 	struct ppc4xx_gpio_chip *chip = gpiochip_get_data(gc);
 	unsigned long flags;
 
-- 
2.7.0

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2016-02-16  3:48 Stephen Rothwell
  2016-02-16 14:47 ` Linus Walleij
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2016-02-16  3:48 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Nicolas Saenz Julienne

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-tps65218.c: In function 'tps65218_gpio_request':
drivers/gpio/gpio-tps65218.c:74:26: error: 'struct gpio_chip' has no member named 'desc'
  unsigned long flags = gc->desc[offset].flags;
                          ^

Caused by commit

  c366c76a2c41 ("gpio: add tps65218 gpio")

interacting with commit

  1c3cdb186172 ("gpio: move descriptors into gpio_device")

both from the gpio tree.

I have used the gpio tree from next-20160215 fro today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2016-01-29  1:45 Stephen Rothwell
  2016-02-04  2:16 ` Stephen Rothwell
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2016-01-29  1:45 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Liu Gang

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_save_regs':
drivers/gpio/gpio-mpc8xxx.c:57:21: error: implicit declaration of function 'in_be32' [-Werror=implicit-function-declaration]
  mpc8xxx_gc->data = in_be32(mm->regs + GPIO_DAT);
                     ^
drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_set':
drivers/gpio/gpio-mpc8xxx.c:100:2: error: implicit declaration of function 'out_be32' [-Werror=implicit-function-declaration]
  out_be32(mm->regs + GPIO_DAT, mpc8xxx_gc->data);
  ^
drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_dir_in':
drivers/gpio/gpio-mpc8xxx.c:139:2: error: implicit declaration of function 'clrbits32' [-Werror=implicit-function-declaration]
  clrbits32(mm->regs + GPIO_DIR, mpc8xxx_gpio2mask(gpio));
  ^
drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_dir_out':
drivers/gpio/gpio-mpc8xxx.c:156:2: error: implicit declaration of function 'setbits32' [-Werror=implicit-function-declaration]
  setbits32(mm->regs + GPIO_DIR, mpc8xxx_gpio2mask(gpio));
  ^
drivers/gpio/gpio-mpc8xxx.c: In function 'mpc512x_irq_set_type':
drivers/gpio/gpio-mpc8xxx.c:289:3: error: implicit declaration of function 'clrsetbits_be32' [-Werror=implicit-function-declaration]
   clrsetbits_be32(reg, 3 << shift, 2 << shift);
   ^
drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_probe':
drivers/gpio/gpio-mpc8xxx.c:419:26: error: 'NO_IRQ' undeclared (first use in this function)
  if (mpc8xxx_gc->irqn == NO_IRQ)   
                          ^
drivers/gpio/gpio-mpc8xxx.c:419:26: note: each undeclared identifier is reported only once for each function it appears in

Exposed by commit

  5df7fd46b70b ("pio/qoriq: Add qoriq platforms support")

The COMPILE_TEST dependency has revealed several implicit includes ...

I have used the gpio tree from next-20160128 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2015-12-22  5:42 Stephen Rothwell
  2015-12-22  6:57 ` Robert Jarzmik
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2015-12-22  5:42 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Robert Jarzmik

Hi Linus,

After merging the gpio tree, today's linux-next build (lots without
CONFIG_OF) failed like this:

drivers/gpio/gpio-pxa.c: In function 'pxa_gpio_probe':
drivers/gpio/gpio-pxa.c:648:12: error: 'pxa_irq_domain_ops' undeclared (first use in this function)

Caused by commit

  384ca3c6a28d ("gpio: pxa: change the interrupt management")

The reference to pxa_irq_domain_ops was moved out of the protection of
CONFIG_OF ...

Discovered after the release.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2015-12-16  3:37 Stephen Rothwell
  2015-12-16  3:55 ` Yendapally Reddy Dhananjaya Reddy
  2015-12-21  5:02 ` Stephen Rothwell
  0 siblings, 2 replies; 106+ messages in thread
From: Stephen Rothwell @ 2015-12-16  3:37 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Yendapally Reddy Dhananjaya Reddy

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/pinctrl/bcm/pinctrl-nsp-gpio.c: In function 'nsp_gpio_probe':
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:4: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
    set_irq_flags(irq, IRQF_VALID);
    ^
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:699:23: error: 'IRQF_VALID' undeclared (first use in this function)
    set_irq_flags(irq, IRQF_VALID);
                       ^

Caused by commit

  8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")

set_irq_flags was removed before v4.3-rc2 ...

I have used the gpio tree from next-20151215 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2015-12-02 23:38 Mark Brown
  0 siblings, 0 replies; 106+ messages in thread
From: Mark Brown @ 2015-12-02 23:38 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, linux-gpio

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (x86 allmodconfig)
failed like this:

make[1]: Leaving directory '/home/broonie/next/x86_64_allmodconfig'
/home/broonie/next/next/sound/soc/soc-ac97.c: In function 'snd_soc_ac97_init_gpio':
/home/broonie/next/next/sound/soc/soc-ac97.c:145:22: error: 'struct gpio_chip' has no member named 'dev'
  gpio_priv->gpio_chip.dev = codec->dev;
                      ^
/home/broonie/next/next/scripts/Makefile.build:258: recipe for target 'sound/soc/soc-ac97.o' failed
/home/broonie/next/next/scripts/Makefile.build:407: recipe for target 'sound/soc' failed
make[3]: *** [sound/soc/soc-ac97.o] Error 1

We need to cross merge the AC'97 GPIO chip into your tree for you to do the
conversion, I'll send you a pull request later (or in the mornining). For now
I used the last gpio tree that was included in a -next.

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2015-08-31  6:40 Stephen Rothwell
  2015-08-31  6:49 ` Linus Walleij
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2015-08-31  6:40 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Julia Lawall, Fengguang Wu

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-etraxfs.c: In function 'etraxfs_gpio_irq_request_resources':
drivers/gpio/gpio-etraxfs.c:300:2: error: 'ret' undeclared (first use in this function)
  ret = gpiochip_lock_as_irq(&chip->bgc.gc, d->hwirq);
  ^

Caused by commit

  5e22ec019823 ("gpio: extraxfs: fix returnvar.cocci warnings")

I have used the gpio tree from next-20150828 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2015-08-18  6:57 Stephen Rothwell
  2015-08-18 12:00 ` Linus Walleij
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2015-08-18  6:57 UTC (permalink / raw)
  To: Linus Walleij, Mauro Carvalho Chehab
  Cc: linux-next, linux-kernel, Philipp Zabel, Hans Verkuil,
	Uwe Kleine-König

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/media/i2c/tc358743.c: In function 'tc358743_probe_of':
drivers/media/i2c/tc358743.c:1786:22: error: too few arguments to function 'devm_gpiod_get'
  state->reset_gpio = devm_gpiod_get(dev, "reset");
                      ^
In file included from drivers/media/i2c/tc358743.c:34:0:
include/linux/gpio/consumer.h:73:32: note: declared here
 struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
                                ^

Caused by commit

  b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")

interacting with commit

  256148246852 ("[media] tc358743: support probe from device tree")

from the v4l-dvb tree.

I have added the following fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 18 Aug 2015 16:53:21 +1000
Subject: [PATCH] [media] tc358743: fix for devm_gpiod_get API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/media/i2c/tc358743.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index fe42c9a1cb78..8f7641164d9d 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -1783,7 +1783,7 @@ static int tc358743_probe_of(struct tc358743_state *state)
 	state->pdata.ths_trailcnt = 0x2;
 	state->pdata.hstxvregcnt = 0;
 
-	state->reset_gpio = devm_gpiod_get(dev, "reset");
+	state->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_ASIS);
 	if (IS_ERR(state->reset_gpio)) {
 		dev_err(dev, "failed to get reset gpio\n");
 		ret = PTR_ERR(state->reset_gpio);
-- 
2.5.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply related	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2015-08-12  8:10 Stephen Rothwell
  2015-08-12  8:21 ` Uwe Kleine-König
  2015-08-12 20:16 ` Uwe Kleine-König
  0 siblings, 2 replies; 106+ messages in thread
From: Stephen Rothwell @ 2015-08-12  8:10 UTC (permalink / raw)
  To: Linus Walleij, Chanwoo Choi
  Cc: linux-next, linux-kernel, Roger Quadros, Uwe Kleine-König

Hi Linus,

After merging the gpio tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/extcon/extcon-palmas.c:211:25: error: too few arguments to function 'devm_gpiod_get_optional'
  palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
                         ^
In file included from /home/sfr/next/next/include/asm-generic/gpio.h:13:0,
                 from /home/sfr/next/next/include/linux/gpio.h:51,
                 from /home/sfr/next/next/include/linux/of_gpio.h:20,
                 from /home/sfr/next/next/include/linux/mfd/palmas.h:24,
                 from /home/sfr/next/next/drivers/extcon/extcon-palmas.c:28:
/home/sfr/next/next/include/linux/gpio/consumer.h:80:32: note: declared here
 struct gpio_desc *__must_check devm_gpiod_get_optional(struct device *dev,
                                ^

Caused by commit

  b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")

interacting with commit

  92b7cb5dc885 ("extcon: palmas: Support GPIO based USB ID detection")

from the extcon tree.

I have applied this merge fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 12 Aug 2015 18:05:55 +1000
Subject: [PATCH] extcon: palmas: fix for devm_gpiod_get_optional API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/extcon/extcon-palmas.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index 662e91778cb0..4ce4106b8f4f 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -208,7 +208,7 @@ static int palmas_usb_probe(struct platform_device *pdev)
 			palmas_usb->wakeup = pdata->wakeup;
 	}
 
-	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id");
+	palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", GPIOD_ASIS);
 	if (IS_ERR(palmas_usb->id_gpiod)) {
 		dev_err(&pdev->dev, "failed to get id gpio\n");
 		return PTR_ERR(palmas_usb->id_gpiod);
-- 
2.5.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply related	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2015-08-10  5:07 Stephen Rothwell
  2015-08-10  5:46 ` Dmitry Torokhov
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2015-08-10  5:07 UTC (permalink / raw)
  To: Linus Walleij, Dmitry Torokhov
  Cc: linux-next, linux-kernel, Uwe Kleine-König

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/input/touchscreen/elants_i2c.c: In function 'elants_i2c_probe':
drivers/input/touchscreen/elants_i2c.c:1176:19: error: too few arguments to function 'devm_gpiod_get'
  ts->reset_gpio = devm_gpiod_get(&client->dev, "reset");
                   ^
In file included from drivers/input/touchscreen/elants_i2c.c:41:0:
include/linux/gpio/consumer.h:73:32: note: declared here
 struct gpio_desc *__must_check devm_gpiod_get(struct device *dev,
                                ^

Caused by commit

  b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")

Interacting with commit

  afe10358e47a ("Input: elants_i2c - wire up regulator support")

from the input tree.

I have added the following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 10 Aug 2015 15:01:19 +1000
Subject: [PATCH] Input: elants_i2c: fix for devm_gpiod_get API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/input/touchscreen/elants_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c
index 6f7155641591..1e7b931d6112 100644
--- a/drivers/input/touchscreen/elants_i2c.c
+++ b/drivers/input/touchscreen/elants_i2c.c
@@ -1173,7 +1173,7 @@ static int elants_i2c_probe(struct i2c_client *client,
 		return error;
 	}
 
-	ts->reset_gpio = devm_gpiod_get(&client->dev, "reset");
+	ts->reset_gpio = devm_gpiod_get(&client->dev, "reset", GPIOD_ASIS);
 	if (IS_ERR(ts->reset_gpio)) {
 		error = PTR_ERR(ts->reset_gpio);
 
-- 
2.5.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply related	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2015-07-21  3:29 Stephen Rothwell
  0 siblings, 0 replies; 106+ messages in thread
From: Stephen Rothwell @ 2015-07-21  3:29 UTC (permalink / raw)
  To: Linus Walleij, Mark Brown, Liam Girdwood
  Cc: linux-next, linux-kernel, Chris Zhong, Uwe Kleine-König

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/rk808-regulator.c: In function 'rk808_regulator_dt_parse_pdata':
drivers/regulator/rk808-regulator.c:543:24: error: too few arguments to function 'gpiod_get_index'
   pdata->dvs_gpio[i] = gpiod_get_index(client_dev, "dvs", i);
                        ^
In file included from include/asm-generic/gpio.h:13:0,
                 from include/linux/gpio.h:51,
                 from drivers/regulator/rk808-regulator.c:20:
include/linux/gpio/consumer.h:53:32: note: declared here
 struct gpio_desc *__must_check gpiod_get_index(struct device *dev,
                                ^

Caused by commit

  bad47ad2eef3 ("regulator: rk808: fixed the overshoot when adjust voltage")

from the regulator tree interactings with commit

  b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")

from the gpio tree.

I added teh following merge fix patch:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 21 Jul 2015 13:23:56 +1000
Subject: [PATCH] regulator: rk808: fix up for gpiod_get_index() API change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/regulator/rk808-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c
index ca913fd15598..cfec52c1a4a2 100644
--- a/drivers/regulator/rk808-regulator.c
+++ b/drivers/regulator/rk808-regulator.c
@@ -540,7 +540,7 @@ static int rk808_regulator_dt_parse_pdata(struct device *dev,
 		goto dt_parse_end;
 
 	for (i = 0; i < ARRAY_SIZE(pdata->dvs_gpio); i++) {
-		pdata->dvs_gpio[i] = gpiod_get_index(client_dev, "dvs", i);
+		pdata->dvs_gpio[i] = gpiod_get_index(client_dev, "dvs", i, GPIOD_ASIS);
 		if (IS_ERR(pdata->dvs_gpio[i])) {
 			dev_warn(dev, "there is no dvs%d gpio\n", i);
 			continue;
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply related	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2015-05-13  6:55 Stephen Rothwell
  2015-05-13  7:04 ` Alexandre Courbot
  2015-05-13  7:36 ` Johan Hovold
  0 siblings, 2 replies; 106+ messages in thread
From: Stephen Rothwell @ 2015-05-13  6:55 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Johan Hovold, Alexandre Courbot

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-dln2.c: In function 'dln2_gpio_probe':
drivers/gpio/gpio-dln2.c:469:12: error: 'struct gpio_chip' has no member named 'exported'
  dln2->gpio.exported = true;
            ^

Caused by commit 6a4b6b0a3b55 ("gpio: sysfs: clean up chip class-device
handling").

I have used the gpio tree from next-20150512 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2015-04-10  9:08 Stephen Rothwell
  2015-04-10  9:35 ` Linus Walleij
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2015-04-10  9:08 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Michael S. Tsirkin

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/gpio/gpio-sch.c:28:32: fatal error: uapi/linux/pci_ids.h: No such file or directory
 #include <uapi/linux/pci_ids.h>
                                ^

Caused by commit d1e10dc8c104 ("gpio: sch: use uapi/linux/pci_ids.h
directly"). Clearly this depends on some other patch.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2014-07-29  8:31 Stephen Rothwell
  2014-07-29  8:42 ` Thierry Reding
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2014-07-29  8:31 UTC (permalink / raw)
  To: Linus Walleij, Olof Johansson, Arnd Bergmann, linux-arm-kernel
  Cc: linux-next, linux-kernel, Thierry Reding

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from arch/arm/mach-tegra/board-paz00.c:20:0:
include/linux/gpio/machine.h:24:2: error: unknown type name 'u16'
  u16 chip_hwnum;
  ^
include/linux/gpio/machine.h:31:19: error: field 'list' has incomplete type
  struct list_head list;
                   ^

Caused by commit 0a6d315827ee ("gpio: split gpiod board registration
into machine header") or an interaction of that with commit
a0524acc94c9 ("ARM: tegra: Sort includes alphabetically") from the
arm-soc tree.

linux/gpio/machine.h needs to include some of the same files that
linux/gpio/driver.h does.  See Rule 1 in Documentation/SubmitChecklist.

I have used the version of the gpio tree from next-20140728 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2014-05-14  7:13 Stephen Rothwell
  2014-05-16 15:54 ` Linus Walleij
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2014-05-14  7:13 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Lee Jones

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (powerpc allyesconfig)
failed like this:

drivers/mfd/stmpe.c: In function 'stmpe_irq_init':
drivers/mfd/stmpe.c:1000:15: error: 'struct stmpe' has no member named 'irq_base'
   base = stmpe->irq_base;
               ^

Caused by commit 3ba1d516d5fe ("mfd: stmpe: root out static GPIO and
IRQ assignments").

I have reverted that commit for today (and e013a5148882 "gpio: stmpe:
switch to use gpiolib irqchip helpers" that depends on it).

Also, that commit has no Signed-off-by for its committer (Lee).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2014-01-20  5:42 Stephen Rothwell
  0 siblings, 0 replies; 106+ messages in thread
From: Stephen Rothwell @ 2014-01-20  5:42 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, Lars Poeschel

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-mcp23s08.c: In function 'mcp23s08_irq_setup':
drivers/gpio/gpio-mcp23s08.c:482:46: error: 'struct gpio_chip' has no member named 'of_node'
  mcp->irq_domain = irq_domain_add_linear(chip->of_node, chip->ngpio,
                                              ^
drivers/gpio/gpio-mcp23s08.c: In function 'mcp23s08_probe_one':
drivers/gpio/gpio-mcp23s08.c:651:55: error: 'struct gpio_chip' has no member named 'of_node'
  mcp->irq_controller = of_property_read_bool(mcp->chip.of_node,
                                                       ^
drivers/gpio/gpio-mcp23s08.c:654:43: error: 'struct gpio_chip' has no member named 'of_node'
   mirror = of_property_read_bool(mcp->chip.of_node,
                                           ^

Caused by commit 4e47f91bf741 ("gpio: mcp23s08: Add irq functionality for
i2c chips").  The presence of of_node depends on CONFIG_OF_GPIO.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2013-09-18  3:12 Stephen Rothwell
  2013-09-18 11:24 ` Linus Walleij
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2013-09-18  3:12 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-next, linux-kernel, George Cherian

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

Hi Linus,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-pcf857x.c: In function 'pcf857x_irq_domain_map':
drivers/gpio/gpio-pcf857x.c:206:2: error: implicit declaration of function 'set_irq_flags' [-Werror=implicit-function-declaration]
  set_irq_flags(virq, IRQF_VALID);
  ^
drivers/gpio/gpio-pcf857x.c:206:22: error: 'IRQF_VALID' undeclared (first use in this function)
  set_irq_flags(virq, IRQF_VALID);
                      ^

Caused by commit 21fd3cd1874a ("gpio: pcf857x: call the gpio user handler
iff gpio_to_irq is done").

set_irq_flags() only exists on arm (and arm64).

I have used the gpio tree from next-20130917 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2013-03-04  1:45 Stephen Rothwell
  2013-03-04  2:30 ` Linus Walleij
  2013-03-04  2:32 ` Grant Likely
  0 siblings, 2 replies; 106+ messages in thread
From: Stephen Rothwell @ 2013-03-04  1:45 UTC (permalink / raw)
  To: Grant Likely; +Cc: linux-next, linux-kernel, Gabriel Fernandez, Linus Walleij

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

Hi Grant,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpio/gpio-stmpe.c: In function 'stmpe_gpio_irq_init':
drivers/gpio/gpio-stmpe.c:313:23: error: 'struct gpio_chip' has no member named 'of_node'
drivers/gpio/gpio-stmpe.c:316:61: error: 'struct gpio_chip' has no member named 'of_node'
drivers/gpio/gpio-stmpe.c: In function 'stmpe_gpio_probe':
drivers/gpio/gpio-stmpe.c:351:18: error: 'struct gpio_chip' has no member named 'of_node'

Caused by commit f7719903b7c7 ("").

I have used the gpio tree from next-20130301 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2012-02-03  2:54 Stephen Rothwell
  2012-02-03 23:18 ` Grant Likely
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2012-02-03  2:54 UTC (permalink / raw)
  To: Grant Likely; +Cc: linux-next, linux-kernel, Mark Brown

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

Hi Grant,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/i2c/busses/i2c-gpio.c:18:22: fatal error: asm/gpio.h: No such file or directory
drivers/input/mouse/gpio_mouse.c:17:22: fatal error: asm/gpio.h: No such file or directory
drivers/leds/leds-gpio.c:23:22: fatal error: asm/gpio.h: No such file or directory

Caused by commit 4f79dfb562c2 ("gpiolib/arches: Centralise bolierplate
asm/gpio.h").  Grep is your friend ...

I have used the gpio tree from next-20120202 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread
* linux-next: build failure after merge of the gpio tree
@ 2011-10-06  3:48 Stephen Rothwell
  2011-10-11  6:37 ` Stephen Rothwell
  0 siblings, 1 reply; 106+ messages in thread
From: Stephen Rothwell @ 2011-10-06  3:48 UTC (permalink / raw)
  To: Grant Likely; +Cc: linux-next, linux-kernel, Tomoya MORINAGA

[-- Attachment #1: Type: text/plain, Size: 717 bytes --]

Hi Grant,

After merging the gpio tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-pch.ko] undefined!
ERROR: "irq_setup_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!
ERROR: "irq_alloc_generic_chip" [drivers/gpio/gpio-ml-ioh.ko] undefined!

Presumably caused by commits 54be566317b6 ("gpio-ml-ioh: Support
interrupt function") and 38eb18a6f92d ("gpio-pch: Support interrupt
function").

I have used the gpio tree from next-20111005 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 106+ messages in thread

end of thread, other threads:[~2020-11-18  7:51 UTC | newest]

Thread overview: 106+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-12  6:59 linux-next: build failure after merge of the gpio tree Stephen Rothwell
2015-08-12  7:20 ` [PATCH] Bluetooth: hci_bcm: improve use of gpios API Uwe Kleine-König
2015-08-12  8:19   ` Stephen Rothwell
     [not found]   ` <1439364056-8564-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-08-12 14:39     ` Marcel Holtmann
  -- strict thread matches above, loose matches on Subject: below --
2020-11-18  3:30 linux-next: build failure after merge of the gpio tree Stephen Rothwell
2020-11-18  7:50 ` Linus Walleij
2020-04-01  4:19 Stephen Rothwell
2020-04-01  7:49 ` Geert Uytterhoeven
2020-04-01  7:57   ` Stephen Rothwell
2020-04-01  8:18   ` Linus Walleij
2020-04-01  8:24     ` Geert Uytterhoeven
2020-04-01 12:29       ` Andy Shevchenko
2020-04-01 12:30         ` Andy Shevchenko
2020-04-01  8:19 ` Linus Walleij
2020-03-30  7:58 Stephen Rothwell
2020-03-30  6:11 Stephen Rothwell
2019-08-16 11:38 Stephen Rothwell
2019-08-16 22:25 ` Linus Walleij
2018-12-17  8:24 Stephen Rothwell
2018-12-10  7:00 Stephen Rothwell
2017-11-02  5:20 Stephen Rothwell
2017-11-02  5:33 ` Masahiro Yamada
2017-11-03  7:50 ` Linus Walleij
2017-11-03  8:13   ` Stephen Rothwell
2017-11-03 21:40     ` Linus Walleij
2017-11-13 11:33 ` Stephen Rothwell
2017-11-13 13:40   ` Masahiro Yamada
2017-06-21  6:09 Stephen Rothwell
2017-06-21  6:12 ` Jisheng Zhang
2017-06-21  7:41 ` Linus Walleij
2017-05-29  5:39 Stephen Rothwell
2017-05-29  8:11 ` Linus Walleij
2017-02-08  5:11 Stephen Rothwell
2017-02-08  8:48 ` Lee Jones
2017-02-08  9:05   ` Boris Brezillon
2017-02-08 10:30   ` Stephen Rothwell
2017-02-13 15:18 ` Linus Walleij
2016-09-09  4:36 Stephen Rothwell
2016-09-12 13:27 ` Linus Walleij
2016-04-18  4:10 Stephen Rothwell
2016-03-31  2:22 Stephen Rothwell
2016-03-31  7:52 ` Linus Walleij
2016-02-16  3:48 Stephen Rothwell
2016-02-16 14:47 ` Linus Walleij
2016-01-29  1:45 Stephen Rothwell
2016-02-04  2:16 ` Stephen Rothwell
2016-02-08 17:36   ` Linus Walleij
2015-12-22  5:42 Stephen Rothwell
2015-12-22  6:57 ` Robert Jarzmik
2015-12-22  9:08   ` Linus Walleij
2015-12-22 20:10     ` Stephen Rothwell
2015-12-22 23:58       ` Linus Walleij
2015-12-23  0:20         ` Stephen Rothwell
2015-12-16  3:37 Stephen Rothwell
2015-12-16  3:55 ` Yendapally Reddy Dhananjaya Reddy
2015-12-21  5:02 ` Stephen Rothwell
2015-12-21  8:46   ` Linus Walleij
2015-12-02 23:38 Mark Brown
2015-08-31  6:40 Stephen Rothwell
2015-08-31  6:49 ` Linus Walleij
2015-08-18  6:57 Stephen Rothwell
2015-08-18 12:00 ` Linus Walleij
2015-08-18 12:23   ` Uwe Kleine-König
2015-08-18 13:35     ` Mauro Carvalho Chehab
2015-08-12  8:10 Stephen Rothwell
2015-08-12  8:21 ` Uwe Kleine-König
2015-08-12 12:27   ` Stephen Rothwell
2015-08-12 15:03     ` Stephen Rothwell
2015-08-12 20:16 ` Uwe Kleine-König
2015-08-12 23:02   ` Stephen Rothwell
2015-08-13  0:19     ` Chanwoo Choi
2015-08-13  0:50       ` Stephen Rothwell
2015-08-10  5:07 Stephen Rothwell
2015-08-10  5:46 ` Dmitry Torokhov
2015-08-10 22:51   ` Stephen Rothwell
2015-07-21  3:29 Stephen Rothwell
2015-05-13  6:55 Stephen Rothwell
2015-05-13  7:04 ` Alexandre Courbot
2015-05-13  7:36 ` Johan Hovold
2015-04-10  9:08 Stephen Rothwell
2015-04-10  9:35 ` Linus Walleij
2014-07-29  8:31 Stephen Rothwell
2014-07-29  8:42 ` Thierry Reding
2014-08-04  4:10   ` Alexandre Courbot
2014-08-04  4:28     ` Stephen Rothwell
2014-05-14  7:13 Stephen Rothwell
2014-05-16 15:54 ` Linus Walleij
2014-01-20  5:42 Stephen Rothwell
2013-09-18  3:12 Stephen Rothwell
2013-09-18 11:24 ` Linus Walleij
2013-03-04  1:45 Stephen Rothwell
2013-03-04  2:30 ` Linus Walleij
2013-03-04  2:32 ` Grant Likely
2012-02-03  2:54 Stephen Rothwell
2012-02-03 23:18 ` Grant Likely
2012-02-04 12:10   ` Mark Brown
2011-10-06  3:48 Stephen Rothwell
2011-10-11  6:37 ` Stephen Rothwell
2011-10-11  7:02   ` Tomoya MORINAGA
2011-10-12  4:24     ` Stephen Rothwell
2011-10-12  5:29       ` Tomoya MORINAGA
2011-10-12  7:21         ` Nobuhiro Iwamatsu
2011-10-12  8:37           ` Tomoya MORINAGA
2011-10-13  3:57             ` Grant Likely
2011-10-13  8:22               ` Tomoya MORINAGA
2011-10-13 17:31                 ` Grant Likely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).