From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Tadeusz Struk <tadeusz.struk@intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
linux-next list <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Michal Marek <mmarek@suse.cz>,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: linux-next: Tree for Aug 12 (include/linux/pci.h)
Date: Thu, 20 Aug 2015 16:18:49 +1000 [thread overview]
Message-ID: <20150820161849.79552437@canb.auug.org.au> (raw)
In-Reply-To: <CAErSpo4+H6AJs9shVGN8fm9=GwPL9EzNcyMNt5FW81JGEA1sDA@mail.gmail.com>
Hi Bjorn,
On Wed, 19 Aug 2015 23:16:06 -0700 Bjorn Helgaas <bhelgaas@google.com> wrote:
>
> [+cc Yann, linux-kbuild]
>
> On Wed, Aug 12, 2015 at 3:58 PM, Tadeusz Struk <tadeusz.struk@intel.com> wrote:
> > On 08/12/2015 02:53 PM, Stephen Rothwell wrote:
> >> On Wed, 12 Aug 2015 11:05:36 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> >>> >
> >>> > on i386 or x86_64:
> >>> >
> >>> > Many (repeated) errors like this one:
> >>> >
> >>> > ../include/linux/pci.h:390:12: error: ‘struct pci_dev’ has no member named ‘physfn’
> >>> >
> >>> > when CONFIG_PCI_ATS is not enabled.
> >> Maybe caused by commit
> >>
> >> dd0f368398ea ("crypto: qat - Add qat dh895xcc VF driver")
> >>
> >> from the crypto tree Which adds a
> >>
> >> select PCI_IOV
> >>
> >> to drivers/crypto/qat/Kconfig without the necessary
> >>
> >> select PCI
> >>
> >> but PCI_IOV selects PCI_ATS, so I am not sure what happened here. I am
> >> assuming that your config has PCI_IOV enabled? What about PCI?
> >
> > There is a patch submitted, but not yet applied
> > https://patchwork.kernel.org/patch/6994171/
> > maybe it will help?
>
> I don't understand this. In drivers/pci/Kconfig, we have:
>
> config PCI_IOV
> depends on PCI
>
> and in drivers/crypto/qat/Kconfig, dd0f368398ea adds:
>
> config CRYPTO_DEV_QAT_DH895xCCVF
> select PCI_IOV
>
> And apparently it's possible to end up with a .config with
> CONFIG_PCI_IOV=y but CONFIG_PCI is not set? That seems wrong, since
> we declared that PCI_IOV depends on PCI. Does select ignore that
> dependency somehow?
Yeah, unfortunately that is how select works. If a symbol you select
depends on anything, then you need to also select all the dependencies.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
next prev parent reply other threads:[~2015-08-20 6:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 13:39 linux-next: Tree for Aug 12 Stephen Rothwell
2015-08-12 18:05 ` linux-next: Tree for Aug 12 (include/linux/pci.h) Randy Dunlap
2015-08-12 21:53 ` Stephen Rothwell
2015-08-12 22:58 ` Tadeusz Struk
2015-08-13 0:16 ` Randy Dunlap
2015-08-13 0:49 ` Stephen Rothwell
2015-08-20 6:16 ` Bjorn Helgaas
2015-08-20 6:18 ` Stephen Rothwell [this message]
2015-08-12 23:22 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820161849.79552437@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=bhelgaas@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rdunlap@infradead.org \
--cc=tadeusz.struk@intel.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).