From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: kirill@shutemov.name
Cc: paulmck@linux.vnet.ibm.com, starvik@axis.com, linux@roeck-us.net,
jespern@axis.com, hughd@google.com,
kirill.shutemov@linux.intel.com, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
minchan@kernel.org, linux-cris-kernel@axis.com
Subject: Re: crisv32 runtime failure in -next due to 'page-flags: define behavior SL*B-related flags on compound pages'
Date: Tue, 22 Sep 2015 18:16:18 +0200 [thread overview]
Message-ID: <201509221616.t8MGGIrW017239@ignucius.se.axis.com> (raw)
In-Reply-To: <20150922153104.GA19024@node.dhcp.inet.fi> (kirill@shutemov.name)
> From: "Kirill A. Shutemov" <kirill@shutemov.name>
> Date: Tue, 22 Sep 2015 17:31:04 +0200
> On Tue, Sep 22, 2015 at 08:18:35AM -0700, Paul E. McKenney wrote:
> > On Tue, Sep 22, 2015 at 03:57:06PM +0200, Hans-Peter Nilsson wrote:
> > > I guess you hit the right spot, but I'd think people would be
> > > more comfortable with aligning to sizeof (void *).
> >
> > I would indeed prefer sizeof(void *).
>
> Do you prefer to have the attribute set for whole structure or for ->next?
> I think attribute on ->next is more appropriate from documentation POV.
Speaking of the documentation POV, I'd recommend adding an
explanatory comment. Here's hoping this was obvious! ;)
brgds, H-P
next prev parent reply other threads:[~2015-09-22 16:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 16:29 crisv32 runtime failure in -next due to 'page-flags: define behavior SL*B-related flags on compound pages' Guenter Roeck
2015-09-18 14:25 ` Kirill A. Shutemov
2015-09-18 14:53 ` Jesper Nilsson
2015-09-18 15:13 ` Guenter Roeck
2015-09-21 15:34 ` Kirill A. Shutemov
2015-09-22 1:17 ` Guenter Roeck
2015-09-22 12:03 ` Kirill A. Shutemov
2015-09-22 12:19 ` Mikael Starvik
2015-09-22 12:50 ` Hans-Peter Nilsson
2015-09-22 13:27 ` Kirill A. Shutemov
2015-09-22 13:57 ` Hans-Peter Nilsson
2015-09-22 15:18 ` Paul E. McKenney
2015-09-22 15:31 ` Kirill A. Shutemov
2015-09-22 15:40 ` Paul E. McKenney
2015-09-23 10:53 ` Kirill A. Shutemov
2015-09-23 15:02 ` Guenter Roeck
2015-09-24 4:45 ` Paul E. McKenney
2015-09-22 16:16 ` Hans-Peter Nilsson [this message]
2015-09-22 16:39 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201509221616.t8MGGIrW017239@ignucius.se.axis.com \
--to=hans-peter.nilsson@axis.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jespern@axis.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=minchan@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).