From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Al Viro <viro@ZenIV.linux.org.uk>, Ben Myers <bpm@sgi.com>,
David Chinner <david@fromorbit.com>,
xfs@oss.sgi.com
Cc: Brian Foster <bfoster@redhat.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Andreas Gruenbacher <agruenba@redhat.com>
Subject: linux-next: manual merge of the vfs tree with the xfs tree
Date: Wed, 11 Nov 2015 10:21:54 +1100 [thread overview]
Message-ID: <20151111102154.507e2a67@canb.auug.org.au> (raw)
Hi Al,
Today's linux-next merge of the vfs tree got a conflict in:
fs/xfs/xfs_xattr.c
between commit:
67d8e04e345e ("xfs: invalidate cached acl if set directly via xattr")
from the xfs tree and commit:
64669c648bc0 ("xattr handlers: Pass handler to operations instead of flags")
from the vfs tree.
I fixed it up (see below) and can carry the fix as necessary (no action
is required).
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --cc fs/xfs/xfs_xattr.c
index 8294f86441bf,b1850e1489ef..000000000000
--- a/fs/xfs/xfs_xattr.c
+++ b/fs/xfs/xfs_xattr.c
@@@ -53,34 -54,12 +54,35 @@@ xfs_xattr_get(const struct xattr_handle
return asize;
}
+void
+xfs_forget_acl(
+ struct inode *inode,
+ const char *name,
+ int xflags)
+{
+ /*
+ * Invalidate any cached ACLs if the user has bypassed the ACL
+ * interface. We don't validate the content whatsoever so it is caller
+ * responsibility to provide data in valid format and ensure i_mode is
+ * consistent.
+ */
+ if (xflags & ATTR_ROOT) {
+#ifdef CONFIG_XFS_POSIX_ACL
+ if (!strcmp(name, SGI_ACL_FILE))
+ forget_cached_acl(inode, ACL_TYPE_ACCESS);
+ else if (!strcmp(name, SGI_ACL_DEFAULT))
+ forget_cached_acl(inode, ACL_TYPE_DEFAULT);
+#endif
+ }
+}
+
static int
- xfs_xattr_set(struct dentry *dentry, const char *name, const void *value,
- size_t size, int flags, int xflags)
+ xfs_xattr_set(const struct xattr_handler *handler, struct dentry *dentry,
+ const char *name, const void *value, size_t size, int flags)
{
- int xflags = handler->flags;
- struct xfs_inode *ip = XFS_I(d_inode(dentry));
+ struct xfs_inode *ip = XFS_I(d_inode(dentry));
+ int error;
++ int xflags = handler->flags;
if (strcmp(name, "") == 0)
return -EINVAL;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2015-11-10 23:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 23:21 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-19 0:49 linux-next: manual merge of the vfs tree with the xfs tree Stephen Rothwell
2021-04-20 16:40 ` Darrick J. Wong
2021-04-12 2:22 Stephen Rothwell
2021-04-13 15:20 ` Darrick J. Wong
2018-10-31 0:52 Stephen Rothwell
2018-10-31 1:12 ` Dave Chinner
2016-12-11 23:19 Stephen Rothwell
2015-04-14 1:34 Stephen Rothwell
2015-04-13 1:57 Stephen Rothwell
2015-04-13 2:12 ` Dave Chinner
2011-07-18 3:36 Stephen Rothwell
2011-07-19 1:29 ` Dave Chinner
2010-07-26 1:51 Stephen Rothwell
2010-07-26 3:59 ` Dave Chinner
2010-07-26 4:05 ` Stephen Rothwell
2010-07-05 0:02 Stephen Rothwell
2010-07-07 1:48 ` Christoph Hellwig
2010-07-07 3:50 ` Stephen Rothwell
2010-08-04 1:54 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111102154.507e2a67@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=agruenba@redhat.com \
--cc=bfoster@redhat.com \
--cc=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).