From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: Disable stack validation when CROSS_COMPILE is used
Date: Wed, 2 Mar 2016 15:17:26 -0600 [thread overview]
Message-ID: <20160302211726.GA23501@treble.redhat.com> (raw)
In-Reply-To: <20160302132735.37262b34@canb.auug.org.au>
On Wed, Mar 02, 2016 at 01:27:35PM +1100, Stephen Rothwell wrote:
> Hi Josh,
>
> On Tue, 1 Mar 2016 15:54:51 -0600 Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> >
> > Changing it to use the host compiler would probably be an easy fix, but
> > that would expose a harder bug related to endianness.
>
> Just by luck, my PowerPC host is little endian :-)
Aha! In that case, I think I'll take a different approach and try to
add support for CROSS_COMPILE.
We'll need it anyway, later on, when we port objtool to more
architectures.
> > How about the below workaround patch to disable objtool and warn when
> > CROSS_COMPILE is used? If anybody complains about lack of cross-compile
> > support later, we could try to fix it then.
>
> This seems reasonable.
>
> > From a3c65947011a420743f308b698171c4209105d3f Mon Sep 17 00:00:00 2001
> > Message-Id: <a3c65947011a420743f308b698171c4209105d3f.1456868910.git.jpoimboe@redhat.com>
> > From: Josh Poimboeuf <jpoimboe@redhat.com>
> > Date: Tue, 1 Mar 2016 13:35:51 -0600
> > Subject: [PATCH] objtool: Disable stack validation when CROSS_COMPILE is used
>
> I have applied this to the merge of the tip tree in linux-next today
> and it compiles fine for me. I will continue applying it until
> something better comes along or it is applied to the tip tree.
Thanks. I should have the patch(es) soon. If/when they get merged,
I'll let you know, and then you can drop this one.
--
Josh
next prev parent reply other threads:[~2016-03-02 21:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 1:29 linux-next: build failure after merge of the tip tree Stephen Rothwell
2016-03-01 7:07 ` Ingo Molnar
2016-03-01 7:28 ` Sedat Dilek
2016-03-01 7:39 ` H. Peter Anvin
2016-03-01 8:41 ` Sedat Dilek
2016-03-01 9:45 ` Ingo Molnar
2016-03-01 9:40 ` Stephen Rothwell
2016-03-01 21:54 ` [PATCH] objtool: Disable stack validation when CROSS_COMPILE is used Josh Poimboeuf
2016-03-02 2:27 ` Stephen Rothwell
2016-03-02 21:17 ` Josh Poimboeuf [this message]
2016-03-02 22:21 ` Stephen Rothwell
2016-03-03 7:31 ` Sedat Dilek
2016-03-03 7:57 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302211726.GA23501@treble.redhat.com \
--to=jpoimboe@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).