linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Dan Williams <dan.j.williams@intel.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: linux-next: manual merge of the nvdimm tree with the block tree
Date: Mon, 11 Jul 2016 17:59:03 +1000	[thread overview]
Message-ID: <20160711175903.2624fe5a@canb.auug.org.au> (raw)

Hi Dan,

Today's linux-next merge of the nvdimm tree got a conflict in:

  drivers/nvdimm/pmem.c

between commit:

  0d52c756a665 ("block: convert to device_add_disk()")

from the block tree and commit:

  f02716db951c ("libnvdimm: use devm_add_action_or_reset()")

from the nvdimm tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/nvdimm/pmem.c
index 066e07d9330f,b6fcb97a601c..000000000000
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@@ -303,7 -286,11 +285,11 @@@ static int pmem_attach_disk(struct devi
  		return -ENOMEM;
  	nvdimm_badblocks_populate(to_nd_region(dev->parent), &pmem->bb, res);
  	disk->bb = &pmem->bb;
 -	add_disk(disk);
 +	device_add_disk(dev, disk);
+ 
+ 	if (devm_add_action_or_reset(dev, pmem_release_disk, disk))
+ 		return -ENOMEM;
+ 
  	revalidate_disk(disk);
  
  	return 0;

             reply	other threads:[~2016-07-11  7:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11  7:59 Stephen Rothwell [this message]
2017-04-24  5:45 linux-next: manual merge of the nvdimm tree with the block tree Stephen Rothwell
2017-04-24  5:50 Stephen Rothwell
2022-03-15  8:18 Stephen Rothwell
2022-03-15  8:21 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160711175903.2624fe5a@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=axboe@kernel.dk \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).