Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the rtc tree
Date: Mon, 11 Jul 2016 23:23:40 +0200
Message-ID: <20160711212340.GS22202@piout.net> (raw)
In-Reply-To: <20160711082351.GA10303@perseus.defre.kleine-koenig.org>

On 11/07/2016 at 10:23:51 +0200, Uwe Kleine-König wrote :
> Hello,
> 
> On Mon, Jul 11, 2016 at 06:12:08PM +1000, Stephen Rothwell wrote:
> > After merging the rtc tree, today's linux-next build (x86 64_allmodconfig)
> > produced this warning:
> > 
> > drivers/rtc/rtc-isl12057.c: In function 'isl12057_rtc_read_alarm':
> > drivers/rtc/rtc-isl12057.c:249:26: warning: unused variable 'alarm_secs' [-Wunused-variable]
> >   unsigned long rtc_secs, alarm_secs;
> >                           ^
> > drivers/rtc/rtc-isl12057.c:249:16: warning: unused variable 'rtc_secs' [-Wunused-variable]
> >   unsigned long rtc_secs, alarm_secs;
> >                 ^
> > drivers/rtc/rtc-isl12057.c:248:18: warning: unused variable 'rtc_tm' [-Wunused-variable]
> >   struct rtc_time rtc_tm, *alarm_tm = &alarm->time;
> >                   ^
> > 
> > Introduced by commit
> > 
> >   4e30a585a343 ("rtc: isl12057: let the rtc core interpret the partial alarm")
> 
> Thanks for catching that. The obvious fix is:
> 
> diff --git a/drivers/rtc/rtc-isl12057.c b/drivers/rtc/rtc-isl12057.c
> index e0245fc6205e..0e7f0f52bfe4 100644
> --- a/drivers/rtc/rtc-isl12057.c
> +++ b/drivers/rtc/rtc-isl12057.c
> @@ -245,8 +245,7 @@ static int isl12057_rtc_update_alarm(struct device *dev, int enable)
>  static int isl12057_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alarm)
>  {
>  	struct isl12057_rtc_data *data = dev_get_drvdata(dev);
> -	struct rtc_time rtc_tm, *alarm_tm = &alarm->time;
> -	unsigned long rtc_secs, alarm_secs;
> +	struct rtc_time *alarm_tm = &alarm->time;
>  	u8 regs[ISL12057_A1_SEC_LEN];
>  	unsigned int ir;
>  	int ret;
> 
> Alexandre: Do you fixup, or should I send a proper patch for that?
> 

I fixed it up. I shouldn't have missed that one...

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11  8:12 Stephen Rothwell
2016-07-11  8:23 ` Uwe Kleine-König
2016-07-11 21:23   ` Alexandre Belloni [this message]
2017-01-10  3:01 Stephen Rothwell
2017-01-10 10:59 ` Alexandre Belloni
2017-01-13  3:18 Stephen Rothwell
2017-01-13  8:42 ` Amelie DELAUNAY
2017-06-29  5:42 Stephen Rothwell
2017-07-06  4:24 Stephen Rothwell
2017-07-06  5:54 ` Heiner Kallweit
2017-07-06  6:59   ` Alexandre Belloni
2018-03-21  6:44 Stephen Rothwell
2019-03-28  1:23 Stephen Rothwell
2019-03-28  1:36 ` Joel Stanley
2019-03-28  1:57   ` Alexandre Belloni
2019-03-28  2:09     ` Joel Stanley
2019-08-21  6:31 Stephen Rothwell
2019-10-30  4:41 Stephen Rothwell
2019-11-08  5:29 ` Stephen Rothwell
2019-11-08 15:20   ` Alexandre Belloni

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160711212340.GS22202@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git