From: Krzysztof Kozlowski <krzk@kernel.org>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: Re: linux-next: build failure after merge of the pm tree
Date: Mon, 19 Sep 2016 18:12:18 +0200 [thread overview]
Message-ID: <20160919161218.GA5073@kozik-book> (raw)
In-Reply-To: <1589961933.1419204.1474270644855.JavaMail.weblogic@ep1ml103c>
On Mon, Sep 19, 2016 at 07:37:24AM +0000, MyungJoo Ham wrote:
> > On Wednesday, September 14, 2016 02:27:47 PM Stephen Rothwell wrote:
> > > Hi Rafael,
> > >
> > > After merging the pm tree, today's linux-next build (powerpc allyesconfig)
> > > failed like this:
> > >
> > > drivers/devfreq/tegra-devfreq.c: In function 'tegra_devfreq_target':
> > > drivers/devfreq/tegra-devfreq.c:500:2: error: implicit declaration of function 'clk_set_min_rate' [-Werror=implicit-function-declaration]
> > > clk_set_min_rate(tegra->emc_clock, rate);
> > > ^
> > >
> > > Caused by commit
> > >
> > > 797da5598f3a ("PM / devfreq: Add COMPILE_TEST for build coverage")
>
> @Rafael: Thank you!
>
>
> @Kozlowski:
>
> It looks like COMMON_CLK is required to be "selected" for TEGRA.
>
> Although COMMON_CLK is supposed to be widely used by most ARM platforms
> especially if "Multiple platfrom selection" for ARMv7 is used,
> COMPILE_TEST won't recognize it.
>
> Adding COMMON_CLK for TEGRA will solve this instance of issue; however,
> for COMPILE_TEST to be reasonably robust, each "COMPILE_TEST"ed item
> should "select" every required item. How do you want to proceed with
> COMPILE_TEST on SoC-specific device drivers?
I think drivers should depend on COMMON_CLK in such case. This tegra
driver probably does not require strict ARCH_TEGRA_124_SOC dependency
because it does not use any SoC-specific data/functions etc. However it
uses common clock framework so explicit dependency looks proper to me.
In fact this is already seen in kernel like SND_SOC_TEGRA, SND_MXS_SOC,
PWM_IMG(with compile test), SND_SOC_RCAR (even without compile test).
Best regards,
Krzysztof
prev parent reply other threads:[~2016-09-19 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 4:27 linux-next: build failure after merge of the pm tree Stephen Rothwell
2016-09-14 21:38 ` Rafael J. Wysocki
[not found] ` <CGME20160914213244epcas1p12dc9e18680105107404e1715ebcd40f8@epcas1p1.samsung.com>
2016-09-19 7:37 ` MyungJoo Ham
2016-09-19 16:12 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919161218.GA5073@kozik-book \
--to=krzk@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rjw@rjwysocki.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).