linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the crypto tree
@ 2016-11-29  0:55 Stephen Rothwell
  2016-11-29  7:08 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2016-11-29  0:55 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel

Hi Herbert,

After merging the crypto tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

ERROR: "simd_skcipher_free" [arch/arm/crypto/aes-arm-ce.ko] undefined!
ERROR: "simd_skcipher_create_compat" [arch/arm/crypto/aes-arm-ce.ko] undefined!
ERROR: "simd_skcipher_free" [arch/arm/crypto/aes-arm-bs.ko] undefined!
ERROR: "simd_skcipher_create_compat" [arch/arm/crypto/aes-arm-bs.ko] undefined!

Caused by commits

  da40e7a4ba4d ("crypto: aes-ce - Convert to skcipher")
  211f41af534a ("crypto: aesbs - Convert to skcipher")

Missing dependencies?

I have used the crypto tree from next-20161128 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2024-03-13  0:57 Stephen Rothwell
  2024-03-13  1:43 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2024-03-13  0:57 UTC (permalink / raw)
  To: Herbert Xu, Andrew Morton
  Cc: Eric Biggers, Barry Song, Linux Crypto List,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from mm/zswap.c:30:
include/crypto/acompress.h: In function 'acomp_is_async':
include/crypto/acompress.h:124:16: error: implicit declaration of function 'crypto_comp_alg_common'; did you mean 'crypto_tfm_alg_name'? [-Werror=implicit-function-declaration]
  124 |         return crypto_comp_alg_common(tfm)->base.cra_flags &
      |                ^~~~~~~~~~~~~~~~~~~~~~
      |                crypto_tfm_alg_name
include/crypto/acompress.h:124:43: error: invalid type argument of '->' (have 'int')
  124 |         return crypto_comp_alg_common(tfm)->base.cra_flags &
      |                                           ^~
include/crypto/acompress.h:126:1: error: control reaches end of non-void function [-Werror=return-type]
  126 | }
      | ^
cc1: some warnings being treated as errors

Caused by commit

  86464db929ca ("crypto: introduce: acomp_is_async to expose if comp drivers might sleep")

from the mm-unstable branch of the mm tree interacting with commit

  2beb81fbf0c0 ("crypto: remove CONFIG_CRYPTO_STATS")

from the crypto tree.

I have reverted these commits from the mm-unstable branch for today:

  86464db929ca ("crypto: introduce: acomp_is_async to expose if comp drivers might sleep")
  791f798331bc ("mm/zswap: remove the memcpy if acomp is not sleepable")

I will stop merging the -unstable parts of the mm tree from tomorrow.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2023-10-30  4:58 Stephen Rothwell
  2023-10-30  5:09 ` Stephen Rothwell
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2023-10-30  4:58 UTC (permalink / raw)
  To: Herbert Xu, David Miller, Jakub Kicinski, Paolo Abeni
  Cc: Networking, Linux Crypto List, Dmitry Safonov, Dmitry Safonov,
	Francesco Ruggeri, Salam Noureddine, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1640 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (powerpc
allyesconfig) failed like this:

net/ipv4/tcp_ao.c: In function 'tcp_ao_key_alloc':
net/ipv4/tcp_ao.c:1536:13: error: implicit declaration of function 'crypto_ahash_alignmask'; did you mean 'crypto_ahash_alg_name'? [-Werror=implicit-function-declaration]
 1536 |         if (crypto_ahash_alignmask(tfm) > TCP_AO_KEY_ALIGN) {
      |             ^~~~~~~~~~~~~~~~~~~~~~
      |             crypto_ahash_alg_name

Caused by commit

  0f8660c82b79 ("crypto: ahash - remove crypto_ahash_alignmask")

interacting with commit

  4954f17ddefc ("net/tcp: Introduce TCP_AO setsockopt()s")

from the net-next tree.

I have applied the following merge resolution patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 30 Oct 2023 15:54:37 +1100
Subject: [PATCH] fix up for "crypto: ahash - remove crypto_ahash_alignmask"

interacting with "net/tcp: Introduce TCP_AO setsockopt()s"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/ipv4/tcp_ao.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/net/ipv4/tcp_ao.c b/net/ipv4/tcp_ao.c
index 6a845e906a1d..d18562bb3184 100644
--- a/net/ipv4/tcp_ao.c
+++ b/net/ipv4/tcp_ao.c
@@ -1533,10 +1533,6 @@ static struct tcp_ao_key *tcp_ao_key_alloc(struct sock *sk,
 		goto err_free_pool;
 
 	tfm = crypto_ahash_reqtfm(hp.req);
-	if (crypto_ahash_alignmask(tfm) > TCP_AO_KEY_ALIGN) {
-		err = -EOPNOTSUPP;
-		goto err_pool_end;
-	}
 	digest_size = crypto_ahash_digestsize(tfm);
 	tcp_sigpool_end(&hp);
 
-- 
2.40.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2023-06-26  2:39 Stephen Rothwell
  2023-06-26 10:20 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2023-06-26  2:39 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Michael Ellerman, PowerPC, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ld: warning: discarding dynamic section .glink
ld: warning: discarding dynamic section .plt
ld: linkage table error against `sm2_compute_z_digest'
ld: stubs don't match calculated size
ld: can not build stubs: bad value
ld: crypto/asymmetric_keys/x509_public_key.o: in function `x509_get_sig_params':
x509_public_key.c:(.text+0x474): undefined reference to `sm2_compute_z_digest'

Possibly caused by commit

  e5221fa6a355 ("KEYS: asymmetric: Move sm2 code into x509_public_key")

This looks like it may be a compiler bug?  Maybe the deep ternary
expressions may be contributing to that? (cc'ing the ppc guys in case
they have any ideas.)

I have reverted that commit (and the following one) for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2023-05-22  0:52 Stephen Rothwell
  2023-05-22  5:15 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2023-05-22  0:52 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Huan Feng, Jia Jie Ho, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 2269 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/tty/serial/amba-pl011.c: In function 'pl011_sgbuf_init':
drivers/tty/serial/amba-pl011.c:379:30: error: implicit declaration of function 'phys_to_page'; did you mean 'pfn_to_page'? [-Werror=implicit-function-declaration]
  379 |         sg_set_page(&sg->sg, phys_to_page(dma_addr),
      |                              ^~~~~~~~~~~~
      |                              pfn_to_page
drivers/tty/serial/amba-pl011.c:379:30: error: passing argument 2 of 'sg_set_page' makes pointer from integer without a cast [-Werror=int-conversion]
  379 |         sg_set_page(&sg->sg, phys_to_page(dma_addr),
      |                              ^~~~~~~~~~~~~~~~~~~~~~
      |                              |
      |                              int
In file included from include/linux/kfifo.h:42,
                 from include/linux/tty_port.h:5,
                 from include/linux/tty.h:12,
                 from drivers/tty/serial/amba-pl011.c:25:
include/linux/scatterlist.h:136:69: note: expected 'struct page *' but argument is of type 'int'
  136 | static inline void sg_set_page(struct scatterlist *sg, struct page *page,
      |                                                        ~~~~~~~~~~~~~^~~~

Caused by commit

  42ef0e944b01 ("crypto: starfive - Add crypto engine support")

I applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 22 May 2023 10:47:38 +1000
Subject: [PATCH] fixup for "crypto: starfive - Add crypto engine support"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/crypto/starfive/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/starfive/Kconfig b/drivers/crypto/starfive/Kconfig
index be58d1473523..8795b2fddb4e 100644
--- a/drivers/crypto/starfive/Kconfig
+++ b/drivers/crypto/starfive/Kconfig
@@ -4,7 +4,7 @@
 
 config CRYPTO_DEV_JH7110
 	tristate "StarFive JH7110 cryptographic engine driver"
-	depends on SOC_STARFIVE || COMPILE_TEST
+	depends on SOC_STARFIVE
 	select CRYPTO_ENGINE
 	select CRYPTO_HMAC
 	select CRYPTO_SHA256
-- 
2.39.2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2023-04-11  0:48 Stephen Rothwell
  2023-04-11  2:22 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2023-04-11  0:48 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux Crypto List, Tom Zanussi, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from <command-line>:
In function 'setup_crypt_desc',
    inlined from 'get_crypt_desc' at drivers/crypto/intel/ixp4xx/ixp4xx_crypto.c:285:3:
include/linux/compiler_types.h:397:45: error: call to '__compiletime_assert_1010' declared with attribute error: BUILD_BUG_ON failed: sizeof(struct crypt_ctl) != 64
  397 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |                                             ^
include/linux/compiler_types.h:378:25: note: in definition of macro '__compiletime_assert'
  378 |                         prefix ## suffix();                             \
      |                         ^~~~~~
include/linux/compiler_types.h:397:9: note: in expansion of macro '_compiletime_assert'
  397 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
      |         ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
   39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
      |                                     ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
   50 |         BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
      |         ^~~~~~~~~~~~~~~~
drivers/crypto/intel/ixp4xx/ixp4xx_crypto.c:266:9: note: in expansion of macro 'BUILD_BUG_ON'
  266 |         BUILD_BUG_ON(sizeof(struct crypt_ctl) != 64);
      |         ^~~~~~~~~~~~

Caused by commit

  1bc7fdbf2677 ("crypto: ixp4xx - Move driver to drivers/crypto/intel/ixp4xx")

Presumably the addition of COMPILE_TEST was a bit optimistic. :-(

I have used the crypto tree from next-20230406 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2023-01-17  3:47 Stephen Rothwell
  0 siblings, 0 replies; 85+ messages in thread
From: Stephen Rothwell @ 2023-01-17  3:47 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Danny Tsen, Michael Ellerman, PowerPC, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (powerpc
pseries_le_defconfig) failed like this:

arch/powerpc/crypto/p10_aes_gcm.o: warning: objtool: .text+0x884: unannotated intra-function call
arch/powerpc/crypto/aesp8-ppc.o: warning: objtool: aes_p8_set_encrypt_key+0x44: unannotated intra-function call
ld: arch/powerpc/crypto/p10_aes_gcm.o: ABI version 1 is not compatible with ABI version 2 output
ld: failed to merge target specific data of file arch/powerpc/crypto/p10_aes_gcm.o

Caused by commit

  ca68a96c37eb ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")

I have applied the following hack for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 17 Jan 2023 14:41:10 +1100
Subject: [PATCH] crypto: p10-aes-gcm - only ABIv1 code has been implemented

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 arch/powerpc/crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
index db7d99383993..36928ad14a6b 100644
--- a/arch/powerpc/crypto/Kconfig
+++ b/arch/powerpc/crypto/Kconfig
@@ -97,6 +97,7 @@ config CRYPTO_AES_PPC_SPE
 config CRYPTO_P10_AES_GCM
 	tristate "Stitched AES/GCM acceleration support on P10+ CPU (PPC)"
 	depends on PPC64
+	depends on PPC64_ELF_ABI_V1
 	select CRYPTO_LIB_AES
 	select CRYPTO_ALGAPI
 	select CRYPTO_AEAD
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2023-01-16  0:29 Stephen Rothwell
  0 siblings, 0 replies; 85+ messages in thread
From: Stephen Rothwell @ 2023-01-16  0:29 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Danny Tsen, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ERROR: modpost: ".aes_p10_gcm_decrypt" [arch/powerpc/crypto/p10-aes-gcm-crypto.ko] undefined!
ERROR: modpost: ".aes_p10_gcm_encrypt" [arch/powerpc/crypto/p10-aes-gcm-crypto.ko] undefined!

Caused by commits

  cc40379b6e19 ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
  ca68a96c37eb ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")

I have used the crypto tree from next-20230113 for today.

BTW, that series seems to have been committed in the wrong order -
there are refrerences to files/functions before they are created.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2022-12-04 23:48 Stephen Rothwell
  2022-12-04 23:52 ` Stephen Rothwell
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2022-12-04 23:48 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux Crypto List, Michael Ellerman, PowerPC,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from include/crypto/algapi.h:10,
                 from include/crypto/internal/hash.h:11,
                 from arch/powerpc/crypto/sha1.c:15:
arch/powerpc/include/asm/cache.h:40:9: error: unknown type name 'u32'
   40 |         u32 size;
      |         ^~~
arch/powerpc/include/asm/cache.h:41:9: error: unknown type name 'u32'
   41 |         u32 line_size;
      |         ^~~

(and so on ... lots of errors)

Caused by commit

  e634ac4a8aaa ("crypto: api - Add crypto_tfm_ctx_dma")

It could be (easily) argued that arch/powerpc/include/asm/cache.h should
include linus/types.h, but it is also unusual to include an asm/... file
before all the linux/... files.

Anyway, I applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 5 Dec 2022 10:42:57 +1100
Subject: [PATCH] fix up for "crypto: api - Add crypto_tfm_ctx_dma"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/crypto/algapi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/crypto/algapi.h b/include/crypto/algapi.h
index 8722fd67f40a..fced47dbd306 100644
--- a/include/crypto/algapi.h
+++ b/include/crypto/algapi.h
@@ -7,13 +7,13 @@
 #ifndef _CRYPTO_ALGAPI_H
 #define _CRYPTO_ALGAPI_H
 
-#include <asm/cache.h>
 #include <linux/align.h>
 #include <linux/crypto.h>
 #include <linux/kconfig.h>
 #include <linux/list.h>
 #include <linux/types.h>
 
+#include <asm/cache.h>
 #include <asm/unaligned.h>
 
 /*
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2022-09-07  1:53 Stephen Rothwell
  0 siblings, 0 replies; 85+ messages in thread
From: Stephen Rothwell @ 2022-09-07  1:53 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Johnny Huang, Neal Liu, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 5441 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/device.h:15,
                 from include/linux/dma-mapping.h:7,
                 from drivers/crypto/aspeed/aspeed-hace.h:9,
                 from drivers/crypto/aspeed/aspeed-hace-hash.c:6:
drivers/crypto/aspeed/aspeed-hace-hash.c: In function 'aspeed_ahash_dma_prepare_sg':
drivers/crypto/aspeed/aspeed-hace-hash.c:10:28: error: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'size_t' {aka 'long unsigned int'} [-Werror=format=]
   10 |         dev_info((h)->dev, "%s() " fmt, __func__, ##__VA_ARGS__)
      |                            ^~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
  110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
      |                              ^~~
include/linux/dev_printk.h:150:58: note: in expansion of macro 'dev_fmt'
  150 |         dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
      |                                                          ^~~~~~~
drivers/crypto/aspeed/aspeed-hace-hash.c:10:9: note: in expansion of macro 'dev_info'
   10 |         dev_info((h)->dev, "%s() " fmt, __func__, ##__VA_ARGS__)
      |         ^~~~~~~~
drivers/crypto/aspeed/aspeed-hace-hash.c:188:9: note: in expansion of macro 'AHASH_DBG'
  188 |         AHASH_DBG(hace_dev, "%s:0x%x, %s:0x%x, %s:0x%x, %s:0x%x\n",
      |         ^~~~~~~~~
drivers/crypto/aspeed/aspeed-hace-hash.c: In function 'aspeed_hace_ahash_trigger':
drivers/crypto/aspeed/aspeed-hace-hash.c:10:28: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' {aka 'long long unsigned int'} [-Werror=format=]
   10 |         dev_info((h)->dev, "%s() " fmt, __func__, ##__VA_ARGS__)
      |                            ^~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
  110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
      |                              ^~~
include/linux/dev_printk.h:150:58: note: in expansion of macro 'dev_fmt'
  150 |         dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
      |                                                          ^~~~~~~
drivers/crypto/aspeed/aspeed-hace-hash.c:10:9: note: in expansion of macro 'dev_info'
   10 |         dev_info((h)->dev, "%s() " fmt, __func__, ##__VA_ARGS__)
      |         ^~~~~~~~
drivers/crypto/aspeed/aspeed-hace-hash.c:327:9: note: in expansion of macro 'AHASH_DBG'
  327 |         AHASH_DBG(hace_dev, "src_dma:0x%x, digest_dma:0x%x, length:0x%x\n",
      |         ^~~~~~~~~
drivers/crypto/aspeed/aspeed-hace-hash.c:10:28: error: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'dma_addr_t' {aka 'long long unsigned int'} [-Werror=format=]
   10 |         dev_info((h)->dev, "%s() " fmt, __func__, ##__VA_ARGS__)
      |                            ^~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
  110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
      |                              ^~~
include/linux/dev_printk.h:150:58: note: in expansion of macro 'dev_fmt'
  150 |         dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
      |                                                          ^~~~~~~
drivers/crypto/aspeed/aspeed-hace-hash.c:10:9: note: in expansion of macro 'dev_info'
   10 |         dev_info((h)->dev, "%s() " fmt, __func__, ##__VA_ARGS__)
      |         ^~~~~~~~
drivers/crypto/aspeed/aspeed-hace-hash.c:327:9: note: in expansion of macro 'AHASH_DBG'
  327 |         AHASH_DBG(hace_dev, "src_dma:0x%x, digest_dma:0x%x, length:0x%x\n",
      |         ^~~~~~~~~
drivers/crypto/aspeed/aspeed-hace-hash.c:10:28: error: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'size_t' {aka 'long unsigned int'} [-Werror=format=]
   10 |         dev_info((h)->dev, "%s() " fmt, __func__, ##__VA_ARGS__)
      |                            ^~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
  110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
      |                              ^~~
include/linux/dev_printk.h:150:58: note: in expansion of macro 'dev_fmt'
  150 |         dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
      |                                                          ^~~~~~~
drivers/crypto/aspeed/aspeed-hace-hash.c:10:9: note: in expansion of macro 'dev_info'
   10 |         dev_info((h)->dev, "%s() " fmt, __func__, ##__VA_ARGS__)
      |         ^~~~~~~~
drivers/crypto/aspeed/aspeed-hace-hash.c:327:9: note: in expansion of macro 'AHASH_DBG'
  327 |         AHASH_DBG(hace_dev, "src_dma:0x%x, digest_dma:0x%x, length:0x%x\n",
      |         ^~~~~~~~~

Caused by commit

  108713a713c7 ("crypto: aspeed - Add HACE hash driver")

Exposed by commits

  2be570849efc ("crypto: aspeed - fix build module error")
  31b39755e325 ("crypto: aspeed - Enable compile testing")

I have used the crypto tree from next-20220901 again today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2022-09-06  1:30 Stephen Rothwell
  0 siblings, 0 replies; 85+ messages in thread
From: Stephen Rothwell @ 2022-09-06  1:30 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: "aspeed_register_hace_hash_algs" [drivers/crypto/aspeed/aspeed_crypto.ko] undefined!
ERROR: modpost: "aspeed_unregister_hace_crypto_algs" [drivers/crypto/aspeed/aspeed_crypto.ko] undefined!
ERROR: modpost: "aspeed_register_hace_crypto_algs" [drivers/crypto/aspeed/aspeed_crypto.ko] undefined!
ERROR: modpost: "aspeed_unregister_hace_hash_algs" [drivers/crypto/aspeed/aspeed_crypto.ko] undefined!

Exposed by commit

  31b39755e325 ("crypto: aspeed - Enable compile testing")

I have used the crypto tree from next-20220901 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2022-05-09 11:10 Stephen Rothwell
  2022-05-09 12:26 ` Masahiro Yamada
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2022-05-09 11:10 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Masahiro Yamada, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1826 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (powerpc
pseries_le_defconfig) failed like this:

ccnI8W1t.s: Assembler messages:
ccnI8W1t.s: Error: .size expression for aes_p8_set_encrypt_key does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for .aes_p8_set_encrypt_key does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for aes_p8_set_decrypt_key does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for .aes_p8_set_decrypt_key does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for aes_p8_encrypt does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for .aes_p8_encrypt does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for aes_p8_decrypt does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for .aes_p8_decrypt does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for aes_p8_cbc_encrypt does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for .aes_p8_cbc_encrypt does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for aes_p8_ctr32_encrypt_blocks does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for .aes_p8_ctr32_encrypt_blocks does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for aes_p8_xts_encrypt does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for .aes_p8_xts_encrypt does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for aes_p8_xts_decrypt does not evaluate to a constant
ccnI8W1t.s: Error: .size expression for .aes_p8_xts_decrypt does not evaluate to a constant

Caused by commit

  b52455a73db9 ("crypto: vmx - Align the short log with Makefile cleanups")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2021-09-27  4:32 Stephen Rothwell
  0 siblings, 0 replies; 85+ messages in thread
From: Stephen Rothwell @ 2021-09-27  4:32 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (powerpc
ppc44x_defconfig) failed like this:

ERROR: modpost: "crypto_boot_test_finished" [crypto/crypto_algapi.ko] undefined!

Caused by commit

  adad556efcdd ("crypto: api - Fix built-in testing dependency failures")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2020-04-21  5:12 Stephen Rothwell
  2020-04-22 13:33 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2020-04-21  5:12 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Shukun Tan,
	Zhou Wang, Zaibo Xu

[-- Attachment #1: Type: text/plain, Size: 3041 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (powerpc
allyesconfig) failed like this:

WARNING: unmet direct dependencies detected for CRYPTO_DEV_HISI_QM
  Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && (ARM64 || COMPILE_TEST [=y]) && PCI [=y] && PCI_MSI [=y] && (UACCE [=y] || UACCE [=y]=n) && ACPI
  Selected by [y]:
  - CRYPTO_DEV_HISI_SEC2 [=y] && CRYPTO [=y] && CRYPTO_HW [=y] && PCI [=y] && PCI_MSI [=y] && (UACCE [=y] || UACCE [=y]=n) && (ARM64 || COMPILE_TEST [=y] && 64BIT [=y])
  - CRYPTO_DEV_HISI_ZIP [=y] && CRYPTO [=y] && CRYPTO_HW [=y] && PCI [=y] && PCI_MSI [=y] && (ARM64 || COMPILE_TEST [=y] && 64BIT [=y]) && (!CPU_BIG_ENDIAN [=y] || COMPILE_TEST [=y]) && (UACCE [=y] || UACCE [=y]=n)
  - CRYPTO_DEV_HISI_HPRE [=y] && CRYPTO [=y] && CRYPTO_HW [=y] && PCI [=y] && PCI_MSI [=y] && (UACCE [=y] || UACCE [=y]=n) && (ARM64 || COMPILE_TEST [=y] && 64BIT [=y])

drivers/crypto/hisilicon/qm.c: In function 'qm_soft_reset':
drivers/crypto/hisilicon/qm.c:2915:7: error: implicit declaration of function 'acpi_evaluate_integer'; did you mean 'acpi_evaluate_object'? [-Werror=implicit-function-declaration]
 2915 |   s = acpi_evaluate_integer(ACPI_HANDLE(&pdev->dev),
      |       ^~~~~~~~~~~~~~~~~~~~~
      |       acpi_evaluate_object

Caused by commit

  6c6dd5802c2d ("crypto: hisilicon/qm - add controller reset interface")

Unfortunately not fixed by commit

  f88480e300ac ("crypto: hisilicon/qm - fix build failure with ACPI off")

[the moral is "don't select symbols that have dependencies" :-( ]

I have added the following patch for today

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 21 Apr 2020 14:56:49 +1000
Subject: [PATCH] crypto: hisilicon/qm add more ACPI dependencies

due to the selects of CRYPTO_DEV_HISI_QM which now depends on ACPI

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/crypto/hisilicon/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
index 99e962e39f36..9c3b3ca815e6 100644
--- a/drivers/crypto/hisilicon/Kconfig
+++ b/drivers/crypto/hisilicon/Kconfig
@@ -29,6 +29,7 @@ config CRYPTO_DEV_HISI_SEC2
 	depends on PCI && PCI_MSI
 	depends on UACCE || UACCE=n
 	depends on ARM64 || (COMPILE_TEST && 64BIT)
+	depends on ACPI
 	help
 	  Support for HiSilicon SEC Engine of version 2 in crypto subsystem.
 	  It provides AES, SM4, and 3DES algorithms with ECB
@@ -53,6 +54,7 @@ config CRYPTO_DEV_HISI_ZIP
 	depends on ARM64 || (COMPILE_TEST && 64BIT)
 	depends on !CPU_BIG_ENDIAN || COMPILE_TEST
 	depends on UACCE || UACCE=n
+	depends on ACPI
 	select CRYPTO_DEV_HISI_QM
 	help
 	  Support for HiSilicon ZIP Driver
@@ -62,6 +64,7 @@ config CRYPTO_DEV_HISI_HPRE
 	depends on PCI && PCI_MSI
 	depends on UACCE || UACCE=n
 	depends on ARM64 || (COMPILE_TEST && 64BIT)
+	depends on ACPI
 	select CRYPTO_DEV_HISI_QM
 	select CRYPTO_DH
 	select CRYPTO_RSA
-- 
2.25.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2020-04-17  3:40 Stephen Rothwell
  2020-04-17  4:00 ` Shukun Tan
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2020-04-17  3:40 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Shukun Tan,
	Zhou Wang, Zaibo Xu, Yang Shen, Hui Tang

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/crypto/hisilicon/qm.c: In function 'qm_soft_reset':
drivers/crypto/hisilicon/qm.c:2915:7: error: implicit declaration of function 'acpi_evaluate_integer'; did you mean 'acpi_evaluate_object'? [-Werror=implicit-function-declaration]
 2915 |   s = acpi_evaluate_integer(ACPI_HANDLE(&pdev->dev),
      |       ^~~~~~~~~~~~~~~~~~~~~
      |       acpi_evaluate_object

Caused by commit

  6c6dd5802c2d ("crypto: hisilicon/qm - add controller reset interface")

I have reverted the following commits for today

f037fc5f93f4 crypto: hisilicon/qm - stop qp by judging sq and cq tail
141876c252a4 crypto: hisilicon/sec2 - add controller reset support for SEC2
1f5c9f34f0cc crypto: hisilicon/hpre - add controller reset support for HPRE
84c9b7802b02 crypto: hisilicon/zip - add controller reset support for zip
6c6dd5802c2d crypto: hisilicon/qm - add controller reset interface

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2019-08-12  3:21 Stephen Rothwell
  2019-08-12  6:53 ` Zhou Wang
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2019-08-12  3:21 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto List
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Zhou Wang,
	Shiju Jose, Kenneth Lee, Hao Fang, Jonathan Cameron, John Garry

[-- Attachment #1: Type: text/plain, Size: 2467 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/crypto/hisilicon/qm.c: Assembler messages:
drivers/crypto/hisilicon/qm.c:334: Error: no such instruction: `ldp %rdx,%rcx,%bl'
drivers/crypto/hisilicon/qm.c:335: Error: no such instruction: `stp %rdx,%rcx,%al'
drivers/crypto/hisilicon/qm.c:336: Error: number of operands mismatch for `ds'

Caused by commit

  62c455ca853e ("crypto: hisilicon - add HiSilicon ZIP accelerator support")

I also got the following warnings:

WARNING: unmet direct dependencies detected for CRYPTO_DEV_HISI_QM
  Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64 && PCI [=y] && PCI_MSI [=y]
  Selected by [m]:
  - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]

WARNING: unmet direct dependencies detected for CRYPTO_HISI_SGL
  Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64
  Selected by [m]:
  - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]

WARNING: unmet direct dependencies detected for CRYPTO_DEV_HISI_QM
  Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64 && PCI [=y] && PCI_MSI [=y]
  Selected by [m]:
  - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]

WARNING: unmet direct dependencies detected for CRYPTO_HISI_SGL
  Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64
  Selected by [m]:
  - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]

WARNING: unmet direct dependencies detected for CRYPTO_DEV_HISI_QM
  Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64 && PCI [=y] && PCI_MSI [=y]
  Selected by [m]:
  - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]

WARNING: unmet direct dependencies detected for CRYPTO_HISI_SGL
  Depends on [n]: CRYPTO [=y] && CRYPTO_HW [=y] && ARM64
  Selected by [m]:
  - CRYPTO_DEV_HISI_ZIP [=m] && CRYPTO [=y] && CRYPTO_HW [=y]
drivers/crypto/hisilicon/sgl.c: In function 'hisi_acc_sg_buf_map_to_hw_sgl':
drivers/crypto/hisilicon/sgl.c:181:14: warning: 'curr_sgl_dma' may be used uninitialized in this function [-Wmaybe-uninitialized]
  *hw_sgl_dma = curr_sgl_dma;
  ~~~~~~~~~~~~^~~~~~~~~~~~~~

This latter from commit

  dfed0098ab91 ("crypto: hisilicon - add hardware SGL support")

I have disabled CRYPTO_DEV_HISI_ZIP for now.  You should not select
CONFIG options that have dependencies (without also depending on the
same things and being very careful).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2019-08-05  4:57 Stephen Rothwell
  2019-08-05  5:37 ` Chuhong Yuan
  2019-08-08  1:52 ` Stephen Rothwell
  0 siblings, 2 replies; 85+ messages in thread
From: Stephen Rothwell @ 2019-08-05  4:57 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Chuhong Yuan

[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]

Hi all,

After merging the crypto tree, today's linux-next build (sparc64
defconfig) failed like this:

drivers/char/hw_random/n2-drv.c: In function 'n2rng_probe':
drivers/char/hw_random/n2-drv.c:771:29: error: 'pdev' undeclared (first use in this function); did you mean 'cdev'?
  err = devm_hwrng_register(&pdev->dev, &np->hwrng);
                             ^~~~
                             cdev
drivers/char/hw_random/n2-drv.c:771:29: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit

  3e75241be808 ("hwrng: drivers - Use device-managed registration API")

I applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 5 Aug 2019 14:49:59 +1000
Subject: [PATCH] hwrng: fix typo in n2-drv.c

Fixes: 3e75241be808 ("hwrng: drivers - Use device-managed registration API")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/char/hw_random/n2-drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
index 2d256b3470db..73e408146420 100644
--- a/drivers/char/hw_random/n2-drv.c
+++ b/drivers/char/hw_random/n2-drv.c
@@ -768,7 +768,7 @@ static int n2rng_probe(struct platform_device *op)
 	np->hwrng.data_read = n2rng_data_read;
 	np->hwrng.priv = (unsigned long) np;
 
-	err = devm_hwrng_register(&pdev->dev, &np->hwrng);
+	err = devm_hwrng_register(&op->dev, &np->hwrng);
 	if (err)
 		goto out_hvapi_unregister;
 
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2018-10-08  1:03 Stephen Rothwell
  2018-10-08  5:54 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2018-10-08  1:03 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Ard Biesheuvel

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "crypto_fpu_exit" [arch/x86/crypto/aesni-intel.ko] undefined!
ERROR: "crypto_fpu_init" [arch/x86/crypto/aesni-intel.ko] undefined!

Caused by commit

  944585a64f5e ("crypto: x86/aes-ni - remove special handling of AES in PCBC mode")

I have used the version of the crypto tree from next-20181005 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2018-05-29  9:08 Stephen Rothwell
  2018-05-29 10:16 ` Ondrej Mosnáček
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2018-05-29  9:08 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Ondrej Mosnacek

[-- Attachment #1: Type: text/plain, Size: 2266 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (powerpc
allyesconfig) failed like this:

/home/sfr/next/next/crypto/morus640_glue.c:24:10: fatal error: asm/fpu/api.h: No such file or directory
 #include <asm/fpu/api.h>
          ^~~~~~~~~~~~~~~
/home/sfr/next/next/crypto/morus1280_glue.c:24:10: fatal error: asm/fpu/api.h: No such file or directory
 #include <asm/fpu/api.h>
          ^~~~~~~~~~~~~~~

Caused by commit

  56e8e57fc3a7 ("crypto: morus - Add common SIMD glue code for MORUS")

I have marked them as broken for now:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 29 May 2018 18:59:17 +1000
Subject: [PATCH] crypto: make common SIMD glue code for MORUS as BROKEN for
 now

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 crypto/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 75f5efde9aa3..ad69785dc9d3 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -342,6 +342,7 @@ config CRYPTO_MORUS640
 
 config CRYPTO_MORUS640_GLUE
 	tristate "MORUS-640 AEAD algorithm (glue for SIMD optimizations)"
+	depends on BROKEN
 	select CRYPTO_AEAD
 	select CRYPTO_CRYPTD
 	help
@@ -351,6 +352,7 @@ config CRYPTO_MORUS640_GLUE
 config CRYPTO_MORUS640_SSE2
 	tristate "MORUS-640 AEAD algorithm (x86_64 SSE2 implementation)"
 	depends on X86 && 64BIT
+	depends on BROKEN
 	select CRYPTO_AEAD
 	select CRYPTO_MORUS640_GLUE
 	help
@@ -364,6 +366,7 @@ config CRYPTO_MORUS1280
 
 config CRYPTO_MORUS1280_GLUE
 	tristate "MORUS-1280 AEAD algorithm (glue for SIMD optimizations)"
+	depends on BROKEN
 	select CRYPTO_AEAD
 	select CRYPTO_CRYPTD
 	help
@@ -373,6 +376,7 @@ config CRYPTO_MORUS1280_GLUE
 config CRYPTO_MORUS1280_SSE2
 	tristate "MORUS-1280 AEAD algorithm (x86_64 SSE2 implementation)"
 	depends on X86 && 64BIT
+	depends on BROKEN
 	select CRYPTO_AEAD
 	select CRYPTO_MORUS1280_GLUE
 	help
@@ -382,6 +386,7 @@ config CRYPTO_MORUS1280_SSE2
 config CRYPTO_MORUS1280_AVX2
 	tristate "MORUS-1280 AEAD algorithm (x86_64 AVX2 implementation)"
 	depends on X86 && 64BIT
+	depends on BROKEN
 	select CRYPTO_AEAD
 	select CRYPTO_MORUS1280_GLUE
 	help
-- 
2.17.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2017-11-06  0:25 Stephen Rothwell
  2017-11-06  5:40 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2017-11-06  0:25 UTC (permalink / raw)
  To: Herbert Xu
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Boris BREZILLON

Hi Herbert,

After merging the crypto tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/crypto/marvell/marvell-cesa: struct platform_device_id is 24 bytes.  The last of 1 is:
0x6d 0x76 0x5f 0x63 0x72 0x79 0x70 0x74 0x6f 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 
FATAL: drivers/crypto/marvell/marvell-cesa: struct platform_device_id is not terminated with a NULL entry!

Caused by commit

  7b0c3d693ce6 ("crypto: marvell - Add a platform_device_id table")

I have used the crypto tree from next-20171103 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2016-07-20  7:46 Stephen Rothwell
  2016-07-20 14:32 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2016-07-20  7:46 UTC (permalink / raw)
  To: Herbert Xu
  Cc: linux-next, linux-kernel, Paulo Flabiano Smorigo, Leonidas S. Barbosa

Hi all,

After merging the dax-misc tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/crypto/vmx/aesp8-ppc.S: Assembler messages:
drivers/crypto/vmx/aesp8-ppc.S:2036: Error: symbol `.aes_p8_xts_decrypt' is already defined

Caused by commit

  11c6e16ee13a ("crypto: vmx - Adding asm subroutines for XTS")

I have reverted that commit (and commit c07f5d3da643 ("crypto: vmx -
Adding support for XTS")) for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2016-06-24  6:20 Stephen Rothwell
  2016-06-24 13:33 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2016-06-24  6:20 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Salvatore Benedetto

Hi Herbert,

After merging the crypto tree, today's linux-next build (powerpc
allyesconfig) failed like this:

net/built-in.o: In function `.ecdh_shared_secret':
(.text+0x4ad8d0): multiple definition of `.ecdh_shared_secret'
crypto/built-in.o:(.text+0x113f0): first defined here
net/built-in.o:(.opd+0x430e0): multiple definition of `ecdh_shared_secret'
crypto/built-in.o:(.opd+0x1d40): first defined here

Caused by commit

  3c4b23901a0c ("crypto: ecdh - Add ECDH software support")

The other definition is in net/bluetooth/ecc.c

I added the following patch for today (probably a better name could
be chosen):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 24 Jun 2016 16:13:37 +1000
Subject: [PATCH] crypto: make ecdh_shared_secret unique

There is another ecdh_shared_secret in net/bluetooth/ecc.c

Fixes: 3c4b23901a0c ("crypto: ecdh - Add ECDH software support")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 crypto/ecc.c  | 2 +-
 crypto/ecc.h  | 6 +++---
 crypto/ecdh.c | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/crypto/ecc.c b/crypto/ecc.c
index 9aedec6bbe72..414c78a9c214 100644
--- a/crypto/ecc.c
+++ b/crypto/ecc.c
@@ -966,7 +966,7 @@ out:
 	return ret;
 }
 
-int ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits,
+int crypto_ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits,
 		       const u8 *private_key, unsigned int private_key_len,
 		       const u8 *public_key, unsigned int public_key_len,
 		       u8 *secret, unsigned int secret_len)
diff --git a/crypto/ecc.h b/crypto/ecc.h
index b5db4b989f3c..663d598c7406 100644
--- a/crypto/ecc.h
+++ b/crypto/ecc.h
@@ -60,7 +60,7 @@ int ecdh_make_pub_key(const unsigned int curve_id, unsigned int ndigits,
 		      u8 *public_key, unsigned int public_key_len);
 
 /**
- * ecdh_shared_secret() - Compute a shared secret
+ * crypto_ecdh_shared_secret() - Compute a shared secret
  *
  * @curve_id:		id representing the curve to use
  * @private_key:	private key of part A
@@ -70,13 +70,13 @@ int ecdh_make_pub_key(const unsigned int curve_id, unsigned int ndigits,
  * @secret:		buffer for storing the calculated shared secret
  * @secret_len:		length of the secret buffer
  *
- * Note: It is recommended that you hash the result of ecdh_shared_secret
+ * Note: It is recommended that you hash the result of crypto_ecdh_shared_secret
  * before using it for symmetric encryption or HMAC.
  *
  * Returns 0 if the shared secret was generated successfully, a negative value
  * if an error occurred.
  */
-int ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits,
+int crypto_ecdh_shared_secret(unsigned int curve_id, unsigned int ndigits,
 		       const u8 *private_key, unsigned int private_key_len,
 		       const u8 *public_key, unsigned int public_key_len,
 		       u8 *secret, unsigned int secret_len);
diff --git a/crypto/ecdh.c b/crypto/ecdh.c
index d3a9eeca4b32..3de289806d67 100644
--- a/crypto/ecdh.c
+++ b/crypto/ecdh.c
@@ -79,7 +79,7 @@ static int ecdh_compute_value(struct kpp_request *req)
 		if (copied != 2 * nbytes)
 			return -EINVAL;
 
-		ret = ecdh_shared_secret(ctx->curve_id, ctx->ndigits,
+		ret = crypto_ecdh_shared_secret(ctx->curve_id, ctx->ndigits,
 					 (const u8 *)ctx->private_key, nbytes,
 					 (const u8 *)ctx->public_key, 2 * nbytes,
 					 (u8 *)ctx->shared_secret, nbytes);
-- 
2.8.1

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply related	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2016-02-17  1:26 Stephen Rothwell
  0 siblings, 0 replies; 85+ messages in thread
From: Stephen Rothwell @ 2016-02-17  1:26 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Stephan Mueller

Hi Herbert,

After merging the crypto tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

arch/arm/crypto/aesbs-glue.c: In function 'aesbs_xts_set_key':
arch/arm/crypto/aesbs-glue.c:94:8: error: implicit declaration of function 'xts_check_key' [-Werror=implicit-function-declaration]
  err = xts_check_key(tfm, in_key, key_len);
        ^
arch/arm/crypto/aes-ce-glue.c: In function 'xts_set_key':
arch/arm/crypto/aes-ce-glue.c:155:8: error: implicit declaration of function 'xts_check_key' [-Werror=implicit-function-declaration]
  ret = xts_check_key(tfm, in_key, key_len);
        ^

Caused by commit

  28856a9e52c7 ("crypto: xts - consolidate sanity check for keys")

Presumably a missing include.

I have used the crypto tree from next-20160216 for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2015-10-15  1:37 Stephen Rothwell
  2015-10-15  2:01 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2015-10-15  1:37 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Daniel Thompson, Linus Walleij

Hi Herbert,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_runtime_suspend':
drivers/char/hw_random/stm32-rng.c:163:51: error: 'pdev' undeclared (first use in this function)
  struct stm32_rng_private *priv = dev_get_drvdata(pdev);
                                                   ^
drivers/char/hw_random/stm32-rng.c:163:51: note: each undeclared identifier is reported only once for each function it appears in
drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_runtime_resume':
drivers/char/hw_random/stm32-rng.c:172:51: error: 'pdev' undeclared (first use in this function)
  struct stm32_rng_private *priv = dev_get_drvdata(pdev);
                                                   ^

Caused by commit

  c6a97c42e399 ("Add support for STMicroelectronics STM32 random number generator.")

I have used the crypto tree from next-20151013 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2015-08-05  6:49 Stephen Rothwell
  2015-08-05  7:28 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2015-08-05  6:49 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel

Hi Herbert,

After merging the crypto tree, today's linux-next build (sparc64
defconfig) failed like this:

crypto/built-in.o: In function `crypto_authenc_exit_tfm':
authenc.c:(.text+0x11d1c): undefined reference to `crypto_put_default_null_skcipher'
crypto/built-in.o: In function `crypto_authenc_init_tfm':
authenc.c:(.text+0x11d7c): undefined reference to `crypto_get_default_null_skcipher'

Caused by commit

  92d95ba91772 ("crypto: authenc - Convert to new AEAD interface")

Those symbols depend on CONFIG_CRYPTO_NULL which is set to 'm' for
this build.

I have added this fix patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 5 Aug 2015 16:41:48 +1000
Subject: [PATCH] crypto: authenc - select CRYPTO_NULL

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 354bb692c964..ac7cc6226e61 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -200,6 +200,7 @@ config CRYPTO_AUTHENC
 	select CRYPTO_BLKCIPHER
 	select CRYPTO_MANAGER
 	select CRYPTO_HASH
+	select CRYPTO_NULL
 	help
 	  Authenc: Combined mode wrapper for IPsec.
 	  This is required for IPSec.
-- 
2.5.0

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply related	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2015-06-20  6:35 Stephen Rothwell
  0 siblings, 0 replies; 85+ messages in thread
From: Stephen Rothwell @ 2015-06-20  6:35 UTC (permalink / raw)
  To: Herbert Xu, Gustavo Padovan
  Cc: linux-next, linux-kernel, Simon Vincent, Marcel Holtmann

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

net/mac802154/llsec.c: In function 'llsec_do_encrypt_auth':
/scratch/sfr/next/net/mac802154/llsec.c:675:15: error: 'dst' undeclared (first use in this function)
   sg_init_one(dst, skb_put(skb, authlen), authlen);
               ^

Caused by commit:

  7df416952e1e ("Merge remote-tracking branch 'crypto/master'")

I made a small mistake by leaving that line in when I resolved the
conflict.  I have now removed that line.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2015-05-28 11:40 Stephen Rothwell
  2015-05-28 13:08 ` Stephan Mueller
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2015-05-28 11:40 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Stephan Mueller

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (powerpc allyesconfig)
failed like this:

crypto/jitterentropy.c: In function 'jent_get_nstime':
crypto/jitterentropy.c:135:5: error: implicit declaration of function 'timekeeping_valid_for_hres' [-Werror=implicit-function-declaration]
     (0 == timekeeping_valid_for_hres()) &&
     ^

Caused by commit bb5530e40824 ("crypto: jitterentropy - add
jitterentropy RNG").

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2015-03-17  2:01 Stephen Rothwell
  2015-03-17 11:11 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2015-03-17  2:01 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, James Hartley, Andrew Bresticker

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/crypto/img-hash.c: At top level:
drivers/crypto/img-hash.c:878:1: error: expected ',' or ';' before 'static'
 static int img_hash_probe(struct platform_device *pdev)
 ^

Caused by commit d358f1abbf71 ("crypto: img-hash - Add Imagination
Technologies hw hash accelerator").

I have used the crypto tree from next-20150316 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2014-07-24  3:08 Stephen Rothwell
  2014-07-24  7:04 ` Randy Dunlap
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2014-07-24  3:08 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Tom Lendacky

[-- Attachment #1: Type: text/plain, Size: 6200 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (powerpc
ppc64_defconfig) produced these messages:

fs/sysfs/Kconfig:1:error: recursive dependency detected!
fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
drivers/input/Kconfig:8:	symbol INPUT is selected by VT
drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS

The x86_64 allmodconfig build produced these:

scripts/kconfig/conf --allmodconfig Kconfig
drivers/usb/Kconfig:41:error: recursive dependency detected!
drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
drivers/input/Kconfig:8:	symbol INPUT is selected by VT
drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB

And then the arm multi_v7_defconfig build produced these:

drivers/usb/Kconfig:41:error: recursive dependency detected!
drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
drivers/input/Kconfig:8:	symbol INPUT is selected by VT
drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
#
# configuration written to .config
#
WITHOUT_CCACHE: 
WITHOUT_DISTCC: 
ARCH=arm
CCVER=4.9.0
drivers/usb/Kconfig:41:error: recursive dependency detected!
drivers/usb/Kconfig:41:	symbol USB is selected by MOUSE_APPLETOUCH
drivers/input/mouse/Kconfig:162:	symbol MOUSE_APPLETOUCH depends on INPUT
drivers/input/Kconfig:8:	symbol INPUT is selected by VT
drivers/tty/Kconfig:12:	symbol VT is selected by FB_STI
drivers/video/fbdev/Kconfig:652:	symbol FB_STI depends on FB
drivers/video/fbdev/Kconfig:5:	symbol FB is selected by DRM_KMS_FB_HELPER
drivers/gpu/drm/Kconfig:39:	symbol DRM_KMS_FB_HELPER is selected by DRM_KMS_CMA_HELPER
drivers/gpu/drm/Kconfig:74:	symbol DRM_KMS_CMA_HELPER is selected by DRM_TILCDC
drivers/gpu/drm/tilcdc/Kconfig:1:	symbol DRM_TILCDC depends on OF
drivers/of/Kconfig:4:	symbol OF is selected by CRYPTO_DEV_CCP_DD
drivers/crypto/ccp/Kconfig:1:	symbol CRYPTO_DEV_CCP_DD depends on CRYPTO
crypto/Kconfig:15:	symbol CRYPTO is selected by IP_SCTP
net/sctp/Kconfig:5:	symbol IP_SCTP is selected by DLM
fs/dlm/Kconfig:1:	symbol DLM depends on SYSFS
fs/sysfs/Kconfig:1:	symbol SYSFS is selected by AT91_ADC
drivers/iio/adc/Kconfig:110:	symbol AT91_ADC depends on IIO
drivers/iio/Kconfig:5:	symbol IIO is selected by RTC_DRV_HID_SENSOR_TIME
drivers/rtc/Kconfig:1370:	symbol RTC_DRV_HID_SENSOR_TIME depends on USB_HID
drivers/hid/usbhid/Kconfig:4:	symbol USB_HID depends on USB
*
* Restart config...
*
*
* USB HID Boot Protocol drivers
*
USB HIDBP Keyboard (simple Boot) support (USB_KBD) [N/m/y/?] (NEW) aborted!

Console input/output is redirected. Run 'make oldconfig' to update configuration.


I am not sure exactly what caused all this, but it is probably commit
126ae9adc1ec ("crypto: ccp - Base AXI DMA cache settings on device
tree").

I have used the version of the crypto tree from next-20140723 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2014-06-23  1:49 Stephen Rothwell
  2014-06-23 12:27 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2014-06-23  1:49 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Tadeusz Struk

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:


drivers/crypto/qat/qat_dh895xcc/adf_dh895xcc_hw_data.c:47:31: fatal error: adf_accel_devices.h: No such file or directory
 #include <adf_accel_devices.h>
                               ^
drivers/crypto/qat/qat_dh895xcc/adf_isr.c:54:31: fatal error: adf_accel_devices.h: No such file or directory
 #include <adf_accel_devices.h>
                               ^
drivers/crypto/qat/qat_dh895xcc/adf_drv.c:60:31: fatal error: adf_accel_devices.h: No such file or directory
 #include <adf_accel_devices.h>
                               ^

Caused by commit 7afa232e76ce ("crypto: qat - Intel(R) QAT DH895xcc
accelerator").

I have used the crypto tree from next-20140620 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2013-12-06  0:45 Stephen Rothwell
  0 siblings, 0 replies; 85+ messages in thread
From: Stephen Rothwell @ 2013-12-06  0:45 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Cesar Eduardo Barros

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

crypto/memneq.c: In function '__crypto_memneq_16':
crypto/memneq.c:145:2: warning: no return statement in function returning non-void [-Wreturn-type]
crypto/memneq.c: At top level:
crypto/memneq.c:147:2: error: expected identifier or '(' before 'return'
crypto/memneq.c:148:1: error: expected identifier or '(' before '}' token

Caused by commit fe8c8a126806 ("crypto: more robust crypto_memneq").

I have used the crypto tree from next-20131205 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread
* linux-next: build failure after merge of the crypto tree
@ 2013-05-21  1:45 Stephen Rothwell
  2013-05-24  9:57 ` Herbert Xu
  0 siblings, 1 reply; 85+ messages in thread
From: Stephen Rothwell @ 2013-05-21  1:45 UTC (permalink / raw)
  To: Herbert Xu; +Cc: linux-next, linux-kernel, Tim Chen

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

Hi Herbert,

After merging the crypto tree, today's linux-next build (x86_64
allmodconfig) failed like this:

arch/x86/crypto/crct10dif-pclmul_glue.c: In function 'crct10dif_intel_mod_init':
arch/x86/crypto/crct10dif-pclmul_glue.c:140:3: error: implicit declaration of function 'crc_t10dif_update_lib' [-Werror=implicit-function-declaration]
   crc_t10dif_update_lib();
   ^
cc1: some warnings being treated as errors

Caused by commit b85ed9f056ee ("crypto: crct10dif - Glue code to cast
accelerated CRCT10DIF assembly as a crypto transform").

I have used the version of the crypto tree from next-20130520 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 85+ messages in thread

end of thread, other threads:[~2024-03-13  2:36 UTC | newest]

Thread overview: 85+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-29  0:55 linux-next: build failure after merge of the crypto tree Stephen Rothwell
2016-11-29  7:08 ` Herbert Xu
2016-11-29  8:34   ` Horia Geantă
2016-11-29  8:43     ` Herbert Xu
  -- strict thread matches above, loose matches on Subject: below --
2024-03-13  0:57 Stephen Rothwell
2024-03-13  1:43 ` Herbert Xu
2024-03-13  1:45   ` Herbert Xu
2024-03-13  1:58     ` Barry Song
2024-03-13  2:01     ` Eric Biggers
2024-03-13  2:04       ` Herbert Xu
2024-03-13  2:29         ` Eric Biggers
2024-03-13  2:36           ` Herbert Xu
2024-03-13  2:12       ` Barry Song
2024-03-13  2:22         ` Eric Biggers
2023-10-30  4:58 Stephen Rothwell
2023-10-30  5:09 ` Stephen Rothwell
2023-10-30  5:23   ` Herbert Xu
2023-10-30 17:44     ` Dmitry Safonov
2023-10-30 22:02     ` Jakub Kicinski
2023-10-31  4:51       ` Eric Biggers
2023-10-31 20:14         ` Jakub Kicinski
2023-06-26  2:39 Stephen Rothwell
2023-06-26 10:20 ` Herbert Xu
2023-05-22  0:52 Stephen Rothwell
2023-05-22  5:15 ` Herbert Xu
2023-05-23  0:36   ` Stephen Rothwell
2023-04-11  0:48 Stephen Rothwell
2023-04-11  2:22 ` Herbert Xu
2023-01-17  3:47 Stephen Rothwell
2023-01-16  0:29 Stephen Rothwell
2022-12-04 23:48 Stephen Rothwell
2022-12-04 23:52 ` Stephen Rothwell
2022-09-07  1:53 Stephen Rothwell
2022-09-06  1:30 Stephen Rothwell
2022-05-09 11:10 Stephen Rothwell
2022-05-09 12:26 ` Masahiro Yamada
2021-09-27  4:32 Stephen Rothwell
2020-04-21  5:12 Stephen Rothwell
2020-04-22 13:33 ` Herbert Xu
2020-04-17  3:40 Stephen Rothwell
2020-04-17  4:00 ` Shukun Tan
2019-08-12  3:21 Stephen Rothwell
2019-08-12  6:53 ` Zhou Wang
2019-08-05  4:57 Stephen Rothwell
2019-08-05  5:37 ` Chuhong Yuan
2019-08-08  1:52 ` Stephen Rothwell
2019-08-08  3:01   ` Herbert Xu
2019-08-08  3:17     ` Stephen Rothwell
2019-08-08  5:00       ` Herbert Xu
2019-08-08  5:04         ` Stephen Rothwell
2018-10-08  1:03 Stephen Rothwell
2018-10-08  5:54 ` Herbert Xu
2018-05-29  9:08 Stephen Rothwell
2018-05-29 10:16 ` Ondrej Mosnáček
2018-05-29 10:22   ` Stephen Rothwell
2017-11-06  0:25 Stephen Rothwell
2017-11-06  5:40 ` Herbert Xu
2016-07-20  7:46 Stephen Rothwell
2016-07-20 14:32 ` Herbert Xu
2016-06-24  6:20 Stephen Rothwell
2016-06-24 13:33 ` Herbert Xu
2016-06-24 13:36   ` Benedetto, Salvatore
2016-02-17  1:26 Stephen Rothwell
2015-10-15  1:37 Stephen Rothwell
2015-10-15  2:01 ` Herbert Xu
2015-08-05  6:49 Stephen Rothwell
2015-08-05  7:28 ` Herbert Xu
2015-06-20  6:35 Stephen Rothwell
2015-05-28 11:40 Stephen Rothwell
2015-05-28 13:08 ` Stephan Mueller
2015-03-17  2:01 Stephen Rothwell
2015-03-17 11:11 ` Herbert Xu
2014-07-24  3:08 Stephen Rothwell
2014-07-24  7:04 ` Randy Dunlap
2014-07-24 13:37   ` Tom Lendacky
2014-06-23  1:49 Stephen Rothwell
2014-06-23 12:27 ` Herbert Xu
2014-06-23 13:15   ` Stephen Rothwell
2014-06-23 13:40     ` Herbert Xu
2013-12-06  0:45 Stephen Rothwell
2013-05-21  1:45 Stephen Rothwell
2013-05-24  9:57 ` Herbert Xu
2013-05-27  2:19   ` Herbert Xu
2013-05-27  3:43     ` Stephen Rothwell
2013-05-27  3:44       ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).