From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: linux-next: build failure after merge of the crypto tree Date: Tue, 29 Nov 2016 16:43:33 +0800 Message-ID: <20161129084333.GA5705@gondor.apana.org.au> References: <20161129115529.41f9f0b5@canb.auug.org.au> <20161129070840.GA5113@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org To: Horia =?utf-8?Q?Geant=C4=83?= Cc: Stephen Rothwell , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux Crypto Mailing List List-Id: linux-next.vger.kernel.org On Tue, Nov 29, 2016 at 08:34:08AM +0000, Horia Geantă wrote: > > > Fixes: da40e7a4ba4d ("crypto: aes-ce - Convert to skcipher") > > Fixes: 211f41af534a ("crypto: aesbs - Convert to skcipher") > The fix for this commit is missing. > CRYPTO_AES_ARM_BS also needs to select CRYPTO_SIMD. Thanks. I'll add this patch on top: ---8<--- Subject: crypto: arm/aes - Add missing SIMD select for aesbs This patch adds one more missing SIMD select for AES_ARM_BS. It also changes selects on ALGAPI to BLKCIPHER. Fixes: 211f41af534a ("crypto: aesbs - Convert to skcipher") Reported-by: Horia Geantă Signed-off-by: Herbert Xu diff --git a/arch/arm/crypto/Kconfig b/arch/arm/crypto/Kconfig index 8134888..dd90e38 100644 --- a/arch/arm/crypto/Kconfig +++ b/arch/arm/crypto/Kconfig @@ -88,9 +88,9 @@ config CRYPTO_AES_ARM config CRYPTO_AES_ARM_BS tristate "Bit sliced AES using NEON instructions" depends on KERNEL_MODE_NEON - select CRYPTO_ALGAPI select CRYPTO_AES_ARM - select CRYPTO_ABLK_HELPER + select CRYPTO_BLKCIPHER + select CRYPTO_SIMD help Use a faster and more secure NEON based implementation of AES in CBC, CTR and XTS modes @@ -104,7 +104,7 @@ config CRYPTO_AES_ARM_BS config CRYPTO_AES_ARM_CE tristate "Accelerated AES using ARMv8 Crypto Extensions" depends on KERNEL_MODE_NEON - select CRYPTO_ALGAPI + select CRYPTO_BLKCIPHER select CRYPTO_SIMD help Use an implementation of AES in CBC, CTR and XTS modes that uses -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt