From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaegeuk Kim Subject: Re: linux-next: build failure after merge of the akpm tree Date: Mon, 20 Mar 2017 09:22:38 -0400 Message-ID: <20170320132238.GA50490@jaegeuk.local> References: <20170320163735.332e64b7@canb.auug.org.au> <20170320130753.GA30053@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.kernel.org ([198.145.29.136]:33818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755156AbdCTNWp (ORCPT ); Mon, 20 Mar 2017 09:22:45 -0400 Content-Disposition: inline In-Reply-To: <20170320130753.GA30053@dhcp22.suse.cz> Sender: linux-next-owner@vger.kernel.org List-ID: To: Michal Hocko Cc: Stephen Rothwell , Andrew Morton , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Yu On 03/20, Michal Hocko wrote: > On Mon 20-03-17 16:37:35, Stephen Rothwell wrote: > > Hi Andrew, > > > > After merging the akpm tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > fs/f2fs/node.c: In function 'init_free_nid_cache': > > fs/f2fs/node.c:2634:25: error: implicit declaration of function 'f2fs_kvzalloc' [-Werror=implicit-function-declaration] > > nm_i->free_nid_count = f2fs_kvzalloc(nm_i->nat_blocks * > > ^ > > fs/f2fs/node.c:2634:23: warning: assignment makes pointer from integer without a cast [-Wint-conversion] > > nm_i->free_nid_count = f2fs_kvzalloc(nm_i->nat_blocks * > > ^ > > > > Caused by commit > > > > 69e5e80117a3 ("mm: introduce kv[mz]alloc helpers") > > > > interacting with commit > > > > c48b15867a2f ("f2fs: skip scanning free nid bitmap of full NAT blocks") > > > > from the f2fs tree. > > > > I applied the following fix patch: > > yes this is correct. Thanks! Thank you for checking this out. Thanks, > > > > > From: Stephen Rothwell > > Date: Mon, 20 Mar 2017 16:28:21 +1100 > > Subject: [PATCH] mm: introduce kv[mz]alloc helpers - f2fs fix up > > > > Signed-off-by: Stephen Rothwell > > --- > > fs/f2fs/node.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > > index cdbb05745895..0ea1dca8a0e2 100644 > > --- a/fs/f2fs/node.c > > +++ b/fs/f2fs/node.c > > @@ -2631,7 +2631,7 @@ static int init_free_nid_cache(struct f2fs_sb_info *sbi) > > if (!nm_i->nat_block_bitmap) > > return -ENOMEM; > > > > - nm_i->free_nid_count = f2fs_kvzalloc(nm_i->nat_blocks * > > + nm_i->free_nid_count = kvzalloc(nm_i->nat_blocks * > > sizeof(unsigned short), GFP_KERNEL); > > if (!nm_i->free_nid_count) > > return -ENOMEM; > > -- > > 2.11.0 > > > > -- > > Cheers, > > Stephen Rothwell > > -- > Michal Hocko > SUSE Labs