From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: sfr@canb.auug.org.au, jikos@kernel.org, jmorris@namei.org
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
jpoimboe@redhat.com
Subject: Re: linux-next: manual merge of the livepatching tree with the security tree
Date: Tue, 28 Mar 2017 20:23:04 +0900 [thread overview]
Message-ID: <201703282023.GHC34353.StLFOVOHQMJFOF@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20170328151341.7ab5a45b@canb.auug.org.au>
Stephen Rothwell wrote:
> Hi Jiri,
>
> Today's linux-next merge of the livepatching tree got conflicts in:
>
> include/linux/init_task.h
> include/linux/sched.h
>
> between commit:
>
> e4e55b47ed9a ("LSM: Revive security_task_alloc() hook and per "struct task_struct" security blob.")
>
> from the security tree and commit:
>
> d83a7cb375ee ("livepatch: change to a per-task consistency model")
>
> from the livepatching tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
Thank you for fixing.
This is an append to "struct task_struct" race which is inevitable.
>
> --
> Cheers,
> Stephen Rothwell
>
> diff --cc include/linux/init_task.h
> index 926f2f553cc5,5a791055b176..000000000000
> --- a/include/linux/init_task.h
> +++ b/include/linux/init_task.h
> @@@ -294,7 -296,7 +302,8 @@@ extern struct cred init_cred
> INIT_VTIME(tsk) \
> INIT_NUMA_BALANCING(tsk) \
> INIT_KASAN(tsk) \
> + INIT_TASK_SECURITY \
> + INIT_LIVEPATCH(tsk) \
> }
>
>
> diff --cc include/linux/sched.h
> index 9ac23308c82c,e11032010318..000000000000
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@@ -1042,10 -1038,9 +1042,13 @@@ struct task_struct
> /* A live task holds one reference: */
> atomic_t stack_refcount;
> #endif
> +#ifdef CONFIG_SECURITY
> + /* Used by LSM modules for access restriction: */
> + void *security;
> +#endif
> + #ifdef CONFIG_LIVEPATCH
Just a comment to livepatch change. It seems that addition of
/* A comment line for this variable: */
line and indentation alignment is expected due to
"Unscheduled maintenance for sched.h" work.
> + int patch_state;
> + #endif
> /* CPU-specific state of this task: */
> struct thread_struct thread;
>
>
prev parent reply other threads:[~2017-03-28 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 4:13 linux-next: manual merge of the livepatching tree with the security tree Stephen Rothwell
2017-03-28 11:23 ` Tetsuo Handa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201703282023.GHC34353.StLFOVOHQMJFOF@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=jikos@kernel.org \
--cc=jmorris@namei.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).