linux-next: build warning after merge of the sound-asoc tree

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/intel/skylake/bxt-sst.c: In function 'bxt_sst_dsp_init':
sound/soc/intel/skylake/bxt-sst.c:567:14: warning: 'skl' may be used uninitialized in this function [-Wmaybe-uninitialized]
   dev_err(skl->dev, "%s: no device\n", __func__);
              ^

Introduced by commit

  9fe9c7119283 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function")

This looks like an actual bug ...

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the sound-asoc tree

[Vinod Koul]

On Thu, Apr 27, 2017 at 11:29:20AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/intel/skylake/bxt-sst.c: In function 'bxt_sst_dsp_init':
> sound/soc/intel/skylake/bxt-sst.c:567:14: warning: 'skl' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    dev_err(skl->dev, "%s: no device\n", __func__);
>               ^
> 

Yeah looks like that is the case, fortunately fix is quite simple, I will
send out soon

Thanks for reporting

> Introduced by commit
> 
>   9fe9c7119283 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function")
> 
> This looks like an actual bug ...
> 
> -- 
> Cheers,
> Stephen Rothwell

-- 
~Vinod

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/cs42l43.c:142:6: warning: no previous prototype for 'cs42l43_hp_ilimit_clear_work' [-Wmissing-prototypes]
  142 | void cs42l43_hp_ilimit_clear_work(struct work_struct *work)
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/cs42l43.c:159:6: warning: no previous prototype for 'cs42l43_hp_ilimit_work' [-Wmissing-prototypes]
  159 | void cs42l43_hp_ilimit_work(struct work_struct *work)
      |      ^~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  bbbc18d8c27c ("ASoC: cs42l43: Allow HP amp to cool off after current limit")

Maybe they should just be static?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Charles Keepax]

On Tue, Dec 12, 2023 at 11:16:25AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/codecs/cs42l43.c:142:6: warning: no previous prototype for 'cs42l43_hp_ilimit_clear_work' [-Wmissing-prototypes]
>   142 | void cs42l43_hp_ilimit_clear_work(struct work_struct *work)
>       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/codecs/cs42l43.c:159:6: warning: no previous prototype for 'cs42l43_hp_ilimit_work' [-Wmissing-prototypes]
>   159 | void cs42l43_hp_ilimit_work(struct work_struct *work)
>       |      ^~~~~~~~~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   bbbc18d8c27c ("ASoC: cs42l43: Allow HP amp to cool off after current limit")
> 
> Maybe they should just be static?
> 

Yeah they should be static sorry, will send a patch today.

Thanks,
Charles

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/int_log.h:1: warning: no structured comments found

Introduced by commit

  f97fa3dcb2db ("lib/math: Move dvb_math.c into lib/math/int_log.c")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Andy Shevchenko]

On Thu, Jul 13, 2023 at 12:16:27PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> include/linux/int_log.h:1: warning: no structured comments found
> 
> Introduced by commit
> 
>   f97fa3dcb2db ("lib/math: Move dvb_math.c into lib/math/int_log.c")

Can you elaborate a bit, please?

Seems to me to be a false positive, or unveils a bug somewhere else.

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build warning after merge of the sound-asoc tree

[Andy Shevchenko]

On Thu, Jul 13, 2023 at 03:19:04PM +0300, Andy Shevchenko wrote:
> On Thu, Jul 13, 2023 at 12:16:27PM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the sound-asoc tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > include/linux/int_log.h:1: warning: no structured comments found
> > 
> > Introduced by commit
> > 
> >   f97fa3dcb2db ("lib/math: Move dvb_math.c into lib/math/int_log.c")
> 
> Can you elaborate a bit, please?
> 
> Seems to me to be a false positive, or unveils a bug somewhere else.

Ah, now I understand. There is a header file that has descriptions but
EXPORT_SYMBOL. We have to drop keyword export from the index.

Thank you for the report, I'll cook the patch ASAP.

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build warning after merge of the sound-asoc tree

[Andy Shevchenko]

On Thu, Jul 13, 2023 at 03:41:09PM +0300, Andy Shevchenko wrote:
> On Thu, Jul 13, 2023 at 03:19:04PM +0300, Andy Shevchenko wrote:
> > On Thu, Jul 13, 2023 at 12:16:27PM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > After merging the sound-asoc tree, today's linux-next build (htmldocs)
> > > produced this warning:
> > > 
> > > include/linux/int_log.h:1: warning: no structured comments found
> > > 
> > > Introduced by commit
> > > 
> > >   f97fa3dcb2db ("lib/math: Move dvb_math.c into lib/math/int_log.c")
> > 
> > Can you elaborate a bit, please?
> > 
> > Seems to me to be a false positive, or unveils a bug somewhere else.
> 
> Ah, now I understand. There is a header file that has descriptions but
> EXPORT_SYMBOL. We have to drop keyword export from the index.
> 
> Thank you for the report, I'll cook the patch ASAP.

The 20230713165320.14199-1-andriy.shevchenko@linux.intel.com had been sent.

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

Hi Aall,

On Fri, 14 Jul 2023 12:18:55 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> On Thu, Jul 13, 2023 at 03:41:09PM +0300, Andy Shevchenko wrote:
> > On Thu, Jul 13, 2023 at 03:19:04PM +0300, Andy Shevchenko wrote:  
> > > On Thu, Jul 13, 2023 at 12:16:27PM +1000, Stephen Rothwell wrote:  
> > > > 
> > > > After merging the sound-asoc tree, today's linux-next build (htmldocs)
> > > > produced this warning:
> > > > 
> > > > include/linux/int_log.h:1: warning: no structured comments found
> > > > 
> > > > Introduced by commit
> > > > 
> > > >   f97fa3dcb2db ("lib/math: Move dvb_math.c into lib/math/int_log.c")  
> > > 
> > > Can you elaborate a bit, please?
> > > 
> > > Seems to me to be a false positive, or unveils a bug somewhere else.  
> > 
> > Ah, now I understand. There is a header file that has descriptions but
> > EXPORT_SYMBOL. We have to drop keyword export from the index.
> > 
> > Thank you for the report, I'll cook the patch ASAP.  
> 
> The 20230713165320.14199-1-andriy.shevchenko@linux.intel.com had been sent.

But not yet applied by anyone :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Andy Shevchenko]

On Mon, Jul 24, 2023 at 01:58:58PM +1000, Stephen Rothwell wrote:
> On Fri, 14 Jul 2023 12:18:55 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, Jul 13, 2023 at 03:41:09PM +0300, Andy Shevchenko wrote:
> > > On Thu, Jul 13, 2023 at 03:19:04PM +0300, Andy Shevchenko wrote:  
> > > > On Thu, Jul 13, 2023 at 12:16:27PM +1000, Stephen Rothwell wrote:  
> > > > > 
> > > > > After merging the sound-asoc tree, today's linux-next build (htmldocs)
> > > > > produced this warning:
> > > > > 
> > > > > include/linux/int_log.h:1: warning: no structured comments found
> > > > > 
> > > > > Introduced by commit
> > > > > 
> > > > >   f97fa3dcb2db ("lib/math: Move dvb_math.c into lib/math/int_log.c")  
> > > > 
> > > > Can you elaborate a bit, please?
> > > > 
> > > > Seems to me to be a false positive, or unveils a bug somewhere else.  
> > > 
> > > Ah, now I understand. There is a header file that has descriptions but
> > > EXPORT_SYMBOL. We have to drop keyword export from the index.
> > > 
> > > Thank you for the report, I'll cook the patch ASAP.  
> > 
> > The 20230713165320.14199-1-andriy.shevchenko@linux.intel.com had been sent.
> 
> But not yet applied by anyone :-(

Since the culprit went via ASoC tree, I think that tree is the best for the fix.
Mark, can you apply that, please?

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build warning after merge of the sound-asoc tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

On Mon, Jul 24, 2023 at 11:26:58AM +0300, Andy Shevchenko wrote:
> On Mon, Jul 24, 2023 at 01:58:58PM +1000, Stephen Rothwell wrote:
> > On Fri, 14 Jul 2023 12:18:55 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> > > The 20230713165320.14199-1-andriy.shevchenko@linux.intel.com had been sent.

For the benefit of those playing at home that's "Documentation:
core-api: Drop :export: for int_log.h".

> > But not yet applied by anyone :-(

> Since the culprit went via ASoC tree, I think that tree is the best for the fix.
> Mark, can you apply that, please?

Jon's usually fairly responsive, perhaps there's something worrying
there, though I do note you only sent it a bit more than a week ago.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Andy Shevchenko]

On Mon, Jul 24, 2023 at 01:36:53PM +0100, Mark Brown wrote:
> On Mon, Jul 24, 2023 at 11:26:58AM +0300, Andy Shevchenko wrote:
> > On Mon, Jul 24, 2023 at 01:58:58PM +1000, Stephen Rothwell wrote:
> > > On Fri, 14 Jul 2023 12:18:55 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> > > > The 20230713165320.14199-1-andriy.shevchenko@linux.intel.com had been sent.
> 
> For the benefit of those playing at home that's "Documentation:
> core-api: Drop :export: for int_log.h".
> 
> > > But not yet applied by anyone :-(
> 
> > Since the culprit went via ASoC tree, I think that tree is the best for the fix.
> > Mark, can you apply that, please?
> 
> Jon's usually fairly responsive, perhaps there's something worrying
> there,

Hmm... maybe my understanding of the :export: is wrong? Or what do you suggest?

> though I do note you only sent it a bit more than a week ago.

I fully aware of that and you can see that this reply has been induced by
the ping from Stephen.

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build warning after merge of the sound-asoc tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

On Mon, Jul 24, 2023 at 04:05:34PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 24, 2023 at 01:36:53PM +0100, Mark Brown wrote:

> > Jon's usually fairly responsive, perhaps there's something worrying
> > there,

> Hmm... maybe my understanding of the :export: is wrong? Or what do you suggest?

I have no idea what any of that is doing.  I'm hoping Jon does.

> > though I do note you only sent it a bit more than a week ago.

> I fully aware of that and you can see that this reply has been induced by
> the ping from Stephen.

Sure, but that means that it's possible he's just not got round to it
yet rather than that there's a problem.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Andy Shevchenko]

+Cc: Jon

On Mon, Jul 24, 2023 at 02:11:00PM +0100, Mark Brown wrote:
> On Mon, Jul 24, 2023 at 04:05:34PM +0300, Andy Shevchenko wrote:
> > On Mon, Jul 24, 2023 at 01:36:53PM +0100, Mark Brown wrote:
> 
> > > Jon's usually fairly responsive, perhaps there's something worrying
> > > there,
> 
> > Hmm... maybe my understanding of the :export: is wrong? Or what do you suggest?
> 
> I have no idea what any of that is doing.  I'm hoping Jon does.

Okay, so far we are waiting for his reply...

> > > though I do note you only sent it a bit more than a week ago.
> 
> > I fully aware of that and you can see that this reply has been induced by
> > the ping from Stephen.
> 
> Sure, but that means that it's possible he's just not got round to it
> yet rather than that there's a problem.

-- 
With Best Regards,
Andy Shevchenko

Re: linux-next: build warning after merge of the sound-asoc tree

[Jonathan Corbet]

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

> +Cc: Jon
>
> On Mon, Jul 24, 2023 at 02:11:00PM +0100, Mark Brown wrote:
>> On Mon, Jul 24, 2023 at 04:05:34PM +0300, Andy Shevchenko wrote:
>> > On Mon, Jul 24, 2023 at 01:36:53PM +0100, Mark Brown wrote:
>> 
>> > > Jon's usually fairly responsive, perhaps there's something worrying
>> > > there,
>> 
>> > Hmm... maybe my understanding of the :export: is wrong? Or what do you suggest?
>> 
>> I have no idea what any of that is doing.  I'm hoping Jon does.
>
> Okay, so far we are waiting for his reply...

Sorry, it took me a bit to reconstruct why I hadn't applied this .. the
simple fact is that it doesn't apply to docs-next.
include/linux/int_log.h doesn't exist in mainline, so the kernel-doc
directive to include from it doesn't either.  All of that is introduced
in linux-next ... so the fix really needs to take the same path that the
rest of the changes did.

I guess I'd just assumed that was going to happen and didn't reply,
apologies for that.

Feel free to add:

Acked-by: Jonathan Corbet <corbet@lwn.net>

if you feel so inclined.

Thanks,

jon

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 630 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

WARNING: unmet direct dependencies detected for SND_SOC_AMD_MACH_COMMON
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && X86 && PCI [=y] && I2C [=y]
  Selected by [y]:
  - SND_SOC_AMD_LEGACY_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y]
  - SND_SOC_AMD_SOF_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y]

Presuambly introduced by commit

  9d8a7be88b33 ("ASoC: amd: acp: Add legacy sound card support for Chrome audio")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/rt5682-i2c.c: In function 'rt5682_i2c_remove':
sound/soc/codecs/rt5682-i2c.c:297:22: warning: unused variable 'rt5682' [-Wunused-variable]
  297 |  struct rt5682_priv *rt5682 = i2c_get_clientdata(client);
      |                      ^~~~~~

Introduced by commit

  772d44526e20 ("ASoC: rt5682: Properly turn off regulators if wrong device ID")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Doug Anderson]

Hi,

On Thu, Aug 12, 2021 at 7:17 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> sound/soc/codecs/rt5682-i2c.c: In function 'rt5682_i2c_remove':
> sound/soc/codecs/rt5682-i2c.c:297:22: warning: unused variable 'rt5682' [-Wunused-variable]
>   297 |  struct rt5682_priv *rt5682 = i2c_get_clientdata(client);
>       |                      ^~~~~~
>
> Introduced by commit
>
>   772d44526e20 ("ASoC: rt5682: Properly turn off regulators if wrong device ID")

Thanks for the report. Fixed by:

https://lore.kernel.org/r/20210813073402.1.Iaa9425cfab80f5233afa78b32d02b6dc23256eb3@changeid

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 938 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/soc/generic/simple-card.c: In function 'simple_parse_of':
sound/soc/generic/simple-card.c:478:1: warning: the frame size of 1552 bytes is larger than 1024 bytes [-Wframe-larger-than=]
  478 | }
      | ^
sound/soc/generic/simple-card.c: In function 'asoc_simple_probe':
sound/soc/generic/simple-card.c:706:1: warning: the frame size of 1552 bytes is larger than 1024 bytes [-Wframe-larger-than=]
  706 | }
      | ^
sound/soc/generic/audio-graph-card.c: In function 'audio_graph_parse_of':
sound/soc/generic/audio-graph-card.c:612:1: warning: the frame size of 1552 bytes is larger than 1024 bytes [-Wframe-larger-than=]
  612 | }
      | ^

Presumably introduced by commit

  343e55e71877 ("ASoC: simple-card-utils: Increase maximum number of links to 128")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

sound/soc/amd/acp-da7219-max98357a.c:684:28: warning: 'cz_rt5682_card' defined but not used [-Wunused-variable]
  684 | static struct snd_soc_card cz_rt5682_card = {
      |                            ^~~~~~~~~~~~~~
sound/soc/amd/acp-da7219-max98357a.c:671:28: warning: 'cz_card' defined but not used [-Wunused-variable]
  671 | static struct snd_soc_card cz_card = {
      |                            ^~~~~~~

Introduced by commit

  7e71b48f9e27 ("ASoC: amd: Add support for RT5682 codec in machine driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Mukunda,Vijendar]

On 3/23/21 11:13 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> sound/soc/amd/acp-da7219-max98357a.c:684:28: warning: 'cz_rt5682_card' defined but not used [-Wunused-variable]
>    684 | static struct snd_soc_card cz_rt5682_card = {
>        |                            ^~~~~~~~~~~~~~
> sound/soc/amd/acp-da7219-max98357a.c:671:28: warning: 'cz_card' defined but not used [-Wunused-variable]
>    671 | static struct snd_soc_card cz_card = {
>        |                            ^~~~~~~
> 
> Introduced by commit
> 
>    7e71b48f9e27 ("ASoC: amd: Add support for RT5682 codec in machine driver")
> 

Will add ACPI dependency in Kconfig and submit the supplement patch.

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/mt6359.c: In function 'mt6359_platform_driver_remove':
sound/soc/codecs/mt6359.c:2823:6: warning: unused variable 'ret' [-Wunused-variable]
 2823 |  int ret;
      |      ^~~
sound/soc/codecs/mt6359.c:2822:22: warning: unused variable 'priv' [-Wunused-variable]
 2822 |  struct mt6359_priv *priv = dev_get_drvdata(&pdev->dev);
      |                      ^~~~

Introduced by commit

  64a70744b778 ("ASoC: Fix vaud18 power leakage of mt6359")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/fsl/fsl_spdif.c: In function 'fsl_spdif_probe':
sound/soc/fsl/fsl_spdif.c:1255:22: warning: unused variable 'np' [-Wunused-variable]
 1255 |  struct device_node *np = pdev->dev.of_node;
      |                      ^~

Introduced by commit

  601fd3a7d849 ("ASoC: fsl_spdif: Fix unnecessary check in fsl_spdif_probe()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in sound/soc/sof/imx/imx-common.o

Introduced by commit

  18ebffe4d043 ("ASoC: SOF: imx: Add debug support for imx platforms")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Kai Vehmanen]

Hello,

+Daniel,+Pierre

On Fri, 18 Sep 2020, Stephen Rothwell wrote:

> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> WARNING: modpost: missing MODULE_LICENSE() in sound/soc/sof/imx/imx-common.o

thanks for the report. I made a patch and once I get acks from
stakeholders, will submit to asoc tree:
https://github.com/thesofproject/linux/pull/2450

We'll also follow up how this slipped through our CI.

Br, Kai

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/sunxi/sun8i-codec.c:532:12: warning: 'sun8i_codec_component_probe' defined but not used [-Wunused-function]
  532 | static int sun8i_codec_component_probe(struct snd_soc_component *component)
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  90cac932976e ("ASoC: sun8i-codec: Fix DAPM to match the hardware topology")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/sof/intel/byt.c:464:12: warning: 'byt_remove' defined but not used [-Wunused-function]
  464 | static int byt_remove(struct snd_sof_dev *sdev)
      |            ^~~~~~~~~~
sound/soc/sof/intel/byt.c:454:12: warning: 'byt_resume' defined but not used [-Wunused-function]
  454 | static int byt_resume(struct snd_sof_dev *sdev)
      |            ^~~~~~~~~~
sound/soc/sof/intel/byt.c:447:12: warning: 'byt_suspend' defined but not used [-Wunused-function]
  447 | static int byt_suspend(struct snd_sof_dev *sdev, u32 target_state)
      |            ^~~~~~~~~~~

Introduced by commits

  ddcccd543f5d ("ASoC: SOF: Intel: byt: Add PM callbacks")
  c691f0c6e267 ("ASoC: SOF: Intel: BYT: add .remove op")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

On Thu, May 28, 2020 at 01:57:17PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/sof/intel/byt.c:464:12: warning: 'byt_remove' defined but not used [-Wunused-function]
>   464 | static int byt_remove(struct snd_sof_dev *sdev)
>       |            ^~~~~~~~~~
> sound/soc/sof/intel/byt.c:454:12: warning: 'byt_resume' defined but not used [-Wunused-function]
>   454 | static int byt_resume(struct snd_sof_dev *sdev)
>       |            ^~~~~~~~~~
> sound/soc/sof/intel/byt.c:447:12: warning: 'byt_suspend' defined but not used [-Wunused-function]
>   447 | static int byt_suspend(struct snd_sof_dev *sdev, u32 target_state)
>       |            ^~~~~~~~~~~
> 
> Introduced by commits
> 
>   ddcccd543f5d ("ASoC: SOF: Intel: byt: Add PM callbacks")
>   c691f0c6e267 ("ASoC: SOF: Intel: BYT: add .remove op")

Ranjani, Pierre?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Pierre-Louis Bossart]

On 5/29/20 8:30 AM, Mark Brown wrote:
> On Thu, May 28, 2020 at 01:57:17PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the sound-asoc tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> sound/soc/sof/intel/byt.c:464:12: warning: 'byt_remove' defined but not used [-Wunused-function]
>>    464 | static int byt_remove(struct snd_sof_dev *sdev)
>>        |            ^~~~~~~~~~
>> sound/soc/sof/intel/byt.c:454:12: warning: 'byt_resume' defined but not used [-Wunused-function]
>>    454 | static int byt_resume(struct snd_sof_dev *sdev)
>>        |            ^~~~~~~~~~
>> sound/soc/sof/intel/byt.c:447:12: warning: 'byt_suspend' defined but not used [-Wunused-function]
>>    447 | static int byt_suspend(struct snd_sof_dev *sdev, u32 target_state)
>>        |            ^~~~~~~~~~~
>>
>> Introduced by commits
>>
>>    ddcccd543f5d ("ASoC: SOF: Intel: byt: Add PM callbacks")
>>    c691f0c6e267 ("ASoC: SOF: Intel: BYT: add .remove op")
> 
> Ranjani, Pierre?

Humm, I am not sure what happened here or why kbuild didn't report this 
earlier. This was added in

ddcccd543f5dbd ('ASoC: SOF: Intel: byt: Add PM callbacks')

And I do see them used in the code:

sound/soc/sof/intel/byt.c

	/* PM */
	.suspend = byt_suspend,
	.resume = byt_resume,

Will run a check and fix ASAP, my guess it's a Kconfig issue or the 
functions not protected by the usual SND_SOC_SOF_BAYTRAIL.

Re: linux-next: build warning after merge of the sound-asoc tree

[Pierre-Louis Bossart]

On 5/29/20 8:55 AM, Pierre-Louis Bossart wrote:
> 
> 
> On 5/29/20 8:30 AM, Mark Brown wrote:
>> On Thu, May 28, 2020 at 01:57:17PM +1000, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the sound-asoc tree, today's linux-next build (x86_64
>>> allmodconfig) produced this warning:
>>>
>>> sound/soc/sof/intel/byt.c:464:12: warning: 'byt_remove' defined but 
>>> not used [-Wunused-function]
>>>    464 | static int byt_remove(struct snd_sof_dev *sdev)
>>>        |            ^~~~~~~~~~
>>> sound/soc/sof/intel/byt.c:454:12: warning: 'byt_resume' defined but 
>>> not used [-Wunused-function]
>>>    454 | static int byt_resume(struct snd_sof_dev *sdev)
>>>        |            ^~~~~~~~~~
>>> sound/soc/sof/intel/byt.c:447:12: warning: 'byt_suspend' defined but 
>>> not used [-Wunused-function]
>>>    447 | static int byt_suspend(struct snd_sof_dev *sdev, u32 
>>> target_state)
>>>        |            ^~~~~~~~~~~
>>>
>>> Introduced by commits
>>>
>>>    ddcccd543f5d ("ASoC: SOF: Intel: byt: Add PM callbacks")
>>>    c691f0c6e267 ("ASoC: SOF: Intel: BYT: add .remove op")
>>
>> Ranjani, Pierre?
> 
> Humm, I am not sure what happened here or why kbuild didn't report this 
> earlier. This was added in
> 
> ddcccd543f5dbd ('ASoC: SOF: Intel: byt: Add PM callbacks')
> 
> And I do see them used in the code:
> 
> sound/soc/sof/intel/byt.c
> 
>      /* PM */
>      .suspend = byt_suspend,
>      .resume = byt_resume,
> 
> Will run a check and fix ASAP, my guess it's a Kconfig issue or the 
> functions not protected by the usual SND_SOC_SOF_BAYTRAIL.

it's both. allmodconfig disables SND_SOC_SOF_BAYTRAIL due to mutual 
exclusion with the legacy driver, but enables SND_SOC_SOF_MERRIFIELD 
(this should be fixed in a separate patch) and in this case we haven't 
tested suspend/resume on merrifield so didn't use this code. Will send a 
patch shortly.

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

WARNING: unmet direct dependencies detected for SND_SOC_SOF_IMX8M
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_SOF_TOPLEVEL [=y] && SND_SOC_SOF_IMX_TOPLEVEL [=y] && IMX_DSP
  Selected by [y]:
  - SND_SOC_SOF_IMX_OF [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_SOF_TOPLEVEL [=y] && SND_SOC_SOF_IMX_TOPLEVEL [=y] && SND_SOC_SOF_IMX8M_SUPPORT [=y]

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/device.h:15,
                 from include/sound/core.h:10,
                 from sound/soc/amd/acp3x-rt5682-max9836.c:7:
sound/soc/amd/acp3x-rt5682-max9836.c: In function 'acp3x_probe':
sound/soc/amd/acp3x-rt5682-max9836.c:341:23: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
  341 |   dev_err(&pdev->dev, "DMIC gpio failed err=%d\n",
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
   19 | #define dev_fmt(fmt) fmt
      |                      ^~~
sound/soc/amd/acp3x-rt5682-max9836.c:341:3: note: in expansion of macro 'dev_err'
  341 |   dev_err(&pdev->dev, "DMIC gpio failed err=%d\n",
      |   ^~~~~~~
sound/soc/amd/acp3x-rt5682-max9836.c:341:46: note: format string is defined here
  341 |   dev_err(&pdev->dev, "DMIC gpio failed err=%d\n",
      |                                             ~^
      |                                              |
      |                                              int
      |                                             %ld

Introduced by commit

  72c3b2b09fcd ("ASoc: amd: Add DMIC switch capability to machine driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/rt1015.c:844:31: warning: 'rt1015_aif_dai_ops' defined but not used [-Wunused-variable]
  844 | static struct snd_soc_dai_ops rt1015_aif_dai_ops = {
      |                               ^~~~~~~~~~~~~~~~~~

Exposed by commit

  4a88b7dec331 ("ASoC: rt1015: modify some structure to be static.")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/rt5677-spi.c: In function 'rt5677_spi_pcm_close':
sound/soc/codecs/rt5677-spi.c:114:30: warning: unused variable 'rtd' [-Wunused-variable]
  114 |  struct snd_soc_pcm_runtime *rtd = substream->private_data;
      |                              ^~~

Introduced by commit

  a0e0d135427c ("ASoC: rt5677: Add a PCM device for streaming hotword via SPI")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/jz4740/jz4740-i2s.c: In function 'jz4740_i2s_dev_probe':
sound/soc/jz4740/jz4740-i2s.c:500:29: warning: unused variable 'match' [-Wunused-variable]
  500 |  const struct of_device_id *match;
      |                             ^~~~~

Introduced by commit

  67ad656bdd70 ("ASoC: jz4740: Use of_device_get_match_data()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/soc/fsl/fsl_sai.c: In function 'fsl_sai_remove':
sound/soc/fsl/fsl_sai.c:921:1: warning: no return statement in function returning non-void [-Wreturn-type]
 }
 ^

Introduced by commit

  812ad463e089 ("ASoC: fsl_sai: Add support for runtime pm")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Nicolin Chen]

On Fri, Apr 26, 2019 at 01:05:49PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> sound/soc/fsl/fsl_sai.c: In function 'fsl_sai_remove':
> sound/soc/fsl/fsl_sai.c:921:1: warning: no return statement in function returning non-void [-Wreturn-type]
>  }
>  ^
> 
> Introduced by commit
> 
>   812ad463e089 ("ASoC: fsl_sai: Add support for runtime pm")

Thanks. I am submitting a fix.

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/intel/boards/bytcht_es8316.c: In function 'snd_byt_cht_es8316_mc_probe':
sound/soc/intel/boards/bytcht_es8316.c:508:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   quirk = (int)dmi_id->driver_data;
           ^

Introduced by commit

  a8d218f4fe81 ("ASoC: Intel: bytcht_es8316: Add quirk for the Teclast X98+ II")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/tlv320aic32x4-clk.c: In function 'clk_aic32x4_pll_recalc_rate':
sound/soc/codecs/tlv320aic32x4-clk.c:149:38: warning: 'settings.d' may be used uninitialized in this function [-Wmaybe-uninitialized]
     ((settings->j * 10000) + settings->d);
                              ~~~~~~~~^~~
sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.d' was declared here
  struct clk_aic32x4_pll_muldiv settings;
                                ^~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:149:15: warning: 'settings.j' may be used uninitialized in this function [-Wmaybe-uninitialized]
     ((settings->j * 10000) + settings->d);
       ~~~~~~~~^~~
sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.j' was declared here
  struct clk_aic32x4_pll_muldiv settings;
                                ^~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:148:37: warning: 'settings.r' may be used uninitialized in this function [-Wmaybe-uninitialized]
  rate = (u64) parent_rate * settings->r *
                             ~~~~~~~~^~~
sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.r' was declared here
  struct clk_aic32x4_pll_muldiv settings;
                                ^~~~~~~~
sound/soc/codecs/tlv320aic32x4-clk.c:151:56: warning: 'settings.p' may be used uninitialized in this function [-Wmaybe-uninitialized]
  return (unsigned long) DIV_ROUND_UP_ULL(rate, settings->p * 10000);
                                                        ^~
sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.p' was declared here
  struct clk_aic32x4_pll_muldiv settings;
                                ^~~~~~~~

Introduced by commit

  514b044cba66 ("ASoC: tlv320aic32x4: Model PLL in CCF")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2090 bytes --]

Hi all,

On Tue, 26 Mar 2019 10:01:45 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/codecs/tlv320aic32x4-clk.c: In function 'clk_aic32x4_pll_recalc_rate':
> sound/soc/codecs/tlv320aic32x4-clk.c:149:38: warning: 'settings.d' may be used uninitialized in this function [-Wmaybe-uninitialized]
>      ((settings->j * 10000) + settings->d);
>                               ~~~~~~~~^~~
> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.d' was declared here
>   struct clk_aic32x4_pll_muldiv settings;
>                                 ^~~~~~~~
> sound/soc/codecs/tlv320aic32x4-clk.c:149:15: warning: 'settings.j' may be used uninitialized in this function [-Wmaybe-uninitialized]
>      ((settings->j * 10000) + settings->d);
>        ~~~~~~~~^~~
> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.j' was declared here
>   struct clk_aic32x4_pll_muldiv settings;
>                                 ^~~~~~~~
> sound/soc/codecs/tlv320aic32x4-clk.c:148:37: warning: 'settings.r' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   rate = (u64) parent_rate * settings->r *
>                              ~~~~~~~~^~~
> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.r' was declared here
>   struct clk_aic32x4_pll_muldiv settings;
>                                 ^~~~~~~~
> sound/soc/codecs/tlv320aic32x4-clk.c:151:56: warning: 'settings.p' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   return (unsigned long) DIV_ROUND_UP_ULL(rate, settings->p * 10000);
>                                                         ^~
> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.p' was declared here
>   struct clk_aic32x4_pll_muldiv settings;
>                                 ^~~~~~~~
> 
> Introduced by commit
> 
>   514b044cba66 ("ASoC: tlv320aic32x4: Model PLL in CCF")

I am still getting these warnings.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Annaliese McDermond]

Stephen --

I’m testing a potential solution now and I’ll be submitting something in the next couple of days.  Thanks for the heads up.

--
Annaliese McDermond
nh6z@nh6z.net

> On Apr 8, 2019, at 4:12 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> Hi all,
> 
> On Tue, 26 Mar 2019 10:01:45 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> 
>> After merging the sound-asoc tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>> 
>> sound/soc/codecs/tlv320aic32x4-clk.c: In function 'clk_aic32x4_pll_recalc_rate':
>> sound/soc/codecs/tlv320aic32x4-clk.c:149:38: warning: 'settings.d' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>     ((settings->j * 10000) + settings->d);
>>                              ~~~~~~~~^~~
>> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.d' was declared here
>>  struct clk_aic32x4_pll_muldiv settings;
>>                                ^~~~~~~~
>> sound/soc/codecs/tlv320aic32x4-clk.c:149:15: warning: 'settings.j' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>     ((settings->j * 10000) + settings->d);
>>       ~~~~~~~~^~~
>> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.j' was declared here
>>  struct clk_aic32x4_pll_muldiv settings;
>>                                ^~~~~~~~
>> sound/soc/codecs/tlv320aic32x4-clk.c:148:37: warning: 'settings.r' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>  rate = (u64) parent_rate * settings->r *
>>                             ~~~~~~~~^~~
>> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.r' was declared here
>>  struct clk_aic32x4_pll_muldiv settings;
>>                                ^~~~~~~~
>> sound/soc/codecs/tlv320aic32x4-clk.c:151:56: warning: 'settings.p' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>  return (unsigned long) DIV_ROUND_UP_ULL(rate, settings->p * 10000);
>>                                                        ^~
>> sound/soc/codecs/tlv320aic32x4-clk.c:197:32: note: 'settings.p' was declared here
>>  struct clk_aic32x4_pll_muldiv settings;
>>                                ^~~~~~~~
>> 
>> Introduced by commit
>> 
>>  514b044cba66 ("ASoC: tlv320aic32x4: Model PLL in CCF")
> 
> I am still getting these warnings.
> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2484 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/pm_runtime.h:12,
                 from sound/soc/codecs/wm_adsp.c:21:
sound/soc/codecs/wm_adsp.c: In function 'wmfw_parse_id_header':
sound/soc/codecs/wm_adsp.c:45:22: warning: format '%zu' expects argument of type 'size_t', but argument 8 has type 'int' [-Wformat=]
  dev_info(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
                      ^~~~~~
include/linux/device.h:1400:22: note: in definition of macro 'dev_fmt'
 #define dev_fmt(fmt) fmt
                      ^~~
sound/soc/codecs/wm_adsp.c:45:2: note: in expansion of macro 'dev_info'
  dev_info(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
  ^~~~~~~~
sound/soc/codecs/wm_adsp.c:2145:2: note: in expansion of macro 'adsp_info'
  adsp_info(dsp, "Firmware: %x v%d.%d.%d, %zu algorithms\n",
  ^~~~~~~~~
sound/soc/codecs/wm_adsp.c:2145:44: note: format string is defined here
  adsp_info(dsp, "Firmware: %x v%d.%d.%d, %zu algorithms\n",
                                          ~~^
                                          %u
In file included from include/linux/pm_runtime.h:12,
                 from sound/soc/codecs/wm_adsp.c:21:
sound/soc/codecs/wm_adsp.c: In function 'wmfw_v3_parse_id_header':
sound/soc/codecs/wm_adsp.c:45:22: warning: format '%zu' expects argument of type 'size_t', but argument 9 has type 'int' [-Wformat=]
  dev_info(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
                      ^~~~~~
include/linux/device.h:1400:22: note: in definition of macro 'dev_fmt'
 #define dev_fmt(fmt) fmt
                      ^~~
sound/soc/codecs/wm_adsp.c:45:2: note: in expansion of macro 'dev_info'
  dev_info(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
  ^~~~~~~~
sound/soc/codecs/wm_adsp.c:2158:2: note: in expansion of macro 'adsp_info'
  adsp_info(dsp, "Firmware: %x vendor: 0x%x v%d.%d.%d, %zu algorithms\n",
  ^~~~~~~~~
sound/soc/codecs/wm_adsp.c:2158:57: note: format string is defined here
  adsp_info(dsp, "Firmware: %x vendor: 0x%x v%d.%d.%d, %zu algorithms\n",
                                                       ~~^
                                                       %u

Introduced by commits

  a5dcb24d70ff ("ASoC: wm_adsp: Factor out parsing of firmware ID header")
  170b1e123f38 ("ASoC: wm_adsp: Add support for new Halo core DSPs")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/soc/samsung/odroid.c: In function 'odroid_audio_probe':
sound/soc/samsung/odroid.c:298:22: warning: 'cpu_dai' may be used uninitialized in this function [-Wmaybe-uninitialized]
  priv->clk_i2s_bus = of_clk_get_by_name(cpu_dai, "iis");
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  d832d2b246c5 ("ASoC: samsung: odroid: Fix of_node refcount unbalance")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/soc/samsung/i2s.c: In function 'samsung_i2s_remove':
sound/soc/samsung/i2s.c:1469:27: warning: unused variable 'priv' [-Wunused-variable]
  struct samsung_i2s_priv *priv = dev_get_drvdata(&pdev->dev);
                           ^~~~

Introduced by commit

  a404b72d2bdd ("ASoC: samsung: i2s: Convert to single component with multiple DAIs")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Sylwester Nawrocki]

Hi Stephen,

On 2/13/19 02:31, Stephen Rothwell wrote:
> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> sound/soc/samsung/i2s.c: In function 'samsung_i2s_remove':
> sound/soc/samsung/i2s.c:1469:27: warning: unused variable 'priv' [-Wunused-variable]
>   struct samsung_i2s_priv *priv = dev_get_drvdata(&pdev->dev);
                            ^~~~
> 
> Introduced by commit
> 
>   a404b72d2bdd ("ASoC: samsung: i2s: Convert to single component with multiple DAIs")

Thanks for the information. Due to my messed up rebase the line
quoted above ended up in the above mentioned commit instead of 
in the next on in the series, which has not yet been applied:

"ASoC: samsung: i2s: Restore support for the secondary PCM"

-- 
Regards
Sylwester

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/soc/soc-dapm.c: In function 'snd_soc_dai_link_event':
sound/soc/soc-dapm.c:3771:9: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
  return ret;
         ^~~

This looks like a (subtle) false positive. You have to assume that all
the loops will be executed at least once.

Probably introduced by commit

  4a75aae17b2a ("ASoC: dapm: Add support for multi-CODEC CODEC to CODEC links")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
  Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && QCOM_APR [=n] && HAS_DMA [=y]
  Selected by [m]:
  - SND_SOC_SDM845 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m]

Introduced by commit

  6b1687bf76ef ("ASoC: qcom: add sdm845 sound card support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

On Thu, Aug 02, 2018 at 02:06:30PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:

I was sent a patch for this already, should be fixed tomorrow.  Thanks
for reporting.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_probe':
sound/soc/amd/acp-da7219-max98357a.c:367:3: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
   dev_err(&pdev->dev, "Failed to register regulator: %d\n",
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ret);
    ~~~~

Introduced by commit

  7b5317aa809f ("ASoC: AMD: Add a fix voltage regulator for DA7219 and ADAU7002")

This is a real bug.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Agrawal, Akshu]

On 7/26/2018 7:49 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_probe':
> sound/soc/amd/acp-da7219-max98357a.c:367:3: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    dev_err(&pdev->dev, "Failed to register regulator: %d\n",
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     ret);
>     ~~~~
> 
> Introduced by commit
> 
>   7b5317aa809f ("ASoC: AMD: Add a fix voltage regulator for DA7219 and ADAU7002")
> 
> This is a real bug.
> 
Posted the fix for the above warning message:
https://patchwork.kernel.org/patch/10545235/

Thanks,
Akshu

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
see include/linux/module.h for more information

Introduced by commit

  dde637f2daf1 ("ASoC: omap: Introduce the generic_dmaengine_pcm based sdma-pcm")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/wm9081.c: In function 'wm9081_digital_mute':
sound/soc/codecs/wm9081.c:1161:7: warning: 'reg' may be used uninitialized in this function [-Wmaybe-uninitialized]
   reg |= WM9081_DAC_MUTE;

Introduced by commit

  48c338764296 ("ASoC: wm9081: replace codec to component")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the sound-asoc tree

[Kuninori Morimoto]

Hi Stephen

> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/codecs/wm9081.c: In function 'wm9081_digital_mute':
> sound/soc/codecs/wm9081.c:1161:7: warning: 'reg' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    reg |= WM9081_DAC_MUTE;
> 
> Introduced by commit
> 
>   48c338764296 ("ASoC: wm9081: replace codec to component")

Thank you for your report.
I posted fixup patch for it.

Best regards
---
Kuninori Morimoto

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/stm/stm32_sai_sub.c: In function 'stm32_sai_hw_params':
sound/soc/stm/stm32_sai_sub.c:485:7: warning: 'cr1' may be used uninitialized in this function [-Wmaybe-uninitialized]
   cr1 |= SAI_XCR1_DS_SET(SAI_DATASIZE_8);
       ^
sound/soc/stm/stm32_sai_sub.c:469:6: note: 'cr1' was declared here
  int cr1, cr1_mask, ret;
      ^

Introduced by commit

  61fb4ff70377 ("ASoC: stm32: sai: Move static settings to DAI init")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/cs43130.c: In function 'cs43130_imp_meas':
sound/soc/codecs/cs43130.c:2089:18: warning: 'hpload_seq' may be used uninitialized in this function [-Wmaybe-uninitialized]
        hpload_seq[i].msk, ac_idx);
                  ^

Introduced by commit

  8f1e5bf9b440 ("ASoC: cs43130: Add support for CS43130 codec")

This is probably a false positive.

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/soc/tegra/tegra_wm8903.c: In function 'tegra_wm8903_remove':
sound/soc/tegra/tegra_wm8903.c:206:23: warning: unused variable 'machine' [-Wunused-variable]
  struct tegra_wm8903 *machine = snd_soc_card_get_drvdata(card);
                       ^

Introduced by commit

  2a8bd83af30e ("ASoC: tegra: Remove superfluous snd_soc_jack_free_gpios() call")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the sound-asoc tree

[Takashi Iwai]

On Wed, 23 Aug 2017 04:20:07 +0200,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> sound/soc/tegra/tegra_wm8903.c: In function 'tegra_wm8903_remove':
> sound/soc/tegra/tegra_wm8903.c:206:23: warning: unused variable 'machine' [-Wunused-variable]
>   struct tegra_wm8903 *machine = snd_soc_card_get_drvdata(card);
>                        ^
> 
> Introduced by commit
> 
>   2a8bd83af30e ("ASoC: tegra: Remove superfluous snd_soc_jack_free_gpios() call")

My bad, will submit the fix patch.


thanks,

Takashi

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from sound/soc/intel/skylake/skl-debug.c:23:0:
sound/soc/intel/skylake/../common/sst-dsp-priv.h:63:42: warning: 'struct sst_pdata' declared inside parameter list
  int (*init)(struct sst_dsp *sst, struct sst_pdata *pdata);
                                          ^
sound/soc/intel/skylake/../common/sst-dsp-priv.h:63:42: warning: its scope is only this definition or declaration, which is probably not what you want

Exposed by commit

  bdd0384a5ada ("ASoC: Intel: Skylake: Add support to read firmware registers")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/intel/boards/cht_bsw_rt5645.c: In function 'cht_codec_init':
sound/soc/intel/boards/cht_bsw_rt5645.c:265:22: warning: unused variable 'codec_dai' [-Wunused-variable]
  struct snd_soc_dai *codec_dai = runtime->codec_dai;
                      ^

Introduced by commit

  7bde09dfcf60 ("ASoC: Intel: cht-bsw-rt5645: fix DAI formats")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/soc-topology.c: In function 'soc_tplg_dapm_widget_create':
sound/soc/soc-topology.c:1566:36: warning: 'kcontrol_type' may be used uninitialized in this function [-Wmaybe-uninitialized]
  widget->dobj.widget.kcontrol_type = kcontrol_type;
                                    ^

Introduced by commit

  eea3dd4f1247 ("ASoC: topology: Only free TLV for volume mixers of a widget")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

warning: (SND_SOC_ALL_CODECS) selects SND_SOC_STI_SAS which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && SND_SOC_STI)

Introduced by commit

  32a726b2e089 ("ASoC: sti-sas: Add sti platform codec")

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Valentin Rothberg]

Hi,

On Mon, Jul 13, 2015 at 5:23 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> warning: (SND_SOC_ALL_CODECS) selects SND_SOC_STI_SAS which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && SND_SOC_STI)

Here's the introducing hunk:

+config SND_SOC_STI_SAS
+       tristate "codec Audio support for STI SAS codec"
+       depends on SND_SOC_STI

SND_SOC_STI is not defined in Kconfig.

Kind regards,
 Valentin

> Introduced by commit
>
>   32a726b2e089 ("ASoC: sti-sas: Add sti platform codec")
>
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/soc/soc-dapm.c: In function 'snd_soc_dapm_new_pcm':
sound/soc/soc-dapm.c:3389:4: warning: passing argument 1 of 'snprintf' discards 'const' qualifier from pointer target type
    snprintf(w_param_text[count], len,
    ^

Introduced by commit c66150824b8a ("ASoC: dapm: add code to configure
dai link parameters").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/intel/sst-haswell-pcm.c: In function 'hsw_stream_volume_put':
sound/soc/intel/sst-haswell-pcm.c:139:38: warning: initialization from incompatible pointer type [enabled by default]
  struct snd_soc_platform *platform = snd_soc_kcontrol_platform(kcontrol);
                                      ^

And several others ... really, you should try build testing this stuff :-(

Caused by commit f6272ff8a5f4 ("ASoC: Add snd_soc_kcontrol_platform()
helper function").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/cs42l51.c: In function 'cs42l51_probe':
sound/soc/codecs/cs42l51.c:490:26: warning: unused variable 'cs42l51' [-Wunused-variable]
  struct cs42l51_private *cs42l51 = snd_soc_codec_get_drvdata(codec);
                          ^

Introduced by commit da0714897624 ("ASoC: cs42l51: Convert to direct
regmap API usage").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/soc-dapm.c: In function 'dapm_clock_event':
sound/soc/soc-dapm.c:1022:1: warning: control reaches end of non-void function [-Wreturn-type]

This is with CONFIG_HAVE_CLK not set.  Introduced by commit ec02995adad5
("ASoC: dapm: Bodge for lack of a widely available clk API").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/lm49453.c: In function 'lm49453_set_dai_fmt':
sound/soc/codecs/lm49453.c:1189:4: warning: overflow in implicit constant conversion [-Woverflow]
sound/soc/codecs/lm49453.c:1193:4: warning: overflow in implicit constant conversion [-Woverflow]
sound/soc/codecs/lm49453.c:1197:4: warning: overflow in implicit constant conversion [-Woverflow]

Introduced by commit dbf7a733f5fb (ASoC: Support TI LM49453 Audio driver"").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[MR Swami Reddy]

Hi,
I tried to reproduce the below mentioned warning messages using:
 - Latest for-next git repo sources  on x86_64 build machine
 - gcc version 4.3.2
 - -Woverflow option used in KBUILD_CFLAGS

But couldn't see the warning messages.

Below is the quick patch to remove the warning messages (and this patch
will be submitted to alsa-devel mailing list soon).

Signed-off-by: M R Swami Reddy <mr.swami.reddy@ti.com>
---
 sound/soc/codecs/lm49453.c  |   13 +-
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/sound/soc/codecs/lm49453.c b/sound/soc/codecs/lm49453.c
index 744063d..74409ec 100644
--- a/sound/soc/codecs/lm49453.c
+++ b/sound/soc/codecs/lm49453.c
@@ -1178,27 +1178,24 @@ static int lm49453_set_dai_fmt(struct
snd_soc_dai *codec_dai, unsigned int fmt)
 {
        struct snd_soc_codec *codec = codec_dai->codec;

-       int aif_val = 0;
+       u16 aif_val;
        int mode = 0;
        int clk_phase = 0;
        int clk_shift = 0;

        switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
        case SND_SOC_DAIFMT_CBS_CFS:
-               aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
-                       ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+               aif_val = 0;
                break;
        case SND_SOC_DAIFMT_CBS_CFM:
-               aif_val = ~LM49453_AUDIO_PORT1_BASIC_CLK_MS |
-                       LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+               aif_val = LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
                break;
        case SND_SOC_DAIFMT_CBM_CFS:
-               aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
-                       ~LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+               aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS;
                break;
        case SND_SOC_DAIFMT_CBM_CFM:
                aif_val = LM49453_AUDIO_PORT1_BASIC_CLK_MS |
-                       LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
+                         LM49453_AUDIO_PORT1_BASIC_SYNC_MS;
                break;
        default:
                return -EINVAL;




On Thursday 05 April 2012 06:33 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> sound/soc/codecs/lm49453.c: In function 'lm49453_set_dai_fmt':
> sound/soc/codecs/lm49453.c:1189:4: warning: overflow in implicit constant conversion [-Woverflow]
> sound/soc/codecs/lm49453.c:1193:4: warning: overflow in implicit constant conversion [-Woverflow]
> sound/soc/codecs/lm49453.c:1197:4: warning: overflow in implicit constant conversion [-Woverflow]
>
> Introduced by commit dbf7a733f5fb (ASoC: Support TI LM49453 Audio driver"").

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (powerpc
ppc64_defconfig and x86_64 allmodconfig) produced this warning:

drivers/misc/Kconfig:212:error: recursive dependency detected!
drivers/misc/Kconfig:212:	symbol ATMEL_SSC is selected by SND_ATMEL_SOC_SSC
sound/soc/atmel/Kconfig:9:	symbol SND_ATMEL_SOC_SSC is selected by SND_AT91_SOC_SAM9G20_WM8731
sound/soc/atmel/Kconfig:18:	symbol SND_AT91_SOC_SAM9G20_WM8731 depends on ATMEL_SSC

Probably introduced by commit 739be96ab837 ("ASoC: Fix build dependency
for SND_ATMEL_SOC_SSC").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Axel Lin]

2012/1/9 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (powerpc
> ppc64_defconfig and x86_64 allmodconfig) produced this warning:
>
> drivers/misc/Kconfig:212:error: recursive dependency detected!
> drivers/misc/Kconfig:212:       symbol ATMEL_SSC is selected by SND_ATMEL_SOC_SSC
> sound/soc/atmel/Kconfig:9:      symbol SND_ATMEL_SOC_SSC is selected by SND_AT91_SOC_SAM9G20_WM8731
> sound/soc/atmel/Kconfig:18:     symbol SND_AT91_SOC_SAM9G20_WM8731 depends on ATMEL_SSC
>
> Probably introduced by commit 739be96ab837 ("ASoC: Fix build dependency
> for SND_ATMEL_SOC_SSC").
Hi Mark,
I think this commit should be replaced by [PATCH] ASoC: Fix build
dependency for SND_AT91_SOC_AFEB9260
http://mailman.alsa-project.org/pipermail/alsa-devel/2012-January/047861.html

Should I send a revert patch for commit 739be96ab837? Or you can do it
by git-revert command directly?

Thanks,
Axel
>
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/

Re: linux-next: build warning after merge of the sound-asoc tree

[Mark Brown]

On Mon, Jan 09, 2012 at 11:03:35AM +0800, Axel Lin wrote:
> 2012/1/9 Stephen Rothwell <sfr@canb.auug.org.au>:

> I think this commit should be replaced by [PATCH] ASoC: Fix build
> dependency for SND_AT91_SOC_AFEB9260
> http://mailman.alsa-project.org/pipermail/alsa-devel/2012-January/047861.html

> Should I send a revert patch for commit 739be96ab837? Or you can do it
> by git-revert command directly?

Send an incremental patch to put things into the desired state.

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

Hi all,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/codecs/tpa6130a2.c: In function 'tpa6130a2_add_controls':
sound/soc/codecs/tpa6130a2.c:342: warning: unused variable 'dapm'

Introduced by commit 39646871a47fd8808c08de0ce7d7ca8393af2805 ("ASoC:
tpa6130a2: Replace DAPM code with direct interface").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Peter Ujfalusi]

Hi,

On 12/28/2010 01:32 AM, ext Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/codecs/tpa6130a2.c: In function 'tpa6130a2_add_controls':
> sound/soc/codecs/tpa6130a2.c:342: warning: unused variable 'dapm'
> 
> Introduced by commit 39646871a47fd8808c08de0ce7d7ca8393af2805 ("ASoC:
> tpa6130a2: Replace DAPM code with direct interface").

Sorry about that.
I'll send the fix in a few minutes.

-- 
Péter

linux-next: build warning after merge of the sound-asoc tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Hi ,

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/soc/soc-core.c: In function 'snd_soc_register_dais':
sound/soc/soc-core.c:2919: warning: format '%d' expects type 'int', but argument 5 has type 'size_t'

Caused by commit f0fba2ad1b6b53d5360125c41953b7afcd6deff0 ("ASoC:
multi-component - ASoC Multi-Component Support").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the sound-asoc tree

[Liam Girdwood]

On Tue, 2010-08-17 at 12:21 +1000, Stephen Rothwell wrote:
> Hi ,
> 
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/soc/soc-core.c: In function 'snd_soc_register_dais':
> sound/soc/soc-core.c:2919: warning: format '%d' expects type 'int', but argument 5 has type 'size_t'
> 
> Caused by commit f0fba2ad1b6b53d5360125c41953b7afcd6deff0 ("ASoC:
> multi-component - ASoC Multi-Component Support").

Ah, this never showed up on ARM since size_t is 32 bits.

Mark, could you apply this fix.

Thanks

Liam

>From 4c3f9d5fcb46d769f4a52a044fead863419c1d58 Mon Sep 17 00:00:00 2001
From: Liam Girdwood <lrg@slimlogic.co.uk>
Date: Wed, 18 Aug 2010 00:25:12 +0100
Subject: [PATCH] ASoC: core - fix build warning on x86_64

Output size_t type as a "%Zu" to avoid warnings.

Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
---
 sound/soc/soc-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 3d480eb..7093c17 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -2916,7 +2916,7 @@ int snd_soc_register_dais(struct device *dev,
 	struct snd_soc_dai *dai;
 	int i, ret = 0;
 
-	dev_dbg(dev, "dai register %s #%d\n", dev_name(dev), count);
+	dev_dbg(dev, "dai register %s #%Zu\n", dev_name(dev), count);
 
 	for (i = 0; i < count; i++) {
 
-- 
1.7.0.4

Re: linux-next: build warning after merge of the sound-asoc tree

[Mark Brown]

On Wed, Aug 18, 2010 at 12:30:30AM +0100, Liam Girdwood wrote:

> Mark, could you apply this fix.

Done.