Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jens Axboe <axboe@kernel.dk>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Bart Van Assche <bart.vanassche@sandisk.com>
Subject: Re: linux-next: build warning after merge of the block tree
Date: Wed, 10 May 2017 04:20:54 +0200
Message-ID: <20170510022054.GA23014@x4> (raw)
In-Reply-To: <20170510112411.1e785033@canb.auug.org.au>

On 2017.05.10 at 11:24 +1000, Stephen Rothwell wrote:
> Hi Jens,
> 
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> block/elevator.c: In function 'elv_iosched_store':
> block/elevator.c:1102:2: warning: ignoring return value of 'strstrip', declared with attribute warn_unused_result [-Wunused-result]
>   strstrip(elevator_name);
>   ^
> 
> Introduced by commit
> 
>   d0f6e2da5871 ("block: Remove leading whitespace and trailing newline in elevator switch error message")

Yes, it was missing a (void) like "(void)strlcpy(...)". But Jens
unfortunately removed both warnings, so the following patch should now
be enough:

diff --git a/block/elevator.c b/block/elevator.c
index fda6be933130..dd0ed19e4fb7 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -1099,8 +1099,7 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
 		return count;
 
 	strlcpy(elevator_name, skip_spaces(name), sizeof(elevator_name));
-	strstrip(elevator_name);
-	ret = __elevator_change(q, elevator_name);
+	ret = __elevator_change(q, strstrip(elevator_name));
 	if (!ret)
 		return count;
 
-- 
Markus

  reply index

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10  1:24 Stephen Rothwell
2017-05-10  2:20 ` Markus Trippelsdorf [this message]
2017-05-10  3:00   ` Jens Axboe
2017-05-10  6:19     ` Markus Trippelsdorf
2017-05-10  3:26   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2020-10-22 23:48 Stephen Rothwell
2020-10-23  0:30 ` Jens Axboe
2020-07-02  1:21 Stephen Rothwell
2020-07-02  4:07 ` Jens Axboe
2020-03-04  2:17 Stephen Rothwell
2020-03-04  3:01 ` Jens Axboe
2020-03-04 12:50   ` Pavel Begunkov
2020-01-31  0:16 Stephen Rothwell
2020-01-31  0:25 ` Jens Axboe
2020-01-16  0:54 Stephen Rothwell
2020-01-16  4:50 ` Jens Axboe
2019-10-18  0:51 Stephen Rothwell
2019-10-18  0:56 ` Jens Axboe
2019-10-18  0:59   ` Jens Axboe
2019-10-18  3:58   ` Stephen Rothwell
2019-08-29  3:51 Stephen Rothwell
2019-08-29  4:08 ` Stephen Rothwell
2019-08-29 15:41   ` Tejun Heo
2019-08-29 15:44     ` Jens Axboe
2019-08-09  4:00 Stephen Rothwell
2019-08-09  4:13 ` Jens Axboe
2019-08-09  6:15 ` Yuehaibing
2019-04-17  2:31 Stephen Rothwell
2019-04-17 10:05 ` Chao Yu
2019-04-17 14:03   ` Jaegeuk Kim
2019-04-18  0:57     ` Chao Yu
2019-04-18 14:01       ` Jaegeuk Kim
2019-04-19  1:14         ` Chao Yu
2018-11-08  3:31 Stephen Rothwell
2018-11-08  4:19 ` Jens Axboe
2018-09-28  1:11 Stephen Rothwell
2018-09-28  6:43 ` Omar Sandoval
2018-09-28 14:26   ` Jens Axboe
2018-05-31  3:49 Stephen Rothwell
2018-05-14  2:51 Stephen Rothwell
2018-05-14  8:29 ` Christoph Hellwig
2018-05-14 14:31   ` Jens Axboe
2014-10-23  1:28 Stephen Rothwell
2014-10-23  2:14 ` Jens Axboe
2013-09-23  4:29 Stephen Rothwell
2011-05-09  3:49 Stephen Rothwell
2011-05-09  5:55 ` Tao Ma
2011-05-09  6:34   ` Jens Axboe
2010-12-20  4:31 Stephen Rothwell
2010-12-20  4:42 ` Stephen Rothwell
2010-12-20  8:12   ` Jens Axboe
2010-09-16  3:30 Stephen Rothwell
2010-04-29  6:14 Stephen Rothwell
2010-04-29  7:28 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170510022054.GA23014@x4 \
    --to=markus@trippelsdorf.de \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@sandisk.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git