linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Galo Navarro <anglor@varoa.net>
Cc: linux-next@vger.kernel.org, Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH v2] staging: rtl8188eu: style fixes
Date: Wed, 14 Jun 2017 12:26:20 +0200	[thread overview]
Message-ID: <20170614102620.GC8485@kroah.com> (raw)
In-Reply-To: <20170613190518.GA2144@lear>

On Tue, Jun 13, 2017 at 09:05:19PM +0200, Galo Navarro wrote:
> Fix multiple style issues (CHECK spaces preferred around that $thing).

That's not the only thing you did here.  Please only do one type of fix
per patch.  Break this up into multiple patches please.

thanks,

greg k-h

  reply	other threads:[~2017-06-14 10:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02 14:36 [PATCH] staging: rtl8188eu: style fixes Galo
2017-06-02 17:41 ` Nicholas Mc Guire
2017-06-03  8:18 ` Greg Kroah-Hartman
2017-06-13 19:05 ` [PATCH v2] " Galo Navarro
2017-06-14 10:26   ` Greg Kroah-Hartman [this message]
2017-06-24 18:32     ` [PATCH v3] " Galo Navarro
  -- strict thread matches above, loose matches on Subject: below --
2017-04-20 21:42 [PATCH] " Galo Navarro
2017-04-21  4:21 ` Greg Kroah-Hartman
2017-04-21  8:06   ` Galo
2017-04-21  8:18     ` Greg Kroah-Hartman
2017-04-23 19:03       ` [PATCH v2] " Galo
2017-04-28 10:29         ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170614102620.GC8485@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=anglor@varoa.net \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).