From: Stephen Boyd <sboyd@codeaurora.org>
To: Anup Patel <anup.patel@broadcom.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Mike Turquette <mturquette@baylibre.com>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sandeep Tripathy <sandeep.tripathy@broadcom.com>,
Ray Jui <ray.jui@broadcom.com>,
Scott Branden <scott.branden@broadcom.com>
Subject: Re: linux-next: build warnings after merge of the clk tree
Date: Wed, 21 Jun 2017 09:13:39 -0700 [thread overview]
Message-ID: <20170621161339.GX4493@codeaurora.org> (raw)
In-Reply-To: <CAALAos-MZxMWS9yePDf0RZvp7FMpkqGAMrvncRq9qziPDewwkQ@mail.gmail.com>
On 06/21, Anup Patel wrote:
> On Wed, Jun 21, 2017 at 5:04 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi all,
> >
> > After merging the clk tree, today's linux-next build (x86_64 allmodconfig)
> > produced these warnings:
> >
> > WARNING: vmlinux.o(.text+0x819309): Section mismatch in reference from the function sr_genpll0_clk_init() to the function .init.text:iproc_pll_clk_setup()
> > The function sr_genpll0_clk_init() references
> > the function __init iproc_pll_clk_setup().
> > This is often because sr_genpll0_clk_init lacks a __init
> > annotation or the annotation of iproc_pll_clk_setup is wrong.
> >
> > Introduced by commit
> >
> > 654cdd3229cd ("clk: bcm: Add clocks for Stingray SOC")
Thanks for the report!
>
> All sr_xxx_init() had __init attribute but we had removed it based on
> review comments.
>
> The iproc_pll_xxx() APIs are shared across various clk drivers of iproc SoCs.
>
> I suggest we bring back __init attribute for all sr_xxx_init() in sr_clk.c ??
>
No. We should remove __init from the iproc_pll_clk_setup()
function.
---8<---
From: Stephen Boyd <sboyd@codeaurora.org>
Subject: [PATCH] clk: iproc: Remove __init marking on iproc_pll_clk_setup()
Now that this function is called from driver probe routines, it
needs to drop the __init marking because it isn't just called
from init code.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Sandeep Tripathy <sandeep.tripathy@broadcom.com>
Cc: Anup Patel <anup.patel@broadcom.com>
Cc: Ray Jui <ray.jui@broadcom.com>
Cc: Scott Branden <scott.branden@broadcom.com>
Fixes: 654cdd3229cd ("clk: bcm: Add clocks for Stingray SOC")
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/clk/bcm/clk-iproc-pll.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/bcm/clk-iproc-pll.c b/drivers/clk/bcm/clk-iproc-pll.c
index 2d61893da024..375d8dd80d45 100644
--- a/drivers/clk/bcm/clk-iproc-pll.c
+++ b/drivers/clk/bcm/clk-iproc-pll.c
@@ -617,12 +617,12 @@ static void iproc_pll_sw_cfg(struct iproc_pll *pll)
}
}
-void __init iproc_pll_clk_setup(struct device_node *node,
- const struct iproc_pll_ctrl *pll_ctrl,
- const struct iproc_pll_vco_param *vco,
- unsigned int num_vco_entries,
- const struct iproc_clk_ctrl *clk_ctrl,
- unsigned int num_clks)
+void iproc_pll_clk_setup(struct device_node *node,
+ const struct iproc_pll_ctrl *pll_ctrl,
+ const struct iproc_pll_vco_param *vco,
+ unsigned int num_vco_entries,
+ const struct iproc_clk_ctrl *clk_ctrl,
+ unsigned int num_clks)
{
int i, ret;
struct iproc_pll *pll;
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-06-21 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 23:34 linux-next: build warnings after merge of the clk tree Stephen Rothwell
2017-06-21 15:15 ` Anup Patel
2017-06-21 16:13 ` Stephen Boyd [this message]
2020-02-02 22:16 Stephen Rothwell
2020-02-03 5:25 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621161339.GX4493@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=anup.patel@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=ray.jui@broadcom.com \
--cc=sandeep.tripathy@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).