Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the rtc tree
Date: Thu, 6 Jul 2017 08:59:01 +0200
Message-ID: <20170706065901.op7tk2rhzmyay7md@piout.net> (raw)
In-Reply-To: <f8ad4233-93b8-b643-a272-9f9b3b89261a@gmail.com>

On 06/07/2017 at 07:54:58 +0200, Heiner Kallweit wrote:
> Am 06.07.2017 um 06:24 schrieb Stephen Rothwell:
> > Hi Alexandre,
> > 
> > After merging the rtc tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > drivers/rtc/rtc-ds1307.c: In function 'ds1307_get_time':
> > drivers/rtc/rtc-ds1307.c:342:26: warning: unused variable 'chip' [-Wunused-variable]
> >   const struct chip_desc *chip = &chips[ds1307->type];
> >                           ^
> > 
> > Introduced by commit
> > 
> >   436c93db60a4 ("rtc: ds1307: factor out century bit handling")
> > 
> Right, if RTC_DRV_DS1307 is defined but RTC_DRV_DS1307_CENTURY is not
> then variable chip isn't used in ds1307_get_time.
> We could fix this by simply defining variable chip only if
> RTC_DRV_DS1307_CENTURY is defined.
> 
> However the current situation leaves the question why
> RTC_DRV_DS1307_CENTURY isn't set in the ppc64 defconfig.
> This config option should be n only temporarily if a system has
> to be fixed, see description of this option.
> Maybe we should set this config option to "default y" ?
> 

Well, the code would still have to be fixed.

> Rgds, Heiner

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06  4:24 Stephen Rothwell
2017-07-06  5:54 ` Heiner Kallweit
2017-07-06  6:59   ` Alexandre Belloni [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-10-30  4:41 Stephen Rothwell
2019-11-08  5:29 ` Stephen Rothwell
2019-11-08 15:20   ` Alexandre Belloni
2019-08-21  6:31 Stephen Rothwell
2019-03-28  1:23 Stephen Rothwell
2019-03-28  1:36 ` Joel Stanley
2019-03-28  1:57   ` Alexandre Belloni
2019-03-28  2:09     ` Joel Stanley
2018-03-21  6:44 Stephen Rothwell
2017-06-29  5:42 Stephen Rothwell
2017-01-13  3:18 Stephen Rothwell
2017-01-13  8:42 ` Amelie DELAUNAY
2017-01-10  3:01 Stephen Rothwell
2017-01-10 10:59 ` Alexandre Belloni
2016-07-11  8:12 Stephen Rothwell
2016-07-11  8:23 ` Uwe Kleine-König
2016-07-11 21:23   ` Alexandre Belloni

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170706065901.op7tk2rhzmyay7md@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git