* linux-next: Signed-off-by missing for commit in the rcu tree
@ 2017-07-30 13:48 Stephen Rothwell
2017-07-30 16:57 ` Paul E. McKenney
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2017-07-30 13:48 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Mathieu Desnoyers
Hi Paul,
Commit
6a48c1c899e8 ("membarrier: Expedited private command")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rcu tree
2017-07-30 13:48 linux-next: Signed-off-by missing for commit in the rcu tree Stephen Rothwell
@ 2017-07-30 16:57 ` Paul E. McKenney
0 siblings, 0 replies; 14+ messages in thread
From: Paul E. McKenney @ 2017-07-30 16:57 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Mathieu Desnoyers
On Sun, Jul 30, 2017 at 11:48:57PM +1000, Stephen Rothwell wrote:
> Hi Paul,
>
> Commit
>
> 6a48c1c899e8 ("membarrier: Expedited private command")
>
> is missing a Signed-off-by from its committer.
Good catch, fixed.
Thanx, Paul
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rcu tree
2019-10-28 20:53 Stephen Rothwell
@ 2019-10-29 0:37 ` Paul E. McKenney
0 siblings, 0 replies; 14+ messages in thread
From: Paul E. McKenney @ 2019-10-29 0:37 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Paul E. McKenney, Linux Next Mailing List,
Linux Kernel Mailing List, Joel Fernandes (Google)
On Tue, Oct 29, 2019 at 07:53:59AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commits
>
> 51db3f987f62 ("Restore docs "rcu: Restore barrier() to rcu_read_lock() and rcu_read_unlock()"")
> a0c1ba228721 ("Restore docs "treewide: Rename rcu_dereference_raw_notrace() to _check()"")
> 8b3b77cca47f ("Revert docs from "treewide: Rename rcu_dereference_raw_notrace() to _check()"")
> f7bf64a4ff9e ("Revert docs from "rcu: Restore barrier() to rcu_read_lock() and rcu_read_unlock()"")
>
> are missing a Signed-off-by from their authors.
Again, good catch, thank you!
Joel, if you have any objections to my adding your Signed-off-by, please
let me know. (In which case, I will defer them to the v5.6 merge window,
which would allow us time to work out what to do instead.)
Thanx, Paul
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: Signed-off-by missing for commit in the rcu tree
@ 2019-10-28 20:53 Stephen Rothwell
2019-10-29 0:37 ` Paul E. McKenney
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2019-10-28 20:53 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Joel Fernandes (Google)
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
Hi all,
Commits
51db3f987f62 ("Restore docs "rcu: Restore barrier() to rcu_read_lock() and rcu_read_unlock()"")
a0c1ba228721 ("Restore docs "treewide: Rename rcu_dereference_raw_notrace() to _check()"")
8b3b77cca47f ("Revert docs from "treewide: Rename rcu_dereference_raw_notrace() to _check()"")
f7bf64a4ff9e ("Revert docs from "rcu: Restore barrier() to rcu_read_lock() and rcu_read_unlock()"")
are missing a Signed-off-by from their authors.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rcu tree
2018-04-23 21:48 Stephen Rothwell
@ 2018-04-23 22:16 ` Paul E. McKenney
0 siblings, 0 replies; 14+ messages in thread
From: Paul E. McKenney @ 2018-04-23 22:16 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
On Tue, Apr 24, 2018 at 07:48:44AM +1000, Stephen Rothwell wrote:
> Hi Paul,
>
> Commit
>
> bbf9d3657c39 ("doc: Ensure whatisRCU.txt actually says what RCU is")
>
> is missing a Signed-off-by from its committer.
Good catch, fixed!
Thanx, Paul
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: Signed-off-by missing for commit in the rcu tree
@ 2018-04-23 21:48 Stephen Rothwell
2018-04-23 22:16 ` Paul E. McKenney
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2018-04-23 21:48 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
Hi Paul,
Commit
bbf9d3657c39 ("doc: Ensure whatisRCU.txt actually says what RCU is")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rcu tree
2018-02-26 22:38 Stephen Rothwell
@ 2018-02-26 23:22 ` Paul E. McKenney
0 siblings, 0 replies; 14+ messages in thread
From: Paul E. McKenney @ 2018-02-26 23:22 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
On Tue, Feb 27, 2018 at 09:38:16AM +1100, Stephen Rothwell wrote:
> Hi Paul,
>
> Commit
>
> 2a84d1aef423 ("rcu: Inline rcu_preempt_do_callback() into its sole caller")
>
> is missing a Signed-off-by from its committer.
That would be because idiot here left the "-s" off of "git am"...
Apologies for the hassle, rebased to fix.
Thanx, Paul
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: Signed-off-by missing for commit in the rcu tree
@ 2018-02-26 22:38 Stephen Rothwell
2018-02-26 23:22 ` Paul E. McKenney
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2018-02-26 22:38 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 185 bytes --]
Hi Paul,
Commit
2a84d1aef423 ("rcu: Inline rcu_preempt_do_callback() into its sole caller")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rcu tree
2017-11-29 3:29 ` Lihao Liang
@ 2017-11-29 20:54 ` Paul E. McKenney
0 siblings, 0 replies; 14+ messages in thread
From: Paul E. McKenney @ 2017-11-29 20:54 UTC (permalink / raw)
To: Lihao Liang
Cc: Hanjun Guo, Stephen Rothwell, Linux-Next Mailing List,
Linux Kernel Mailing List, lihao.liang
On Wed, Nov 29, 2017 at 11:29:03AM +0800, Lihao Liang wrote:
>
>
> On 2017/11/29 11:14, Hanjun Guo wrote:
> > Hi Lihao,
> >
> > On 2017/11/29 10:48, Lihao Liang wrote:
> >> Hi Paul,
> >>
> >> Signed-off-by: Lihao Liang <lihao.liang@gmail.com>
> >
> > ...
> >
> >>
> >> Many thanks,
> >> Lihao.
> >>
> >> On 2017/11/29 9:14, Paul E. McKenney wrote:
> >>> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
> >>>> Hi Paul,
> >>>>
> >>>> Commit
> >>>>
> >>>> d7e182c9c324 ("rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()")
> >>>>
> >>>> is missing a Signed-off-by from its author.
> >>> Good catch, Stephen!
> >>>
> >>> Lihao, would you please get me you Signed-off-by? The patch is below.
> >>>
> >>> Thanx, Paul
> >>>
> >>> ------------------------------------------------------------------------
> >>>
> >>> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
> >>> Author: Liang Lihao <lianglihao@huawei.com>
> >
> > So it's better to keep the author and Signed-off-by the same :)
> >
>
> Sure. Paul and Stephen, please use
>
> Signed-off-by: Lihao Liang <lianglihao@huawei.com>
Updated, thank you both!
Thanx, Paul
> Many thanks,
> Lihao.
>
> > Thanks
> > Hanjun
> >
> >
> > .
> >
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rcu tree
2017-11-29 3:14 ` Hanjun Guo
@ 2017-11-29 3:29 ` Lihao Liang
2017-11-29 20:54 ` Paul E. McKenney
0 siblings, 1 reply; 14+ messages in thread
From: Lihao Liang @ 2017-11-29 3:29 UTC (permalink / raw)
To: Hanjun Guo, paulmck, Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, lihao.liang
On 2017/11/29 11:14, Hanjun Guo wrote:
> Hi Lihao,
>
> On 2017/11/29 10:48, Lihao Liang wrote:
>> Hi Paul,
>>
>> Signed-off-by: Lihao Liang <lihao.liang@gmail.com>
>
> ...
>
>>
>> Many thanks,
>> Lihao.
>>
>> On 2017/11/29 9:14, Paul E. McKenney wrote:
>>> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
>>>> Hi Paul,
>>>>
>>>> Commit
>>>>
>>>> d7e182c9c324 ("rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()")
>>>>
>>>> is missing a Signed-off-by from its author.
>>> Good catch, Stephen!
>>>
>>> Lihao, would you please get me you Signed-off-by? The patch is below.
>>>
>>> Thanx, Paul
>>>
>>> ------------------------------------------------------------------------
>>>
>>> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
>>> Author: Liang Lihao <lianglihao@huawei.com>
>
> So it's better to keep the author and Signed-off-by the same :)
>
Sure. Paul and Stephen, please use
Signed-off-by: Lihao Liang <lianglihao@huawei.com>
Many thanks,
Lihao.
> Thanks
> Hanjun
>
>
> .
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rcu tree
2017-11-29 2:48 ` Lihao Liang
@ 2017-11-29 3:14 ` Hanjun Guo
2017-11-29 3:29 ` Lihao Liang
0 siblings, 1 reply; 14+ messages in thread
From: Hanjun Guo @ 2017-11-29 3:14 UTC (permalink / raw)
To: Lihao Liang, paulmck, Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
Hi Lihao,
On 2017/11/29 10:48, Lihao Liang wrote:
> Hi Paul,
>
> Signed-off-by: Lihao Liang <lihao.liang@gmail.com>
...
>
> Many thanks,
> Lihao.
>
> On 2017/11/29 9:14, Paul E. McKenney wrote:
>> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
>>> Hi Paul,
>>>
>>> Commit
>>>
>>> d7e182c9c324 ("rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()")
>>>
>>> is missing a Signed-off-by from its author.
>> Good catch, Stephen!
>>
>> Lihao, would you please get me you Signed-off-by? The patch is below.
>>
>> Thanx, Paul
>>
>> ------------------------------------------------------------------------
>>
>> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
>> Author: Liang Lihao <lianglihao@huawei.com>
So it's better to keep the author and Signed-off-by the same :)
Thanks
Hanjun
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rcu tree
2017-11-29 1:14 ` Paul E. McKenney
@ 2017-11-29 2:48 ` Lihao Liang
2017-11-29 3:14 ` Hanjun Guo
0 siblings, 1 reply; 14+ messages in thread
From: Lihao Liang @ 2017-11-29 2:48 UTC (permalink / raw)
To: paulmck, Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Hanjun Guo
Hi Paul,
Signed-off-by: Lihao Liang <lihao.liang@gmail.com>
Many thanks,
Lihao.
On 2017/11/29 9:14, Paul E. McKenney wrote:
> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
>> Hi Paul,
>>
>> Commit
>>
>> d7e182c9c324 ("rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()")
>>
>> is missing a Signed-off-by from its author.
>
> Good catch, Stephen!
>
> Lihao, would you please get me you Signed-off-by? The patch is below.
>
> Thanx, Paul
>
> ------------------------------------------------------------------------
>
> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
> Author: Liang Lihao <lianglihao@huawei.com>
> Date: Wed Nov 22 19:00:55 2017 +0000
>
> rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()
>
> Since rcu_boot_init_percpu_data() is only called at boot time,
> there is no data race and spinlock is not needed.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 69722817d6d6..0abe1db53d70 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -3636,12 +3636,9 @@ static void rcu_init_new_rnp(struct rcu_node *rnp_leaf)
> static void __init
> rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
> {
> - unsigned long flags;
> struct rcu_data *rdp = per_cpu_ptr(rsp->rda, cpu);
> - struct rcu_node *rnp = rcu_get_root(rsp);
>
> /* Set up local state, ensuring consistent view of global state. */
> - raw_spin_lock_irqsave_rcu_node(rnp, flags);
> rdp->grpmask = leaf_node_cpu_bit(rdp->mynode, cpu);
> rdp->dynticks = &per_cpu(rcu_dynticks, cpu);
> WARN_ON_ONCE(rdp->dynticks->dynticks_nesting != 1);
> @@ -3649,7 +3646,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
> rdp->cpu = cpu;
> rdp->rsp = rsp;
> rcu_boot_init_nocb_percpu_data(rdp);
> - raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
> }
>
> /*
>
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: linux-next: Signed-off-by missing for commit in the rcu tree
2017-11-29 0:51 Stephen Rothwell
@ 2017-11-29 1:14 ` Paul E. McKenney
2017-11-29 2:48 ` Lihao Liang
0 siblings, 1 reply; 14+ messages in thread
From: Paul E. McKenney @ 2017-11-29 1:14 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Liang Lihao
On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
> Hi Paul,
>
> Commit
>
> d7e182c9c324 ("rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()")
>
> is missing a Signed-off-by from its author.
Good catch, Stephen!
Lihao, would you please get me you Signed-off-by? The patch is below.
Thanx, Paul
------------------------------------------------------------------------
commit d7e182c9c32480c1f579dd888ac50e88bfb39596
Author: Liang Lihao <lianglihao@huawei.com>
Date: Wed Nov 22 19:00:55 2017 +0000
rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()
Since rcu_boot_init_percpu_data() is only called at boot time,
there is no data race and spinlock is not needed.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 69722817d6d6..0abe1db53d70 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3636,12 +3636,9 @@ static void rcu_init_new_rnp(struct rcu_node *rnp_leaf)
static void __init
rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
{
- unsigned long flags;
struct rcu_data *rdp = per_cpu_ptr(rsp->rda, cpu);
- struct rcu_node *rnp = rcu_get_root(rsp);
/* Set up local state, ensuring consistent view of global state. */
- raw_spin_lock_irqsave_rcu_node(rnp, flags);
rdp->grpmask = leaf_node_cpu_bit(rdp->mynode, cpu);
rdp->dynticks = &per_cpu(rcu_dynticks, cpu);
WARN_ON_ONCE(rdp->dynticks->dynticks_nesting != 1);
@@ -3649,7 +3646,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
rdp->cpu = cpu;
rdp->rsp = rsp;
rcu_boot_init_nocb_percpu_data(rdp);
- raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
}
/*
^ permalink raw reply [flat|nested] 14+ messages in thread
* linux-next: Signed-off-by missing for commit in the rcu tree
@ 2017-11-29 0:51 Stephen Rothwell
2017-11-29 1:14 ` Paul E. McKenney
0 siblings, 1 reply; 14+ messages in thread
From: Stephen Rothwell @ 2017-11-29 0:51 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Liang Lihao
Hi Paul,
Commit
d7e182c9c324 ("rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, back to index
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-30 13:48 linux-next: Signed-off-by missing for commit in the rcu tree Stephen Rothwell
2017-07-30 16:57 ` Paul E. McKenney
2017-11-29 0:51 Stephen Rothwell
2017-11-29 1:14 ` Paul E. McKenney
2017-11-29 2:48 ` Lihao Liang
2017-11-29 3:14 ` Hanjun Guo
2017-11-29 3:29 ` Lihao Liang
2017-11-29 20:54 ` Paul E. McKenney
2018-02-26 22:38 Stephen Rothwell
2018-02-26 23:22 ` Paul E. McKenney
2018-04-23 21:48 Stephen Rothwell
2018-04-23 22:16 ` Paul E. McKenney
2019-10-28 20:53 Stephen Rothwell
2019-10-29 0:37 ` Paul E. McKenney
Linux-Next Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
linux-next@vger.kernel.org
public-inbox-index linux-next
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git