From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Rothwell Subject: Re: linux-next: Signed-off-by missing for commit in the kvm tree Date: Sat, 12 Aug 2017 00:01:46 +1000 Message-ID: <20170812000146.0d133ee6@canb.auug.org.au> References: <20170811092816.01875df0@canb.auug.org.au> <31a4ba52-fc76-7844-841c-5f15142d473d@redhat.com> <20170811123623.GA28649@flask> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from ozlabs.org ([103.22.144.67]:60907 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752765AbdHKOBs (ORCPT ); Fri, 11 Aug 2017 10:01:48 -0400 In-Reply-To: <20170811123623.GA28649@flask> Sender: linux-next-owner@vger.kernel.org List-ID: To: Radim =?UTF-8?B?S3LEjW3DocWZ?= Cc: David Hildenbrand , Marcelo Tosatti , Gleb Natapov , KVM , Linux-Next Mailing List , Linux Kernel Mailing List , Paolo Bonzini Hi Radim, On Fri, 11 Aug 2017 14:36:24 +0200 Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > > Should all rebases be done with the --signoff option? More or less. rebase with the --signoff option will add a duplicate Signed-off-by unless the already existing one is last in the current commit. Linus has said that doing a rebase is no different to applying a patch, so a new committer needs to add a Signed-off-by tag. --=20 Cheers, Stephen Rothwell