Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Kirill Smelkov <kirr@nexedi.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	David Miller <davem@davemloft.net>,
	Networking <netdev@vger.kernel.org>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: linux-next: Signed-off-by missing for commit in the net-next tree
Date: Wed, 1 Nov 2017 15:15:07 +0300
Message-ID: <20171101121507.vzyklrtx6buwy7z6@deco.navytux.spb.ru> (raw)
In-Reply-To: <20171101105524.GA23073@electric-eye.fr.zoreil.com>

Francois,

On Wed, Nov 01, 2017 at 11:55:24AM +0100, Francois Romieu wrote:
> Kirill Smelkov <kirr@nexedi.com> :
> [...]
> > I was keeping you in To and Cc all the time but got no reply at all since my
> > first posting from ~ 1 month ago.
> 
> I thought it was longer than that. Sorry for the frustrating excess delay.
> 
> As Eric already said there is no problem and I am perfectly fine with
> the current attribution of this code.

Thanks for feedback.

> Use of errno.h::ELNRNG is really unusual but it's a different topic.

I wanted the error returned due to internal inconsistency to be different
from the error returned when there is error in provided parameters from
ethtool.

Your original patch was returning EINVAL for both cases which made it
hard to understand what is going on when the kernel was refusing to
accept something from user.

That's why I used ELNRNG (link number out of range) for situation when
lookup of timings vector by current link speed failed. A bit unusual,
yes, but this was the closest to the situation after studying `errno -l`
output.

Hope this clarifies a bit.

Please feel free to suggest a change here,
Kirill

  reply index

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31  5:40 Stephen Rothwell
2017-10-31  6:14 ` Kirill Smelkov
2017-10-31  6:20   ` Eric Dumazet
2017-11-01 10:55   ` Francois Romieu
2017-11-01 12:15     ` Kirill Smelkov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-10-31  7:10 Stephen Rothwell
2019-10-31 17:40 ` David Miller
2019-10-31 18:40   ` Jeff Kirsher
2019-10-30  7:42 Stephen Rothwell
2019-10-02 22:06 Stephen Rothwell
2019-10-02 22:12 ` Randy Dunlap
2019-09-10 14:42 Stephen Rothwell
2019-09-11  5:24 ` Luciano Coelho
2019-09-10 14:41 Stephen Rothwell
2019-09-11  9:02 ` Oleksij Rempel
2019-08-06 23:30 Stephen Rothwell
2019-08-06 23:37 ` Yifeng Sun
2019-08-07  1:54   ` Stephen Rothwell
2019-08-07  2:02     ` Yifeng Sun
2019-07-09 21:36 Stephen Rothwell
2019-01-16 21:06 Stephen Rothwell
2019-01-16 22:13 ` David Miller
     [not found] ` <CALqoU4ywdKaeD_DX4pF2hOTh-LQb2N+zGhap6x4sskaf_YthJw@mail.gmail.com>
2019-01-16 23:09   ` David Miller
2018-10-01 23:34 Stephen Rothwell
2018-09-02 21:40 Stephen Rothwell
2018-09-03  5:08 ` Vakul Garg
2018-09-03  5:16   ` David Miller
2018-09-03  5:21   ` Stephen Rothwell
2018-07-28  4:21 Stephen Rothwell
2018-05-13 22:02 Stephen Rothwell
2017-11-12 20:44 Stephen Rothwell
2017-09-28 21:46 Stephen Rothwell
2017-08-30 16:51 Stephen Rothwell
2017-08-30 16:53 ` David Ahern
2017-08-30 17:38   ` Stephen Rothwell
2017-08-30 17:52   ` David Miller

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171101121507.vzyklrtx6buwy7z6@deco.navytux.spb.ru \
    --to=kirr@nexedi.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git