From: Andrew Morton <akpm@linux-foundation.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-next@vger.kernel.org, sfr@canb.auug.org.au, mhocko@suse.cz,
broonie@kernel.org, Yury Norov <ynorov@caviumnetworks.com>
Subject: Re: mmotm 2017-11-10-15-56 uploaded (lib/test_find_bit.c)
Date: Mon, 13 Nov 2017 16:17:41 -0800 [thread overview]
Message-ID: <20171113161741.5feaa74b30527f05b1684d10@linux-foundation.org> (raw)
In-Reply-To: <2ce9cf55-2b54-b6cd-fa4d-3cd0a354b5f1@infradead.org>
On Fri, 10 Nov 2017 18:00:57 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:
> On 11/10/2017 03:56 PM, akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2017-11-10-15-56 has been uploaded to
> >
> > http://www.ozlabs.org/~akpm/mmotm/
> >
> > mmotm-readme.txt says
> >
> > README for mm-of-the-moment:
> >
> > http://www.ozlabs.org/~akpm/mmotm/
> >
> > This is a snapshot of my -mm patch queue. Uploaded at random hopefully
> > more than once a week.
>
> on i386:
>
> ../lib/test_find_bit.c:54:2: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'cycles_t' [-Wformat=]
> ../lib/test_find_bit.c:68:2: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'cycles_t' [-Wformat=]
> ../lib/test_find_bit.c:82:2: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'cycles_t' [-Wformat=]
> ../lib/test_find_bit.c:102:2: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'cycles_t' [-Wformat=]
typecasts, I guess? We don't seem to have a %p thingy for cycles_t?
--- a/lib/test_find_bit.c~lib-test-module-for-find__bit-functions-fix
+++ a/lib/test_find_bit.c
@@ -51,7 +51,8 @@ static int __init test_find_first_bit(vo
__clear_bit(i, bitmap);
}
cycles = get_cycles() - cycles;
- pr_err("find_first_bit:\t\t%ld cycles,\t%ld iterations\n", cycles, cnt);
+ pr_err("find_first_bit:\t\t%ld cycles,\t%ld iterations\n",
+ (long)cycles, cnt);
return 0;
}
@@ -65,7 +66,8 @@ static int __init test_find_next_bit(con
for (cnt = i = 0; i < BITMAP_LEN; cnt++)
i = find_next_bit(bitmap, BITMAP_LEN, i) + 1;
cycles = get_cycles() - cycles;
- pr_err("find_next_bit:\t\t%ld cycles,\t%ld iterations\n", cycles, cnt);
+ pr_err("find_next_bit:\t\t%ld cycles,\t%ld iterations\n",
+ (long)cycles, cnt);
return 0;
}
@@ -80,7 +82,7 @@ static int __init test_find_next_zero_bi
i = find_next_zero_bit(bitmap, len, i) + 1;
cycles = get_cycles() - cycles;
pr_err("find_next_zero_bit:\t%ld cycles,\t%ld iterations\n",
- cycles, cnt);
+ (long)cycles, cnt);
return 0;
}
@@ -99,7 +101,8 @@ static int __init test_find_last_bit(con
len = l;
} while (len);
cycles = get_cycles() - cycles;
- pr_err("find_last_bit:\t\t%ld cycles,\t%ld iterations\n", cycles, cnt);
+ pr_err("find_last_bit:\t\t%ld cycles,\t%ld iterations\n",
+ (long)cycles, cnt);
return 0;
}
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-14 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 23:56 mmotm 2017-11-10-15-56 uploaded akpm
2017-11-11 2:00 ` mmotm 2017-11-10-15-56 uploaded (lib/test_find_bit.c) Randy Dunlap
2017-11-14 0:17 ` Andrew Morton [this message]
2017-11-14 0:26 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113161741.5feaa74b30527f05b1684d10@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=ynorov@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).