From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Liang Lihao <lianglihao@huawei.com>
Subject: Re: linux-next: Signed-off-by missing for commit in the rcu tree
Date: Tue, 28 Nov 2017 17:14:29 -0800 [thread overview]
Message-ID: <20171129011429.GB3624@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171129115151.40b72764@canb.auug.org.au>
On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
> Hi Paul,
>
> Commit
>
> d7e182c9c324 ("rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()")
>
> is missing a Signed-off-by from its author.
Good catch, Stephen!
Lihao, would you please get me you Signed-off-by? The patch is below.
Thanx, Paul
------------------------------------------------------------------------
commit d7e182c9c32480c1f579dd888ac50e88bfb39596
Author: Liang Lihao <lianglihao@huawei.com>
Date: Wed Nov 22 19:00:55 2017 +0000
rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()
Since rcu_boot_init_percpu_data() is only called at boot time,
there is no data race and spinlock is not needed.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 69722817d6d6..0abe1db53d70 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3636,12 +3636,9 @@ static void rcu_init_new_rnp(struct rcu_node *rnp_leaf)
static void __init
rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
{
- unsigned long flags;
struct rcu_data *rdp = per_cpu_ptr(rsp->rda, cpu);
- struct rcu_node *rnp = rcu_get_root(rsp);
/* Set up local state, ensuring consistent view of global state. */
- raw_spin_lock_irqsave_rcu_node(rnp, flags);
rdp->grpmask = leaf_node_cpu_bit(rdp->mynode, cpu);
rdp->dynticks = &per_cpu(rcu_dynticks, cpu);
WARN_ON_ONCE(rdp->dynticks->dynticks_nesting != 1);
@@ -3649,7 +3646,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
rdp->cpu = cpu;
rdp->rsp = rsp;
rcu_boot_init_nocb_percpu_data(rdp);
- raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
}
/*
next prev parent reply other threads:[~2017-11-29 1:14 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 0:51 linux-next: Signed-off-by missing for commit in the rcu tree Stephen Rothwell
2017-11-29 1:14 ` Paul E. McKenney [this message]
2017-11-29 2:48 ` Lihao Liang
2017-11-29 3:14 ` Hanjun Guo
2017-11-29 3:29 ` Lihao Liang
2017-11-29 20:54 ` Paul E. McKenney
-- strict thread matches above, loose matches on Subject: below --
2024-02-07 20:39 Stephen Rothwell
2024-02-08 16:07 ` Paul E. McKenney
2023-06-08 22:31 Stephen Rothwell
2023-06-09 19:00 ` Paul E. McKenney
2023-06-08 22:27 Stephen Rothwell
2023-06-08 22:28 ` Stephen Rothwell
2023-06-09 4:08 ` Zhangjin Wu
2023-06-09 9:24 ` Willy Tarreau
2023-05-16 22:41 Stephen Rothwell
2023-05-16 22:54 ` Paul E. McKenney
2023-03-08 2:16 Stephen Rothwell
2023-03-08 17:41 ` Paul E. McKenney
2022-09-22 10:12 Stephen Rothwell
2022-09-22 13:55 ` Paul E. McKenney
2022-01-03 21:38 Stephen Rothwell
2022-01-03 23:33 ` Paul E. McKenney
2021-05-23 3:02 Stephen Rothwell
2021-05-24 3:49 ` Paul E. McKenney
2021-03-08 6:03 Stephen Rothwell
2021-03-09 5:24 ` Paul E. McKenney
2021-01-10 2:24 Stephen Rothwell
2021-01-10 5:15 ` Paul E. McKenney
2020-11-22 10:08 Stephen Rothwell
2020-11-22 10:09 ` Stephen Rothwell
2020-11-22 17:51 ` Paul E. McKenney
2020-09-29 22:37 Stephen Rothwell
2020-09-30 4:43 ` Paul E. McKenney
2020-09-17 3:26 Stephen Rothwell
2020-09-17 18:00 ` Paul E. McKenney
2020-09-22 22:35 ` Stephen Rothwell
2020-09-28 7:57 ` Peter Zijlstra
2020-09-28 17:33 ` Paul E. McKenney
2020-11-18 23:40 ` Paul E. McKenney
2020-02-12 22:25 Stephen Rothwell
2020-02-13 21:38 ` Joel Fernandes
2020-02-27 15:10 ` Paul E. McKenney
2019-10-28 20:53 Stephen Rothwell
2019-10-29 0:37 ` Paul E. McKenney
2018-04-23 21:48 Stephen Rothwell
2018-04-23 22:16 ` Paul E. McKenney
2018-02-26 22:38 Stephen Rothwell
2018-02-26 23:22 ` Paul E. McKenney
2017-07-30 13:48 Stephen Rothwell
2017-07-30 16:57 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129011429.GB3624@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=lianglihao@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).