From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] leds: pm8058: Make ledtype pointer sized type Date: Thu, 30 Nov 2017 08:31:31 +0000 Message-ID: <20171130083131.kjgehcutqsbkjxr5@dell> References: <20171130113516.42c8bde2@canb.auug.org.au> <20171130030543.1071-1-bjorn.andersson@linaro.org> <20171130082940.5mzslaxv53dlu3t2@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:36355 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902AbdK3Ibf (ORCPT ); Thu, 30 Nov 2017 03:31:35 -0500 Received: by mail-wm0-f67.google.com with SMTP id b76so10791309wmg.1 for ; Thu, 30 Nov 2017 00:31:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171130082940.5mzslaxv53dlu3t2@dell> Sender: linux-next-owner@vger.kernel.org List-ID: To: Bjorn Andersson Cc: Richard Purdie , Jacek Anaszewski , Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Stephen Rothwell , Linux-Next Mailing List On Thu, 30 Nov 2017, Lee Jones wrote: > On Wed, 29 Nov 2017, Bjorn Andersson wrote: > > > The pointer returned by of_device_get_match_data() doesn't have the same > > size as u32 on 64-bit architectures, causing issues when compile testing > > the driver on such platform. Make ledtype unsigned long instead, to > > solve this problem. > > > > Fixes: 7f866986e705 ("leds: add PM8058 LEDs driver") > > Cc: Linus Walleij > > Signed-off-by: Bjorn Andersson > > --- > > drivers/leds/leds-pm8058.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Hi Bjorn, > > (Nice to see you) :) > > I'm going to apply this *before* Linus' fix. > > Applied, thanks. After I rx an Ack from Richard, Jacek or Pavel of course. :) Will send a pull-request. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog