linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ching Huang <ching2048@areca.com.tw>,
	Kees Cook <keescook@chromium.org>
Subject: linux-next: manual merge of the scsi-mkp tree with Linus' tree
Date: Thu, 30 Nov 2017 12:51:21 +1100	[thread overview]
Message-ID: <20171130125121.7d16ef43@canb.auug.org.au> (raw)

Hi Martin,

Today's linux-next merge of the scsi-mkp tree got a conflict in:

  drivers/scsi/arcmsr/arcmsr_hba.c

between commits:

  b9eaf1872222 ("treewide: init_timer() -> setup_timer()")
  e99e88a9d2b0 ("treewide: setup_timer() -> timer_setup()")

from Linus' tree and commits:

  ee09098d4769 ("scsi: arcmsr: add a function arcmsr_set_iop_datetime and driver option set_date_time to set date and time to firmware")
  1b19ea2998c4 ("scsi: arcmsr: spin off duplicate code of timer init for message isr BH in arcmsr_probe and arcmsr_resume as a function")

from the scsi-mkp tree.

I fixed it up (I think I gto it right - see below) and can carry the
fix as necessary. This is now fixed as far as linux-next is concerned,
but any non trivial conflicts should be mentioned to your upstream
maintainer when your tree is submitted for merging.  You may also want
to consider cooperating with the maintainer of the conflicting tree to
minimise any particularly complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/scsi/arcmsr/arcmsr_hba.c
index 21f6421536a0,2aec32ff8109..000000000000
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@@ -755,6 -857,28 +857,24 @@@ out_free_irq
  	return FAILED;
  }
  
+ static void arcmsr_init_get_devmap_timer(struct AdapterControlBlock *pacb)
+ {
+ 	INIT_WORK(&pacb->arcmsr_do_message_isr_bh, arcmsr_message_isr_bh_fn);
+ 	atomic_set(&pacb->rq_map_token, 16);
+ 	atomic_set(&pacb->ante_token_value, 16);
+ 	pacb->fw_flag = FW_NORMAL;
 -	init_timer(&pacb->eternal_timer);
++	timer_setup(&pacb->eternal_timer, arcmsr_request_device_map, 0);
+ 	pacb->eternal_timer.expires = jiffies + msecs_to_jiffies(6 * HZ);
 -	pacb->eternal_timer.data = (unsigned long)pacb;
 -	pacb->eternal_timer.function = &arcmsr_request_device_map;
+ 	add_timer(&pacb->eternal_timer);
+ }
+ 
+ static void arcmsr_init_set_datetime_timer(struct AdapterControlBlock *pacb)
+ {
 -	init_timer(&pacb->refresh_timer);
++	timer_setup(&pacb->eternal_timer, arcmsr_request_device_map, 0);
+ 	pacb->refresh_timer.expires = jiffies + msecs_to_jiffies(60 * 1000);
 -	pacb->refresh_timer.data = (unsigned long)pacb;
 -	pacb->refresh_timer.function = &arcmsr_set_iop_datetime;
+ 	add_timer(&pacb->refresh_timer);
+ }
+ 
  static int arcmsr_probe(struct pci_dev *pdev, const struct pci_device_id *id)
  {
  	struct Scsi_Host *host;

             reply	other threads:[~2017-11-30  1:51 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30  1:51 Stephen Rothwell [this message]
2017-11-30  1:55 ` linux-next: manual merge of the scsi-mkp tree with Linus' tree Stephen Rothwell
2017-12-01  2:14   ` Martin K. Petersen
2017-12-01  3:42     ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2023-08-28  3:02 Stephen Rothwell
2023-09-01  0:23 ` Karan Tilak Kumar (kartilak)
2023-03-20  1:16 Stephen Rothwell
2022-02-14  3:29 Stephen Rothwell
2022-02-14  8:57 ` John Garry
2021-12-08  3:32 Stephen Rothwell
2021-10-06  4:44 Stephen Rothwell
2021-08-11  5:40 Stephen Rothwell
2021-08-11  5:53 ` Sreekanth Reddy
2021-08-12  3:25 ` Martin K. Petersen
2020-09-03  5:21 Stephen Rothwell
2020-09-02  5:15 Stephen Rothwell
2020-09-02  5:12 Stephen Rothwell
2020-09-11  4:47 ` Stephen Rothwell
2020-06-10  2:17 Stephen Rothwell
2020-06-11  2:12 ` Stephen Rothwell
2019-02-11  4:31 Stephen Rothwell
2019-02-11  9:24 ` John Garry
2019-02-07  4:44 Stephen Rothwell
2019-02-07 18:30 ` James Smart
2018-12-10  6:17 Stephen Rothwell
2018-12-10  7:09 ` Stephen Rothwell
2018-10-18  4:15 Stephen Rothwell
2018-08-03  6:22 Stephen Rothwell
2018-08-03  6:04 Stephen Rothwell
2018-07-11  4:04 Stephen Rothwell
2018-07-12  4:29 ` Stephen Rothwell
2018-03-22  5:54 Stephen Rothwell
2017-09-01  4:48 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130125121.7d16ef43@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=ching2048@areca.com.tw \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).