From: Lee Jones <lee.jones@linaro.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux-Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH v2] leds: pm8058: Silence pointer to integer size warning
Date: Fri, 1 Dec 2017 08:56:01 +0000 [thread overview]
Message-ID: <20171201085601.ielbzvwbbxkmgl27@dell> (raw)
In-Reply-To: <20171201083642.GA4960@amd>
On Fri, 01 Dec 2017, Pavel Machek wrote:
> On Fri 2017-12-01 07:57:15, Lee Jones wrote:
> > On Thu, 30 Nov 2017, Bjorn Andersson wrote:
> > > - led->ledtype = (u32)of_device_get_match_data(&pdev->dev);
> > > + led->ledtype = (u32)(unsigned long)of_device_get_match_data(&pdev->dev);
> >
> > Wouldn't (u32)(void *) be even more correct?
> >
> > ... if the compiler will let you get away with it.
>
> Afaict that would still produce the warning. of_device_get_match_data
> already returns void *.
Just tested. It actually still suffers from the original error.
warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-12-01 8:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 0:35 linux-next: build warning after merge of the mfd tree Stephen Rothwell
2017-11-30 3:05 ` [PATCH] leds: pm8058: Make ledtype pointer sized type Bjorn Andersson
2017-11-30 8:29 ` Lee Jones
2017-11-30 8:31 ` Lee Jones
2017-11-30 22:02 ` Jacek Anaszewski
2017-12-01 7:56 ` Lee Jones
2017-12-01 20:35 ` Jacek Anaszewski
2017-11-30 9:18 ` Linus Walleij
2017-11-30 9:41 ` Lee Jones
2017-11-30 9:40 ` Pavel Machek
2017-11-30 21:58 ` Jacek Anaszewski
2017-11-30 22:34 ` Pavel Machek
2017-11-30 23:14 ` Stephen Rothwell
2017-12-01 0:28 ` Pavel Machek
2017-12-01 5:10 ` Bjorn Andersson
2017-11-30 22:18 ` Bjorn Andersson
2017-11-30 8:28 ` linux-next: build warning after merge of the mfd tree Lee Jones
2017-12-01 5:16 ` [PATCH v2] leds: pm8058: Silence pointer to integer size warning Bjorn Andersson
2017-12-01 7:57 ` Lee Jones
2017-12-01 8:36 ` Pavel Machek
2017-12-01 8:56 ` Lee Jones [this message]
2017-12-01 8:56 ` Lee Jones
2017-12-01 9:01 ` [GIT PULL] Immutable branch between MFD and LED due for the v4.16 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201085601.ielbzvwbbxkmgl27@dell \
--to=lee.jones@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).