From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2] misc: mic: Use memdup_user() as a cleanup Date: Tue, 12 Dec 2017 12:49:37 +0100 Message-ID: <20171212114937.GA23534@kroah.com> References: <20171212143910.146724d2@canb.auug.org.au> <1513075258-10860-1-git-send-email-gomonovych@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from out3-smtp.messagingengine.com ([66.111.4.27]:41079 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853AbdLLLta (ORCPT ); Tue, 12 Dec 2017 06:49:30 -0500 Content-Disposition: inline In-Reply-To: <1513075258-10860-1-git-send-email-gomonovych@gmail.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Vasyl Gomonovych Cc: sfr@canb.auug.org.au, arnd@arndb.de, sudeep.dutt@intel.com, ashutosh.dixit@intel.com, dan.carpenter@oracle.com, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org On Tue, Dec 12, 2017 at 11:40:58AM +0100, Vasyl Gomonovych wrote: > Fix coccicheck warning which recommends to use memdup_user(): > > drivers/misc/mic/vop/vop_vringh.c:940:14-21: WARNING opportunity for memdup_user > drivers/misc/mic/vop/vop_vringh.c:998:8-15: WARNING opportunity for memdup_user > > Generated by: scripts/coccinelle/memdup_user/memdup_user.cocci > > Changelog: > - v1: > - Replace kzalloc + copy_from_user on memdup_user > - v2: > - Clear forgotten done label > After merging the char-misc tree, today's linux-next build > (x86_64_allmodconfig) produced this warning: > drivers/misc/mic/vop/vop_vringh.c: In function 'vop_ioctl': > drivers/misc/mic/vop/vop_vringh.c:1001:1: warning: label 'done' defined but not used [-Wunused-label] Will not work as I already have taken v1. Also, put the changelog below the --- line please. thanks, greg k-h