linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the staging.current tree
@ 2017-12-14  6:00 Stephen Rothwell
  2017-12-14  7:27 ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2017-12-14  6:00 UTC (permalink / raw)
  To: Greg KH; +Cc: Linux-Next Mailing List, Linux Kernel Mailing List, John Stultz

Hi Greg,

After merging the staging.current tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/android/ion/ion_cma_heap.c: In function 'ion_cma_allocate':
drivers/staging/android/ion/ion_cma_heap.c:38:14: error: 'CONFIG_CMA_ALIGNMENT' undeclared (first use in this function)
  if (align > CONFIG_CMA_ALIGNMENT)
              ^

Caused by commit

  d98e6dbf42f7 ("staging: ion: Fix ion_cma_heap allocations")

CONFIG_CMA_ALIGNMENT (and CONFIG_DMA_CMA) is not set for this build.

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build failure after merge of the staging.current tree
  2017-12-14  6:00 linux-next: build failure after merge of the staging.current tree Stephen Rothwell
@ 2017-12-14  7:27 ` Greg KH
  0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2017-12-14  7:27 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, John Stultz

On Thu, Dec 14, 2017 at 05:00:33PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the staging.current tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/staging/android/ion/ion_cma_heap.c: In function 'ion_cma_allocate':
> drivers/staging/android/ion/ion_cma_heap.c:38:14: error: 'CONFIG_CMA_ALIGNMENT' undeclared (first use in this function)
>   if (align > CONFIG_CMA_ALIGNMENT)
>               ^
> 
> Caused by commit
> 
>   d98e6dbf42f7 ("staging: ion: Fix ion_cma_heap allocations")
> 
> CONFIG_CMA_ALIGNMENT (and CONFIG_DMA_CMA) is not set for this build.
> 
> I have reverted that commit for today.

Thanks, and sorry about that.  John is working on a fix...

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build failure after merge of the staging.current tree
  2011-06-08 16:11 ` Greg KH
@ 2011-06-08 16:58   ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2011-06-08 16:58 UTC (permalink / raw)
  To: Greg KH
  Cc: Stephen Rothwell, linux-next, linux-kernel, Igor M. Liplianin,
	Linux Media Mailing List

Hi Greg,

Em 08-06-2011 13:11, Greg KH escreveu:
> On Wed, Jun 08, 2011 at 11:41:30AM +1000, Stephen Rothwell wrote:
>> Hi Greg,
>>
>> After merging the staging.current tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/media/video/cx23885/cx23885-cards.c:28:28: fatal error: staging/altera.h: No such file or directory
>>
>> Caused by commit 85ab9ee946da ("Staging: altera: move .h file to proper
>> place").
>>
>> I have used the staging.current tree from next-20110607 for today.
> 
> Ok, sorry about that.
> 
> Mauro, Igor, why would another driver need to reference a .h file of a
> staging driver?  I'll patch it right now to point to the proper place
> (down in the staging tree), but it would be good to resolve this
> "properly" somehow.
> 
> Next time, please never include a staging driver that isn't
> self-contained, and don't create include/staging/ that's not acceptable.

The altera driver were discussed for about two kernel cycles. When it was
about to be merged upstrem, two people complained about having a FPGA firmware 
driver inside the Linux Kernel. However, this driver is essential in order to load
the firmware for a DVB device. So, to avoid postponing the merge for yet another
kernel cycle, I've moved the offending part to staging, and asked for those
two people to provide us a new solution up to the next merge window, otherwise, it
would be moved it to the proper place.

Basically, this driver is used to load the FPGA firmware for the CI module that 
de-scrambles DVB-C/DVB-T/DVB-S streams, used by some cx23885 devices.

Basically, cx23885 gets the firmware file via request_firmware() and uses the
altera module to load it. After loaded, the altera-ci driver implements the logic
to talk with the CI hardware.

There's no Coding Style or any other troubles on this driver that I'm aware,
except that the altera driver also allows loading FPGA firmwares via LPT port.

The main argue is that there are some userspace tools available to program a
FPGA hardware, but the problem is that the cx23885 needs to command the firmware
load, as it needs to occur when the device is booted (or resumed).

There were some discussions about that at LKML:
	https://lkml.org/lkml/2011/3/7/270

>From my side, I think that the driver is doing the right approach. Using a different
logic will make harder to sync userspace with kernelspace and will require an
specialized userspace application for just a few device types (just two of the
30 boards supported by cx23885 currently needs it).

Igor,

Could you please prepare a patch against linux-next moving it to the proper place?
It is probably better to apply such patch at Greg's tree, as he has two patches
touching at the altera include files. Also, please get rid of the parallel port
support, as you don't need it for cx23885.

Thanks,
Mauro.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build failure after merge of the staging.current tree
  2011-06-08  1:41 Stephen Rothwell
  2011-06-08 16:11 ` Greg KH
@ 2011-06-08 16:21 ` Greg KH
  1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2011-06-08 16:21 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Mauro Carvalho Chehab, Igor M. Liplianin

On Wed, Jun 08, 2011 at 11:41:30AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the staging.current tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/media/video/cx23885/cx23885-cards.c:28:28: fatal error: staging/altera.h: No such file or directory
> 
> Caused by commit 85ab9ee946da ("Staging: altera: move .h file to proper
> place").

Now resolved, it should be fine for you to pull from for the next
linux-next release.

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build failure after merge of the staging.current tree
  2011-06-08  1:41 Stephen Rothwell
@ 2011-06-08 16:11 ` Greg KH
  2011-06-08 16:58   ` Mauro Carvalho Chehab
  2011-06-08 16:21 ` Greg KH
  1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2011-06-08 16:11 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Mauro Carvalho Chehab, Igor M. Liplianin

On Wed, Jun 08, 2011 at 11:41:30AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the staging.current tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/media/video/cx23885/cx23885-cards.c:28:28: fatal error: staging/altera.h: No such file or directory
> 
> Caused by commit 85ab9ee946da ("Staging: altera: move .h file to proper
> place").
> 
> I have used the staging.current tree from next-20110607 for today.

Ok, sorry about that.

Mauro, Igor, why would another driver need to reference a .h file of a
staging driver?  I'll patch it right now to point to the proper place
(down in the staging tree), but it would be good to resolve this
"properly" somehow.

Next time, please never include a staging driver that isn't
self-contained, and don't create include/staging/ that's not acceptable.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: build failure after merge of the staging.current tree
@ 2011-06-08  1:41 Stephen Rothwell
  2011-06-08 16:11 ` Greg KH
  2011-06-08 16:21 ` Greg KH
  0 siblings, 2 replies; 6+ messages in thread
From: Stephen Rothwell @ 2011-06-08  1:41 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-next, linux-kernel, Mauro Carvalho Chehab, Igor M. Liplianin

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Hi Greg,

After merging the staging.current tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/media/video/cx23885/cx23885-cards.c:28:28: fatal error: staging/altera.h: No such file or directory

Caused by commit 85ab9ee946da ("Staging: altera: move .h file to proper
place").

I have used the staging.current tree from next-20110607 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-12-14  7:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-14  6:00 linux-next: build failure after merge of the staging.current tree Stephen Rothwell
2017-12-14  7:27 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2011-06-08  1:41 Stephen Rothwell
2011-06-08 16:11 ` Greg KH
2011-06-08 16:58   ` Mauro Carvalho Chehab
2011-06-08 16:21 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).