linux-next: build warning after merge of the libata tree

linux-next: build warning after merge of the libata tree

[Stephen Rothwell]

Hi Tejun,

After merging the libata tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/phy/broadcom/phy-brcm-sata.c: In function 'brcm_stb_sata_calibrate':
drivers/phy/broadcom/phy-brcm-sata.c:514:24: warning: unused variable 'priv' [-Wunused-variable]
  struct brcm_sata_phy *priv = port->phy_priv;
                        ^~~~

Introduced by commit

  3e507769d15e ("phy: brcm-sata: Implement calibrate callback")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the libata tree

[Serge Semin]

Hello Damien

On Tue, Sep 20, 2022 at 08:56:53AM +0900, Damien Le Moal wrote:
> On 9/19/22 11:40, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the libata tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> > 
> > drivers/ata/ahci_st.c: In function 'st_ahci_probe':
> > drivers/ata/ahci_st.c:147:24: warning: unused variable 'dev' [-Wunused-variable]
> >   147 |         struct device *dev = &pdev->dev;
> >       |                        ^~~
> > 
> > Introduced by commit
> > 
> >   3f74cd046fbe ("ata: libahci_platform: Parse ports-implemented property in resources getter")
> > 
> 

> I pushed a fix for this. I also added a dependency on COMPILE_TEST for
> this driver to avoid a repeat in the future.

I'm sorry for not delivering a quick response to the request. Thanks
for sending the fix. Indeed the dev variable should have been dropped.
I should have checked that after removing a part of the code some
variables could be left unused.

-Sergey

> 
> Thanks.
> 
> -- 
> Damien Le Moal
> Western Digital Research
> 

Re: linux-next: build warning after merge of the libata tree

[Damien Le Moal]

On 9/19/22 11:40, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the libata tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/ata/ahci_st.c: In function 'st_ahci_probe':
> drivers/ata/ahci_st.c:147:24: warning: unused variable 'dev' [-Wunused-variable]
>   147 |         struct device *dev = &pdev->dev;
>       |                        ^~~
> 
> Introduced by commit
> 
>   3f74cd046fbe ("ata: libahci_platform: Parse ports-implemented property in resources getter")
> 

I pushed a fix for this. I also added a dependency on COMPILE_TEST for
this driver to avoid a repeat in the future.

Thanks.

-- 
Damien Le Moal
Western Digital Research

Re: linux-next: build warning after merge of the libata tree

[Damien Le Moal]

On 9/19/22 11:40, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the libata tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/ata/ahci_st.c: In function 'st_ahci_probe':
> drivers/ata/ahci_st.c:147:24: warning: unused variable 'dev' [-Wunused-variable]
>   147 |         struct device *dev = &pdev->dev;
>       |                        ^~~
> 
> Introduced by commit
> 
>   3f74cd046fbe ("ata: libahci_platform: Parse ports-implemented property in resources getter")
> 

Serge,

Can you send an incremental fix for this ? If not possible, I will do it.

-- 
Damien Le Moal
Western Digital Research

linux-next: build warning after merge of the libata tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Hi all,

After merging the libata tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/ata/ahci_st.c: In function 'st_ahci_probe':
drivers/ata/ahci_st.c:147:24: warning: unused variable 'dev' [-Wunused-variable]
  147 |         struct device *dev = &pdev->dev;
      |                        ^~~

Introduced by commit

  3f74cd046fbe ("ata: libahci_platform: Parse ports-implemented property in resources getter")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the libata tree

[Sergey Shtylyov]

On 6/20/22 2:07 PM, Damien Le Moal wrote:

[...]
>>>>> After merging the libata tree, today's linux-next build (powercp
>>>>> ppc64_defconfig) produced this warning:
>>>>>
>>>>> In file included from include/linux/device.h:15,
>>>>>                  from arch/powerpc/include/asm/io.h:27,
>>>>>                  from include/linux/io.h:13,
>>>>>                  from include/linux/irq.h:20,
>>>>>                  from arch/powerpc/include/asm/hardirq.h:6,
>>>>>                  from include/linux/hardirq.h:11,
>>>>>                  from include/linux/highmem.h:11,
>>>>>                  from include/linux/bvec.h:10,
>>>>>                  from include/linux/blk_types.h:10,
>>>>>                  from include/linux/blkdev.h:9,
>>>>>                  from drivers/ata/pata_macio.c:18:
>>>>> drivers/ata/pata_macio.c: In function 'pmac_macio_calc_timing_masks':
>>>>> drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
>>>>>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
>>>>
>>>> 	.
>>>> 	.
>>>> 	.
>>>>
>>>>> Introduced by commit
>>>>>
>>>>>   f0a6d77b351c ("ata: make transfer mode masks *unsigned int*")
>>
>>    Oops, sorry about that!>
>>>> This turned into a build failure in my powerpc allyesconfig build, so I
>>>> reverted the above commit for today.
>>>
>>> I pushed the fix already. It is in ata for-next branch.
>>
>>    Thank you!
>>    Note that your Fixes: tag doesn't look right -- the asterisks are missing
>> in the summary...
> 
> Fixed. Copy-paste from the mailer (build failure report email), the
> asterisks are gone and "unsigned int" shown with bold font. Please stop

   Strange, I'm seeing both asterisks and bold font there. What kind of MUA
do you use? :-)

> with the markdown style emphasis. That creates problems.

   Mhm, OK...

MBR, Sergey

Re: linux-next: build warning after merge of the libata tree

[Sergey Shtylyov]

On 6/20/22 2:07 PM, Damien Le Moal wrote:

[...]
>>>>> After merging the libata tree, today's linux-next build (powercp
>>>>> ppc64_defconfig) produced this warning:
>>>>>
>>>>> In file included from include/linux/device.h:15,
>>>>>                  from arch/powerpc/include/asm/io.h:27,
>>>>>                  from include/linux/io.h:13,
>>>>>                  from include/linux/irq.h:20,
>>>>>                  from arch/powerpc/include/asm/hardirq.h:6,
>>>>>                  from include/linux/hardirq.h:11,
>>>>>                  from include/linux/highmem.h:11,
>>>>>                  from include/linux/bvec.h:10,
>>>>>                  from include/linux/blk_types.h:10,
>>>>>                  from include/linux/blkdev.h:9,
>>>>>                  from drivers/ata/pata_macio.c:18:
>>>>> drivers/ata/pata_macio.c: In function 'pmac_macio_calc_timing_masks':
>>>>> drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
>>>>>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
>>>>
>>>> 	.
>>>> 	.
>>>> 	.
>>>>
>>>>> Introduced by commit
>>>>>
>>>>>   f0a6d77b351c ("ata: make transfer mode masks *unsigned int*")
>>
>>    Oops, sorry about that!>
>>>> This turned into a build failure in my powerpc allyesconfig build, so I
>>>> reverted the above commit for today.
>>>
>>> I pushed the fix already. It is in ata for-next branch.
>>
>>    Thank you!
>>    Note that your Fixes: tag doesn't look right -- the asterisks are missing
>> in the summary...
> 
> Fixed. Copy-paste from the mailer (build failure report email), the
> asterisks are gone and "unsigned int" shown with bold font. Please stop

   Strange, I'm seeing both asterisks and bold font there. What kind of MUA
you use? :-)

> with the markdown style emphasis. That creates problems.

   Mhm, OK...

MBR, Sergey

Re: linux-next: build warning after merge of the libata tree

[Damien Le Moal]

On 6/20/22 19:57, Sergey Shtylyov wrote:
> Hello!
> 
> On 6/20/22 11:53 AM, Damien Le Moal wrote:
> 
> [...]
>>>> After merging the libata tree, today's linux-next build (powercp
>>>> ppc64_defconfig) produced this warning:
>>>>
>>>> In file included from include/linux/device.h:15,
>>>>                  from arch/powerpc/include/asm/io.h:27,
>>>>                  from include/linux/io.h:13,
>>>>                  from include/linux/irq.h:20,
>>>>                  from arch/powerpc/include/asm/hardirq.h:6,
>>>>                  from include/linux/hardirq.h:11,
>>>>                  from include/linux/highmem.h:11,
>>>>                  from include/linux/bvec.h:10,
>>>>                  from include/linux/blk_types.h:10,
>>>>                  from include/linux/blkdev.h:9,
>>>>                  from drivers/ata/pata_macio.c:18:
>>>> drivers/ata/pata_macio.c: In function 'pmac_macio_calc_timing_masks':
>>>> drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
>>>>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
>>>
>>> 	.
>>> 	.
>>> 	.
>>>
>>>> Introduced by commit
>>>>
>>>>   f0a6d77b351c ("ata: make transfer mode masks *unsigned int*")
> 
>    Oops, sorry about that!>
>>> This turned into a build failure in my powerpc allyesconfig build, so I
>>> reverted the above commit for today.
>>
>> I pushed the fix already. It is in ata for-next branch.
> 
>    Thank you!
>    Note that your Fixes: tag doesn't look right -- the asterisks are missing
> in the summary...

Fixed. Copy-paste from the mailer (build failure report email), the
asterisks are gone and "unsigned int" shown with bold font. Please stop
with the markdown style emphasis. That creates problems.

> 
> MBR, Sergey


-- 
Damien Le Moal
Western Digital Research

Re: linux-next: build warning after merge of the libata tree

[Sergey Shtylyov]

Hello!

On 6/20/22 11:53 AM, Damien Le Moal wrote:

[...]
>>> After merging the libata tree, today's linux-next build (powercp
>>> ppc64_defconfig) produced this warning:
>>>
>>> In file included from include/linux/device.h:15,
>>>                  from arch/powerpc/include/asm/io.h:27,
>>>                  from include/linux/io.h:13,
>>>                  from include/linux/irq.h:20,
>>>                  from arch/powerpc/include/asm/hardirq.h:6,
>>>                  from include/linux/hardirq.h:11,
>>>                  from include/linux/highmem.h:11,
>>>                  from include/linux/bvec.h:10,
>>>                  from include/linux/blk_types.h:10,
>>>                  from include/linux/blkdev.h:9,
>>>                  from drivers/ata/pata_macio.c:18:
>>> drivers/ata/pata_macio.c: In function 'pmac_macio_calc_timing_masks':
>>> drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
>>>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
>>
>> 	.
>> 	.
>> 	.
>>
>>> Introduced by commit
>>>
>>>   f0a6d77b351c ("ata: make transfer mode masks *unsigned int*")

   Oops, sorry about that!

>> This turned into a build failure in my powerpc allyesconfig build, so I
>> reverted the above commit for today.
> 
> I pushed the fix already. It is in ata for-next branch.

   Thank you!
   Note that your Fixes: tag doesn't look right -- the asterisks are missing
in the summary...

MBR, Sergey

Re: linux-next: build warning after merge of the libata tree

[Damien Le Moal]

On 6/20/22 17:21, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 20 Jun 2022 10:34:00 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> Hi all,
>>
>> After merging the libata tree, today's linux-next build (powercp
>> ppc64_defconfig) produced this warning:
>>
>> In file included from include/linux/device.h:15,
>>                  from arch/powerpc/include/asm/io.h:27,
>>                  from include/linux/io.h:13,
>>                  from include/linux/irq.h:20,
>>                  from arch/powerpc/include/asm/hardirq.h:6,
>>                  from include/linux/hardirq.h:11,
>>                  from include/linux/highmem.h:11,
>>                  from include/linux/bvec.h:10,
>>                  from include/linux/blk_types.h:10,
>>                  from include/linux/blkdev.h:9,
>>                  from drivers/ata/pata_macio.c:18:
>> drivers/ata/pata_macio.c: In function 'pmac_macio_calc_timing_masks':
>> drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
>>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
> 
> 	.
> 	.
> 	.
> 
>> Introduced by commit
>>
>>   f0a6d77b351c ("ata: make transfer mode masks *unsigned int*")
> 
> This turned into a build failure in my powerpc allyesconfig build, so I
> reverted the above commit for today.

I pushed the fix already. It is in ata for-next branch.

-- 
Damien Le Moal
Western Digital Research

Re: linux-next: build warning after merge of the libata tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

Hi all,

On Mon, 20 Jun 2022 10:34:00 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> After merging the libata tree, today's linux-next build (powercp
> ppc64_defconfig) produced this warning:
> 
> In file included from include/linux/device.h:15,
>                  from arch/powerpc/include/asm/io.h:27,
>                  from include/linux/io.h:13,
>                  from include/linux/irq.h:20,
>                  from arch/powerpc/include/asm/hardirq.h:6,
>                  from include/linux/hardirq.h:11,
>                  from include/linux/highmem.h:11,
>                  from include/linux/bvec.h:10,
>                  from include/linux/blk_types.h:10,
>                  from include/linux/blkdev.h:9,
>                  from drivers/ata/pata_macio.c:18:
> drivers/ata/pata_macio.c: In function 'pmac_macio_calc_timing_masks':
> drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",

	.
	.
	.

> Introduced by commit
> 
>   f0a6d77b351c ("ata: make transfer mode masks *unsigned int*")

This turned into a build failure in my powerpc allyesconfig build, so I
reverted the above commit for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the libata tree

[Damien Le Moal]

On 6/20/22 09:34, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the libata tree, today's linux-next build (powercp
> ppc64_defconfig) produced this warning:

Will fix that.

> 
> In file included from include/linux/device.h:15,
>                  from arch/powerpc/include/asm/io.h:27,
>                  from include/linux/io.h:13,
>                  from include/linux/irq.h:20,
>                  from arch/powerpc/include/asm/hardirq.h:6,
>                  from include/linux/hardirq.h:11,
>                  from include/linux/highmem.h:11,
>                  from include/linux/bvec.h:10,
>                  from include/linux/blk_types.h:10,
>                  from include/linux/blkdev.h:9,
>                  from drivers/ata/pata_macio.c:18:
> drivers/ata/pata_macio.c: In function 'pmac_macio_calc_timing_masks':
> drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
>       |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/dev_printk.h:129:41: note: in definition of macro 'dev_printk'
>   129 |                 _dev_printk(level, dev, fmt, ##__VA_ARGS__);            \
>       |                                         ^~~
> include/linux/dev_printk.h:163:45: note: in expansion of macro 'dev_fmt'
>   163 |                 dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
>       |                                             ^~~~~~~
> drivers/ata/pata_macio.c:1031:9: note: in expansion of macro 'dev_dbg'
>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
>       |         ^~~~~~~
> drivers/ata/pata_macio.c:1031:52: note: format string is defined here
>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
>       |                                                  ~~^
>       |                                                    |
>       |                                                    long unsigned int
>       |                                                  %x
> In file included from include/linux/device.h:15,
>                  from arch/powerpc/include/asm/io.h:27,
>                  from include/linux/io.h:13,
>                  from include/linux/irq.h:20,
>                  from arch/powerpc/include/asm/hardirq.h:6,
>                  from include/linux/hardirq.h:11,
>                  from include/linux/highmem.h:11,
>                  from include/linux/bvec.h:10,
>                  from include/linux/blk_types.h:10,
>                  from include/linux/blkdev.h:9,
>                  from drivers/ata/pata_macio.c:18:
> drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat=]
>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
>       |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/dev_printk.h:129:41: note: in definition of macro 'dev_printk'
>   129 |                 _dev_printk(level, dev, fmt, ##__VA_ARGS__);            \
>       |                                         ^~~
> include/linux/dev_printk.h:163:45: note: in expansion of macro 'dev_fmt'
>   163 |                 dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
>       |                                             ^~~~~~~
> drivers/ata/pata_macio.c:1031:9: note: in expansion of macro 'dev_dbg'
>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
>       |         ^~~~~~~
> drivers/ata/pata_macio.c:1031:63: note: format string is defined here
>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
>       |                                                             ~~^
>       |                                                               |
>       |                                                               long unsigned int
>       |                                                             %x
> In file included from include/linux/device.h:15,
>                  from arch/powerpc/include/asm/io.h:27,
>                  from include/linux/io.h:13,
>                  from include/linux/irq.h:20,
>                  from arch/powerpc/include/asm/hardirq.h:6,
>                  from include/linux/hardirq.h:11,
>                  from include/linux/highmem.h:11,
>                  from include/linux/bvec.h:10,
>                  from include/linux/blk_types.h:10,
>                  from include/linux/blkdev.h:9,
>                  from drivers/ata/pata_macio.c:18:
> drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 6 has type 'unsigned int' [-Wformat=]
>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
>       |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/dev_printk.h:129:41: note: in definition of macro 'dev_printk'
>   129 |                 _dev_printk(level, dev, fmt, ##__VA_ARGS__);            \
>       |                                         ^~~
> include/linux/dev_printk.h:163:45: note: in expansion of macro 'dev_fmt'
>   163 |                 dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
>       |                                             ^~~~~~~
> drivers/ata/pata_macio.c:1031:9: note: in expansion of macro 'dev_dbg'
>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
>       |         ^~~~~~~
> drivers/ata/pata_macio.c:1031:73: note: format string is defined here
>  1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
>       |                                                                       ~~^
>       |                                                                         |
>       |                                                                         long unsigned int
>       |                                                                       %x
> 
> Introduced by commit
> 
>   f0a6d77b351c ("ata: make transfer mode masks *unsigned int*")
> 


-- 
Damien Le Moal
Western Digital Research

linux-next: build warning after merge of the libata tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 6237 bytes --]

Hi all,

After merging the libata tree, today's linux-next build (powercp
ppc64_defconfig) produced this warning:

In file included from include/linux/device.h:15,
                 from arch/powerpc/include/asm/io.h:27,
                 from include/linux/io.h:13,
                 from include/linux/irq.h:20,
                 from arch/powerpc/include/asm/hardirq.h:6,
                 from include/linux/hardirq.h:11,
                 from include/linux/highmem.h:11,
                 from include/linux/bvec.h:10,
                 from include/linux/blk_types.h:10,
                 from include/linux/blkdev.h:9,
                 from drivers/ata/pata_macio.c:18:
drivers/ata/pata_macio.c: In function 'pmac_macio_calc_timing_masks':
drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat=]
 1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:129:41: note: in definition of macro 'dev_printk'
  129 |                 _dev_printk(level, dev, fmt, ##__VA_ARGS__);            \
      |                                         ^~~
include/linux/dev_printk.h:163:45: note: in expansion of macro 'dev_fmt'
  163 |                 dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
      |                                             ^~~~~~~
drivers/ata/pata_macio.c:1031:9: note: in expansion of macro 'dev_dbg'
 1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
      |         ^~~~~~~
drivers/ata/pata_macio.c:1031:52: note: format string is defined here
 1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
      |                                                  ~~^
      |                                                    |
      |                                                    long unsigned int
      |                                                  %x
In file included from include/linux/device.h:15,
                 from arch/powerpc/include/asm/io.h:27,
                 from include/linux/io.h:13,
                 from include/linux/irq.h:20,
                 from arch/powerpc/include/asm/hardirq.h:6,
                 from include/linux/hardirq.h:11,
                 from include/linux/highmem.h:11,
                 from include/linux/bvec.h:10,
                 from include/linux/blk_types.h:10,
                 from include/linux/blkdev.h:9,
                 from drivers/ata/pata_macio.c:18:
drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat=]
 1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:129:41: note: in definition of macro 'dev_printk'
  129 |                 _dev_printk(level, dev, fmt, ##__VA_ARGS__);            \
      |                                         ^~~
include/linux/dev_printk.h:163:45: note: in expansion of macro 'dev_fmt'
  163 |                 dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
      |                                             ^~~~~~~
drivers/ata/pata_macio.c:1031:9: note: in expansion of macro 'dev_dbg'
 1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
      |         ^~~~~~~
drivers/ata/pata_macio.c:1031:63: note: format string is defined here
 1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
      |                                                             ~~^
      |                                                               |
      |                                                               long unsigned int
      |                                                             %x
In file included from include/linux/device.h:15,
                 from arch/powerpc/include/asm/io.h:27,
                 from include/linux/io.h:13,
                 from include/linux/irq.h:20,
                 from arch/powerpc/include/asm/hardirq.h:6,
                 from include/linux/hardirq.h:11,
                 from include/linux/highmem.h:11,
                 from include/linux/bvec.h:10,
                 from include/linux/blk_types.h:10,
                 from include/linux/blkdev.h:9,
                 from drivers/ata/pata_macio.c:18:
drivers/ata/pata_macio.c:1031:28: warning: format '%lx' expects argument of type 'long unsigned int', but argument 6 has type 'unsigned int' [-Wformat=]
 1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:129:41: note: in definition of macro 'dev_printk'
  129 |                 _dev_printk(level, dev, fmt, ##__VA_ARGS__);            \
      |                                         ^~~
include/linux/dev_printk.h:163:45: note: in expansion of macro 'dev_fmt'
  163 |                 dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
      |                                             ^~~~~~~
drivers/ata/pata_macio.c:1031:9: note: in expansion of macro 'dev_dbg'
 1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
      |         ^~~~~~~
drivers/ata/pata_macio.c:1031:73: note: format string is defined here
 1031 |         dev_dbg(priv->dev, "Supported masks: PIO=%lx, MWDMA=%lx, UDMA=%lx\n",
      |                                                                       ~~^
      |                                                                         |
      |                                                                         long unsigned int
      |                                                                       %x

Introduced by commit

  f0a6d77b351c ("ata: make transfer mode masks *unsigned int*")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: build warning after merge of the libata tree

[Richard Zhu]

Hi Stephen:
Sorry to introduce this build warning.
I'm preparing one commit to fix it.

Best Regards
Richard Zhu

-----Original Message-----
From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] 
Sent: Tuesday, March 20, 2018 12:57 PM
To: Tejun Heo <tj@kernel.org>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Richard Zhu <hongxing.zhu@nxp.com>
Subject: linux-next: build warning after merge of the libata tree

Hi Tejun,

After merging the libata tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/ata/ahci_imx.c: In function 'imx_sata_disable':
drivers/ata/ahci_imx.c:478:2: warning: enumeration value 'AHCI_IMX53' not handled in switch [-Wswitch]
  switch (imxpriv->type) {
  ^~~~~~

Introduced by commit

  e5878732a521 ("ahci: imx: add the imx6qp ahci sata support")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the libata tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

Hi Tejun,

After merging the libata tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/ata/ahci_imx.c: In function 'imx_sata_disable':
drivers/ata/ahci_imx.c:478:2: warning: enumeration value 'AHCI_IMX53' not handled in switch [-Wswitch]
  switch (imxpriv->type) {
  ^~~~~~

Introduced by commit

  e5878732a521 ("ahci: imx: add the imx6qp ahci sata support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the libata tree

[Tejun Heo]

On Tue, Feb 13, 2018 at 02:04:49PM +1100, Stephen Rothwell wrote:
> Hi Tejun,
> 
> After merging the libata tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/ata/sata_rcar.c: In function 'sata_rcar_init_controller':
> drivers/ata/sata_rcar.c:821:16: warning: unused variable 'base' [-Wunused-variable]
>   void __iomem *base = priv->base;
>                 ^~~~
> 
> Introduced by commit
> 
>   da77d76b95a0 ("sata_rcar: Reset SATA PHY when Salvator-X board resumes")

Just applied Geert's patch to remove the warning.

Thanks.

-- 
tejun

linux-next: build warning after merge of the libata tree

[Stephen Rothwell]

Hi Tejun,

After merging the libata tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/ata/sata_rcar.c: In function 'sata_rcar_init_controller':
drivers/ata/sata_rcar.c:821:16: warning: unused variable 'base' [-Wunused-variable]
  void __iomem *base = priv->base;
                ^~~~

Introduced by commit

  da77d76b95a0 ("sata_rcar: Reset SATA PHY when Salvator-X board resumes")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the libata tree

[Tejun Heo]

On Wed, Jun 28, 2017 at 03:51:17PM +1000, Stephen Rothwell wrote:
> Hi Tejun,
> 
> After merging the libata tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/ata/libata-scsi.c: In function 'ata_scsi_var_len_cdb_xlat':
> drivers/ata/libata-scsi.c:4194:1: warning: label 'unspprt_sa' defined but not used [-Wunused-label]
>  unspprt_sa:
>  ^
> 
> Introduced by commit
> 
>   b1ffbf854e08 ("libata: Support for an ATA PASS-THROUGH(32) command.")

Fixed up.  Sorry about that.

Thanks.

-- 
tejun

linux-next: build warning after merge of the libata tree

[Stephen Rothwell]

Hi Tejun,

After merging the libata tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/ata/libata-scsi.c: In function 'ata_scsi_var_len_cdb_xlat':
drivers/ata/libata-scsi.c:4194:1: warning: label 'unspprt_sa' defined but not used [-Wunused-label]
 unspprt_sa:
 ^

Introduced by commit

  b1ffbf854e08 ("libata: Support for an ATA PASS-THROUGH(32) command.")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the libata tree

[Jeff Garzik]

On 02/24/2012 07:22 AM, Stephen Rothwell wrote:
> Hi Jeff,
>
> On Fri, 24 Feb 2012 15:14:10 +1100 Stephen Rothwell<sfr@canb.auug.org.au>  wrote:
>>
>> On Thu, 23 Feb 2012 23:06:11 -0500 Jeff Garzik<jeff@garzik.org>  wrote:
>>>
>>> A build fix and oops fix were both just pushed out.
>>
>> Excellent, thanks.
>
> Except the commits in the current version of the libata tree destined for
> linux-next do not fix the warnings I was reporting where the "inline"
> keyword is missing from several static function definitions in
> drivers/ata/libata.h ...

Patchset backed out, and hopefully this will get fixed before it appears 
again in linux-next.

	Jeff

Re: linux-next: build warning after merge of the libata tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

Hi Jeff,

On Fri, 24 Feb 2012 15:14:10 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Thu, 23 Feb 2012 23:06:11 -0500 Jeff Garzik <jeff@garzik.org> wrote:
> >
> > A build fix and oops fix were both just pushed out.
> 
> Excellent, thanks.

Except the commits in the current version of the libata tree destined for
linux-next do not fix the warnings I was reporting where the "inline"
keyword is missing from several static function definitions in
drivers/ata/libata.h ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the libata tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

Hi Jeff,

On Thu, 23 Feb 2012 23:06:11 -0500 Jeff Garzik <jeff@garzik.org> wrote:
>
> A build fix and oops fix were both just pushed out.

Excellent, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the libata tree

[Jeff Garzik]

On 02/23/2012 10:08 PM, Stephen Rothwell wrote:
> Hi Jeff, Matthew,
>
> On Mon, 13 Feb 2012 16:27:40 +1100 Stephen Rothwell<sfr@canb.auug.org.au>  wrote:
>>
>> After merging the libata tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced this warning:
>>
>> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
>> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
>>
>> Introduced by commits 75d22cd567ca ("libata: Bind the Linux device tree
>> to the ACPI device tree") and c9df614ade0e ("libata: Add links between
>> removable devices and docks").
>
> Ping?

A build fix and oops fix were both just pushed out.

	Jeff

Re: linux-next: build warning after merge of the libata tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]

Hi Jeff, Matthew,

On Mon, 13 Feb 2012 16:27:40 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the libata tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
> drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
> 
> Introduced by commits 75d22cd567ca ("libata: Bind the Linux device tree
> to the ACPI device tree") and c9df614ade0e ("libata: Add links between
> removable devices and docks").

Ping?
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the libata tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

Hi Jeff,

After merging the libata tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:132:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
drivers/ata/libata.h:133:13: warning: 'ata_acpi_bind_dock' defined but not used [-Wunused-function]
drivers/ata/libata.h:134:13: warning: 'ata_acpi_unbind_dock' defined but not used [-Wunused-function]

Introduced by commits 75d22cd567ca ("libata: Bind the Linux device tree
to the ACPI device tree") and c9df614ade0e ("libata: Add links between
removable devices and docks").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]