linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Dave Young <dyoung@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	akpm@linux-foundation.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: linux-next: build failure after merge of the printk tree
Date: Fri, 2 Mar 2018 16:54:54 +0100	[thread overview]
Message-ID: <20180302155454.eme5gplxdcltvwkw@pathway.suse.cz> (raw)
In-Reply-To: <20180302160732.12691fbc@canb.auug.org.au>

On Fri 2018-03-02 16:07:32, Stephen Rothwell wrote:
> Hi Petr,
> 
> After merging the printk tree, today's linux-next build (bfin
> BF518F-EZBRD_defconfig) failed like this:
> 
> lib/dump_stack.o: In function `dump_stack':
> lib/dump_stack.c:122: multiple definition of `dump_stack'
> arch/blackfin/kernel/dumpstack.o:arch/blackfin/kernel/dumpstack.c:166: first defined here
> 
> Presumably caused by commit
> 
>   8040af489957 ("printk: move dump stack related code to lib/dump_stack.c")

I could confirm that it is caused by this commit. I have temporary
removed it from printk.git.

> (Though it is not immediately obvious why.)

It is a mistery to me. The error appears when I move any of
dump_stack_print_info() or show_regs_print_info() function
definitions from kernel/printk/printk.c to lib/dump_stack.c.
All the other changes seems unrelated.

The thing is that we basically do not touch dump_stack() definition
by that patch.

> This fails all the blackfin builds.  nds32 (a new architecture) also
> has a dump_stack function.

Good to know!

Best Regards,
Petr

  reply	other threads:[~2018-03-02 15:54 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02  5:07 linux-next: build failure after merge of the printk tree Stephen Rothwell
2018-03-02 15:54 ` Petr Mladek [this message]
2018-03-03  2:43   ` Stephen Rothwell
2018-03-03 14:47   ` Sergey Senozhatsky
2018-03-05  3:20     ` Dave Young
2018-03-05  5:27       ` Greentime Hu
2018-03-05  5:41         ` Sergey Senozhatsky
2018-03-05 12:25     ` Petr Mladek
  -- strict thread matches above, loose matches on Subject: below --
2023-01-15 23:23 Stephen Rothwell
2023-01-16 15:54 ` Petr Mladek
2022-11-21  0:00 Stephen Rothwell
2022-11-21 13:42 ` Petr Mladek
2021-07-20  7:43 Stephen Rothwell
2021-07-20  8:17 ` Naresh Kamboju
2021-07-20 12:28   ` Chris Down
2021-07-21  8:57     ` Petr Mladek
2021-07-21 11:22       ` Chris Down
2021-07-21 12:49         ` Petr Mladek
2021-07-22 23:01 ` Stephen Rothwell
2021-07-23 11:14   ` Petr Mladek
2021-07-23 12:14     ` Chris Down
2020-07-29 11:03 Stephen Rothwell
2020-07-29 11:47 ` Herbert Xu
2020-07-28  1:49 Stephen Rothwell
2020-07-28  1:51 ` Herbert Xu
2020-07-28  2:21   ` Stephen Rothwell
2020-07-28  1:54 ` Sergey Senozhatsky
2020-07-28  2:24   ` Stephen Rothwell
2020-06-21  3:15 Stephen Rothwell
2020-06-21  3:26 ` Herbert Xu
2020-06-23  0:26 ` Stephen Rothwell
2020-06-23 12:16   ` Petr Mladek
2020-06-23 12:19     ` Herbert Xu
2020-06-23 14:28       ` Petr Mladek
2020-06-23 15:17         ` Peter Zijlstra
2020-06-24  8:22           ` Petr Mladek
2020-06-24  0:20         ` Herbert Xu
2020-06-24  8:19           ` Petr Mladek
2020-06-24  8:21             ` Herbert Xu
2019-12-05 22:25 Stephen Rothwell
2019-12-06 10:03 ` Petr Mladek
2017-12-07  0:37 Stephen Rothwell
2017-12-07  1:26 ` Sergey Senozhatsky
2017-12-07 13:12   ` Petr Mladek
2017-12-06  3:23 Stephen Rothwell
2017-12-06  4:28 ` Sergey Senozhatsky
2017-12-06 10:17 ` Petr Mladek
2017-12-06 10:39   ` Sergey Senozhatsky
2017-12-07  1:24   ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180302155454.eme5gplxdcltvwkw@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dyoung@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).