From: Minchan Kim <minchan@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: linux-next: build warning after merge of the akpm-current tree
Date: Mon, 7 May 2018 23:10:39 +0900 [thread overview]
Message-ID: <20180507141039.GA1934@rodete-desktop-imager.corp.google.com> (raw)
In-Reply-To: <4fb39549-8902-950d-3076-82a11b1c5102@infradead.org>
On Fri, May 04, 2018 at 08:39:43AM -0700, Randy Dunlap wrote:
> On 05/03/2018 09:17 PM, Stephen Rothwell wrote:
> > Hi Andrew,
> >
> > After merging the akpm-current tree, today's linux-next build
> > (x86_64_allmodconfig) produced this warning:
> >
> > drivers/block/zram/zram_drv.c: In function 'read_block_state':
> > drivers/block/zram/zram_drv.c:674:16: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 5 has type '__kernel_time_t {aka long int}' [-Wformat=]
> > "%12lu %12llu.%06lu %c%c%c\n",
> > ~~~~~^
> > %12lu
> > (unsigned long)index, ts.tv_sec,
> > ~~~~~~~~~
> >
> > Introduced by commit
> >
> > 827c7dbda8eb ("zram-introduce-zram-memory-tracking-update-fix-fix")
> >
>
> typedef __s64 time64_t;
>
> struct timespec64 {
> time64_t tv_sec; /* seconds */
> long tv_nsec; /* nanoseconds */
> };
>
> time64_t is signed. Also, %lu on i386 et al is for 32-bit longs.
> I guess that "we" will need to cast ts.tv_sec to (s64) and use %lld to print it
> in order to satisfy other $arch.
>
> Andrew, want to add a fix-fix-fix patch?
Thanks for the fix during I am absent, Andrew and Randy.
Here goes fix.
Andrew please fold this patchset.
>From 16569c7abb641930b4e4ec66b4dc2005e6c87be8 Mon Sep 17 00:00:00 2001
From: Minchan Kim <minchan@kernel.org>
Date: Mon, 7 May 2018 23:00:16 +0900
Subject: [PATCH] zram-introduce-zram-memory-tracking-update-fix-fix-fix
fix compile warning
drivers/block/zram/zram_drv.c: In function 'read_block_state':
drivers/block/zram/zram_drv.c:674:16: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 5 has type '__kernel_time_t {aka long int}' [-Wformat=]
"%12lu %12llu.%06lu %c%c%c\n",
~~~~~^
%12lu
(unsigned long)index, ts.tv_sec,
~~~~~~~~~
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Minchan Kim <minchan@kernel.org>
---
drivers/block/zram/zram_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index f2f3104b2b48..635307e3238b 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -671,8 +671,8 @@ static ssize_t read_block_state(struct file *file, char __user *buf,
ts = ktime_to_timespec64(zram->table[index].ac_time);
copied = snprintf(kbuf + written, count,
- "%12lu %12llu.%06lu %c%c%c\n",
- (unsigned long)index, ts.tv_sec,
+ "%12lu %12lld.%06ld %c%c%c\n",
+ (unsigned long)index, (s64)ts.tv_sec,
ts.tv_nsec / NSEC_PER_USEC,
zram_test_flag(zram, index, ZRAM_SAME) ? 's' : '.',
zram_test_flag(zram, index, ZRAM_WB) ? 'w' : '.',
--
2.17.0.441.gb46fe60e1d-goog
next prev parent reply other threads:[~2018-05-07 14:10 UTC|newest]
Thread overview: 157+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 4:17 linux-next: build warning after merge of the akpm-current tree Stephen Rothwell
2018-05-04 15:39 ` Randy Dunlap
2018-05-07 14:10 ` Minchan Kim [this message]
2018-05-07 16:47 ` Randy Dunlap
2018-05-08 10:48 ` Minchan Kim
-- strict thread matches above, loose matches on Subject: below --
2022-04-27 6:41 Stephen Rothwell
2022-04-27 14:15 ` Liam Howlett
2022-04-13 5:15 Stephen Rothwell
2022-04-13 6:20 ` Yu Zhao
2022-02-09 5:58 Stephen Rothwell
2022-02-09 8:09 ` Huang, Ying
2022-02-07 4:06 Stephen Rothwell
2022-02-02 3:54 Stephen Rothwell
2022-02-03 23:06 ` Andrew Morton
2022-02-03 23:21 ` Randy Dunlap
2022-01-06 15:45 Stephen Rothwell
2021-12-23 23:12 Stephen Rothwell
2021-11-23 5:26 Stephen Rothwell
2021-11-23 8:38 ` Suren Baghdasaryan
2021-11-23 19:03 ` Suren Baghdasaryan
2021-11-23 22:26 ` Stephen Rothwell
2021-11-23 22:30 ` Suren Baghdasaryan
2021-07-19 7:52 Stephen Rothwell
2021-07-19 8:47 ` Feng Tang
2021-05-21 5:39 Stephen Rothwell
2021-05-21 6:53 ` Miaohe Lin
2021-03-30 20:04 Stephen Rothwell
2021-03-15 5:35 Stephen Rothwell
2021-03-16 18:18 ` Minchan Kim
2021-03-16 21:49 ` Stephen Rothwell
2021-03-16 23:09 ` Jonathan Corbet
2021-03-17 13:22 ` Mauro Carvalho Chehab
2020-12-10 9:38 Stephen Rothwell
2020-12-10 16:05 ` Georgi Djakov
2020-11-13 6:01 Stephen Rothwell
2020-11-16 10:03 ` Andy Shevchenko
2020-11-06 6:26 Stephen Rothwell
2020-11-05 6:45 Stephen Rothwell
2020-11-05 7:03 ` Mike Rapoport
2020-11-05 7:42 ` Anand K. Mistry
2020-11-05 7:45 ` Anand K. Mistry
2020-11-05 9:17 ` Mike Rapoport
2020-11-05 8:00 ` Stephen Rothwell
2020-11-05 8:03 ` Stephen Rothwell
2020-09-14 7:00 Stephen Rothwell
2020-09-15 4:03 ` David Gow
2020-09-15 4:16 ` Stephen Rothwell
2020-09-15 9:57 ` Marco Elver
2020-09-14 6:57 Stephen Rothwell
2020-07-17 10:31 Stephen Rothwell
2020-07-17 17:47 ` Roman Gushchin
2020-07-09 9:11 Stephen Rothwell
2020-06-21 14:40 Stephen Rothwell
2020-03-31 8:56 Stephen Rothwell
2020-04-01 22:58 ` Andrew Morton
2020-04-01 23:00 ` Jason Gunthorpe
2020-04-01 23:06 ` Mike Kravetz
2020-03-13 10:42 Stephen Rothwell
2020-03-13 10:55 ` Baoquan He
2020-03-13 12:56 ` Baoquan He
2020-03-14 0:09 ` Stephen Rothwell
2020-03-14 0:35 ` Baoquan He
2020-03-16 4:58 ` Baoquan He
2020-03-16 6:13 ` Stephen Rothwell
2020-03-16 6:51 ` Baoquan He
2020-03-16 6:54 ` Stephen Rothwell
2020-03-12 7:31 Stephen Rothwell
2020-03-12 16:48 ` Mike Kravetz
2020-03-12 7:27 Stephen Rothwell
2020-03-13 0:31 ` Andrew Morton
2020-03-05 5:37 Stephen Rothwell
2020-03-05 5:54 ` Dmitry Vyukov
2020-03-07 5:03 ` Walter Wu
2020-03-05 8:54 ` Walter Wu
2020-03-05 9:33 ` Stephen Rothwell
2020-03-06 18:59 ` Walter Wu
2020-03-06 20:45 ` Walter Wu
2020-02-17 2:00 Stephen Rothwell
2019-11-06 7:05 Stephen Rothwell
2019-11-06 7:52 ` Shaokun Zhang
2019-11-06 6:54 Stephen Rothwell
2019-08-07 8:00 Stephen Rothwell
2019-08-07 11:29 ` Rikard Falkeborn
2019-08-07 23:31 ` Stephen Rothwell
2019-07-31 6:16 Stephen Rothwell
2019-07-31 12:01 ` Jia-Ju Bai
2019-07-31 6:11 Stephen Rothwell
2019-07-31 6:28 ` Miles Chen
2019-08-01 5:51 ` Stephen Rothwell
2019-08-01 6:15 ` Michal Hocko
2019-08-01 6:30 ` Miles Chen
2019-08-01 6:38 ` Michal Hocko
2019-08-01 6:39 ` Stephen Rothwell
2019-08-01 6:42 ` Miles Chen
2019-07-29 3:48 Stephen Rothwell
2019-07-29 3:44 Stephen Rothwell
2019-05-30 4:55 Stephen Rothwell
2019-05-30 9:02 ` Matteo Croce
2019-03-29 2:39 Stephen Rothwell
2019-04-16 6:52 ` Stephen Rothwell
2019-04-16 22:45 ` Andrew Morton
2019-01-31 5:01 Stephen Rothwell
2018-06-08 4:45 Stephen Rothwell
2018-04-06 4:53 Stephen Rothwell
2018-01-02 7:04 Stephen Rothwell
2017-12-15 2:48 Stephen Rothwell
2017-11-23 2:01 Stephen Rothwell
2017-11-13 5:54 Stephen Rothwell
2017-11-13 5:42 Stephen Rothwell
2017-11-13 8:09 ` Michal Hocko
2017-11-13 8:23 ` Michal Hocko
2017-11-13 11:43 ` Arnd Bergmann
2017-11-13 11:54 ` Michal Hocko
2017-11-13 12:24 ` Arnd Bergmann
2017-11-13 12:29 ` Michal Hocko
2017-11-16 22:44 ` Stephen Rothwell
2017-11-17 3:53 ` Stephen Rothwell
2017-11-17 9:36 ` Zhangshaokun
2017-11-17 9:56 ` Arnd Bergmann
2017-08-01 5:22 Stephen Rothwell
2017-05-26 2:43 Stephen Rothwell
2017-05-26 10:16 ` Jeff Layton
2017-05-26 11:28 ` Dave Kleikamp
2017-05-19 4:44 Stephen Rothwell
2017-05-15 1:56 Stephen Rothwell
2017-05-15 4:02 ` Xunlei Pang
2017-05-15 5:07 ` Stephen Rothwell
2017-02-02 6:49 Stephen Rothwell
2016-11-09 4:10 Stephen Rothwell
2016-11-09 7:18 ` Huang Shijie
2016-11-09 21:21 ` Andrew Morton
2016-11-10 2:56 ` Stephen Rothwell
2016-06-23 6:53 Stephen Rothwell
2016-06-23 14:00 ` Mel Gorman
2016-05-27 3:07 Stephen Rothwell
2016-05-27 19:53 ` Andrew Morton
2016-04-29 6:45 Stephen Rothwell
2016-04-29 6:55 ` Stephen Rothwell
2016-04-29 13:32 ` Josh Poimboeuf
2016-04-29 14:03 ` Josh Poimboeuf
2016-04-30 5:52 ` Stephen Rothwell
2015-07-16 5:26 Stephen Rothwell
2015-07-16 23:00 ` Andrew Morton
2015-06-04 12:29 Stephen Rothwell
2015-06-04 13:56 ` Andrea Arcangeli
2015-02-04 7:48 Stephen Rothwell
2015-02-04 7:53 ` Jan Kiszka
2015-01-19 7:45 Stephen Rothwell
2015-01-19 15:50 ` Chris Mason
2014-10-30 5:19 Stephen Rothwell
2014-10-30 9:00 ` Aneesh Kumar K.V
2014-09-26 10:42 Stephen Rothwell
2014-09-29 21:30 ` Andrew Morton
2014-09-08 8:57 Stephen Rothwell
2014-06-20 5:27 Stephen Rothwell
2014-06-20 5:29 ` Yinghai Lu
2014-06-16 1:57 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507141039.GA1934@rodete-desktop-imager.corp.google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).