linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Sterba <dsterba@suse.cz>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>,
	Adam Borowski <kilobyte@angband.pl>
Subject: linux-next: manual merge of the btrfs-kdave tree with the btrfs-fixes tree
Date: Wed, 16 May 2018 09:47:04 +1000	[thread overview]
Message-ID: <20180516094704.652238c9@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

Hi David,

Today's linux-next merge of the btrfs-kdave tree got a conflict in:

  fs/btrfs/props.c

between commit:

  f764b4f4bb26 ("btrfs: property: Set incompat flag if lzo/zstd compression is set")

from the btrfs-fixes tree and commit:

  e37739baf401 ("btrfs: allow setting zstd level")

from the btrfs-kdave tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc fs/btrfs/props.c
index dc6140013ae8,c85bb04a1cc3..000000000000
--- a/fs/btrfs/props.c
+++ b/fs/btrfs/props.c
@@@ -391,17 -390,14 +391,17 @@@ static int prop_compression_apply(struc
  		return 0;
  	}
  
 -	if (!strncmp("lzo", value, 3))
 +	if (!strncmp("lzo", value, 3)) {
  		type = BTRFS_COMPRESS_LZO;
 -	else if (!strncmp("zlib", value, 4))
 +		btrfs_set_fs_incompat(fs_info, COMPRESS_LZO);
 +	} else if (!strncmp("zlib", value, 4)) {
  		type = BTRFS_COMPRESS_ZLIB;
- 	} else if (!strncmp("zstd", value, len)) {
 -	else if (!strncmp("zstd", value, 4))
++	} else if (!strncmp("zstd", value, 4)) {
  		type = BTRFS_COMPRESS_ZSTD;
 -	else
 +		btrfs_set_fs_incompat(fs_info, COMPRESS_ZSTD);
 +	} else {
  		return -EINVAL;
 +	}
  
  	BTRFS_I(inode)->flags &= ~BTRFS_INODE_NOCOMPRESS;
  	BTRFS_I(inode)->flags |= BTRFS_INODE_COMPRESS;

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2018-05-15 23:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 23:47 Stephen Rothwell [this message]
2019-04-04 23:03 linux-next: manual merge of the btrfs-kdave tree with the btrfs-fixes tree Stephen Rothwell
2019-08-08  0:54 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180516094704.652238c9@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=dsterba@suse.cz \
    --cc=kilobyte@angband.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=misono.tomohiro@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).