Hi Parav, On Fri, 27 Jul 2018 04:57:41 +0000 Parav Pandit wrote: > > > for (i = 0; i < smcibdev->pattr[ibport - 1].gid_tbl_len; i++) { > > - memset(&_gid, 0, SMC_GID_SIZE); > > - memset(&gattr, 0, sizeof(gattr)); > > - if (ib_query_gid(smcibdev->ibdev, ibport, i, &_gid, &gattr)) > > + gattr = rdma_get_gid_attr(smcibdev->ibdev, ibport, i); > > + if (IS_ERR(gattr)) > > continue; > > - if (!gattr.ndev) > > + if (!gattr->ndev) > > continue; > This requires a small fix. > If (!gattr->ndev { > rdma_put_gid_attr(gattr); > continue; > } Thanks, I have fixed this up for Monday. -- Cheers, Stephen Rothwell