Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build warning after merge of the usb tree
@ 2018-09-11  2:47 Stephen Rothwell
  2018-09-11  7:37 ` [PATCH] usb: core: remove flags variable in __usb_hcd_giveback_urb() Sebastian Andrzej Siewior
  2018-09-11  8:12 ` linux-next: build warning after merge of the usb tree Greg KH
  0 siblings, 2 replies; 3+ messages in thread
From: Stephen Rothwell @ 2018-09-11  2:47 UTC (permalink / raw)
  To: Greg KH
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Sebastian Andrzej Siewior


[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

Hi Greg,

After merging the usb tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/usb/core/hcd.c: In function '__usb_hcd_giveback_urb':
drivers/usb/core/hcd.c:1741:16: warning: unused variable 'flags' [-Wunused-variable]
  unsigned long flags;
                ^~~~~

Introduced by commit

  ed194d136769 ("usb: core: remove local_irq_save() around ->complete() handler")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] usb: core: remove flags variable in __usb_hcd_giveback_urb()
  2018-09-11  2:47 linux-next: build warning after merge of the usb tree Stephen Rothwell
@ 2018-09-11  7:37 ` Sebastian Andrzej Siewior
  2018-09-11  8:12 ` linux-next: build warning after merge of the usb tree Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-09-11  7:37 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Greg KH, Linux-Next Mailing List, Linux Kernel Mailing List

In commit ed194d1367698 ("usb: core: remove local_irq_save() around
->complete() handler") I removed the only user of the flags variable and
forgot to remove the variable, leading to warning because it is unused
now.
Remove the unused variable.

Fixes: ed194d1367698 ("usb: core: remove local_irq_save() around
       ->complete() handler")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/usb/core/hcd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index f985d2303095c..487025d31d44c 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -1738,7 +1738,6 @@ static void __usb_hcd_giveback_urb(struct urb *urb)
 	struct usb_hcd *hcd = bus_to_hcd(urb->dev->bus);
 	struct usb_anchor *anchor = urb->anchor;
 	int status = urb->unlinked;
-	unsigned long flags;
 
 	urb->hcpriv = NULL;
 	if (unlikely((urb->transfer_flags & URB_SHORT_NOT_OK) &&
-- 
2.19.0.rc2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: linux-next: build warning after merge of the usb tree
  2018-09-11  2:47 linux-next: build warning after merge of the usb tree Stephen Rothwell
  2018-09-11  7:37 ` [PATCH] usb: core: remove flags variable in __usb_hcd_giveback_urb() Sebastian Andrzej Siewior
@ 2018-09-11  8:12 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2018-09-11  8:12 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Sebastian Andrzej Siewior

On Tue, Sep 11, 2018 at 12:47:43PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the usb tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/usb/core/hcd.c: In function '__usb_hcd_giveback_urb':
> drivers/usb/core/hcd.c:1741:16: warning: unused variable 'flags' [-Wunused-variable]
>   unsigned long flags;
>                 ^~~~~
> 
> Introduced by commit
> 
>   ed194d136769 ("usb: core: remove local_irq_save() around ->complete() handler")

Ugh, sorry I missed this :(

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-11  2:47 linux-next: build warning after merge of the usb tree Stephen Rothwell
2018-09-11  7:37 ` [PATCH] usb: core: remove flags variable in __usb_hcd_giveback_urb() Sebastian Andrzej Siewior
2018-09-11  8:12 ` linux-next: build warning after merge of the usb tree Greg KH

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git