From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Rothwell Subject: Re: linux-next: Tree for Oct 15 Date: Tue, 16 Oct 2018 13:19:27 +1100 Message-ID: <20181016131927.6ceba6ab@canb.auug.org.au> References: <20181015192546.15faf3a1@canb.auug.org.au> <20181015193914.GA9881@roeck-us.net> <20181016073359.3fa7bb32@canb.auug.org.au> <20181015222213.GA31415@roeck-us.net> <20181016130216.3a417381@canb.auug.org.au> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/j_E700Tl6v3gnhQuir/=FN3"; protocol="application/pgp-signature" Return-path: In-Reply-To: <20181016130216.3a417381@canb.auug.org.au> Sender: linux-kernel-owner@vger.kernel.org To: Guenter Roeck Cc: Linux-Next Mailing List , Linux Kernel Mailing List , Mike Rapoport , Andrew Morton , Michael Ellerman , Benjamin Herrenschmidt , PowerPC List-Id: linux-next.vger.kernel.org --Sig_/j_E700Tl6v3gnhQuir/=FN3 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, On Tue, 16 Oct 2018 13:02:16 +1100 Stephen Rothwell = wrote: > > Reverting fe3d2a45e8079fdd7d4da1ff07f4b40bc3cb499f (and the following 2 > commits) produces a kernel that boots. Instead of that, I applied this patch on top of linux-next and it boots and produces a stack trace ... From: Stephen Rothwell Date: Tue, 16 Oct 2018 13:07:01 +1100 Subject: [PATCH] mm/memblock.c: use dump_stack() instead of WARN_ON_ONCE for the alignment checks Using WARN_ON_ONCE too early causes the PowerPC kernel to fail. Signed-off-by: Stephen Rothwell --- mm/memblock.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index 5fefc70253ee..f2ef3915a356 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1298,8 +1298,10 @@ static phys_addr_t __init memblock_alloc_range_nid(p= hys_addr_t size, { phys_addr_t found; =20 - if (WARN_ON_ONCE(!align)) + if (!align) { + dump_stack(); align =3D SMP_CACHE_BYTES; + } =20 found =3D memblock_find_in_range_node(size, align, start, end, nid, flags); @@ -1423,8 +1425,10 @@ static void * __init memblock_alloc_internal( if (WARN_ON_ONCE(slab_is_available())) return kzalloc_node(size, GFP_NOWAIT, nid); =20 - if (WARN_ON_ONCE(!align)) + if (!align) { + dump_stack(); align =3D SMP_CACHE_BYTES; + } =20 if (max_addr > memblock.current_limit) max_addr =3D memblock.current_limit; --=20 2.18.0 So, patch "memblock: stop using implicit alignment to SMP_CACHE_BYTES" should *not* remove the 0 -> SMP_CACHE_BYTES update from mm/memblock.c and just add the dump_stack(). --=20 Cheers, Stephen Rothwell --Sig_/j_E700Tl6v3gnhQuir/=FN3 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAlvFSq8ACgkQAVBC80lX 0Gz+ywf/T90EMZ0R3tFjrcmUpFEmGa2TFSBV6p/JeR+noxv+SOMpS8u9NuxxzUQr eU7HgWqjyJ+pWsq5AfzalpVL4LBFHx1sVUFOe+K1DP2cYWO3njbQgOCKMfK5eRvu hQYvktyvomKwCg+95pHtoPrLbrvL+TcmdW7dGv+naFC8tnvRY4o8w9zxqdAnmeF9 6eFa0CFta79sUGQSi6lZNZyzziw7FI/tBz3VaFmr99uaPnPdBHlaSv3hTKgT2lKs kKpqRBkFmDh9ebca6r4/du9w8H4dC/3y0aRL6P3ZsE3KfovXRfN2br24KcXQOQ5Q VbBg3u6MSG7cZGD9tdzGPZI1D3DYeA== =PHN3 -----END PGP SIGNATURE----- --Sig_/j_E700Tl6v3gnhQuir/=FN3--