Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jia-Ju Bai <baijiaju1990@gmail.com>,
	dma <dmaengine@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the slave-dma tree
Date: Mon, 26 Nov 2018 13:39:38 +0530
Message-ID: <20181126080855.GS3175@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20181126165903.33b1d872@canb.auug.org.au>

Hi Stephen,

On 26-11-18, 16:59, Stephen Rothwell wrote:
> Hi Vinod,
> 
> After merging the slave-dma tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/dma/coh901318.c: In function 'coh901318_config':
> drivers/dma/coh901318.c:1805:16: warning: unused variable 'flags' [-Wunused-variable]
>   unsigned long flags;
>                 ^~~~~
> 
> Introduced by commit
> 
>   627469e4445b ("dmaengine: coh901318: Fix a double-lock bug")

Thanks for the report, I have fixed it up with below:

-- >8 --

>From fbbdec195155b4497cb83be37788865f98f31dca Mon Sep 17 00:00:00 2001
From: Vinod Koul <vkoul@kernel.org>
Date: Mon, 26 Nov 2018 13:34:15 +0530
Subject: [PATCH] dmaengine: coh901318: Remove unused variable

Commit 627469e4445b ("dmaengine: coh901318: Fix a double-lock bug") left
flags variable unused, so remove it to fix the warning.

drivers/dma/coh901318.c: In function 'coh901318_config':
drivers/dma/coh901318.c:1805:16: warning: unused variable 'flags' [-Wunused-variable]
  unsigned long flags;
                ^~~~~

Reported-By: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/dma/coh901318.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/coh901318.c b/drivers/dma/coh901318.c
index fd862a478738..b69d66e44052 100644
--- a/drivers/dma/coh901318.c
+++ b/drivers/dma/coh901318.c
@@ -1802,7 +1802,6 @@ static struct dma_chan *coh901318_xlate(struct of_phandle_args *dma_spec,
 static int coh901318_config(struct coh901318_chan *cohc,
 			    struct coh901318_params *param)
 {
-	unsigned long flags;
 	const struct coh901318_params *p;
 	int channel = cohc->id;
 	void __iomem *virtbase = cohc->base->virtbase;
-- 
2.14.5

-- 
~Vinod

  reply index

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26  5:59 Stephen Rothwell
2018-11-26  8:09 ` Vinod Koul [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-02-14  0:00 Stephen Rothwell
2020-02-14  4:41 ` Vinod Koul
2019-08-12  7:14 Stephen Rothwell
2019-08-12  9:14 ` Arnd Bergmann
2019-08-12  9:21   ` Stephen Rothwell
2018-09-13  2:22 Stephen Rothwell
2018-09-13  7:17 ` Angelo Dureghello
2018-07-04  3:30 Stephen Rothwell
2018-07-04  4:20 ` Vinod
2018-07-05  2:47   ` Stephen Rothwell
2018-07-05  5:01     ` Vinod
2016-06-09  1:18 Stephen Rothwell
2016-06-09  6:04 ` Appana Durga Kedareswara Rao
2015-03-30  6:20 Stephen Rothwell
2015-03-30  6:26 ` Appana Durga Kedareswara Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181126080855.GS3175@vkoul-mobl.Dlink \
    --to=vkoul@kernel.org \
    --cc=baijiaju1990@gmail.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git